Yair Zaslavsky has posted comments on this change.

Change subject: core:no task id in engine log for revert task
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractSPMAsyncTaskHandler.java
Line 62:                 getTaskObjects())
Line 63:                 );
Line 64:         Guid taskId = taskCreationInfo.getTaskID();
Line 65:         getReturnValue().getTaskIdList().add(taskId);
Line 66:         if (isRevertedTask) {
Eli, I would consider maybe adding more useful information that can be obtained 
from the taskCreationInfo.
Line 67:             log.infoFormat("Reverted task ID is {0}.", taskId);
Line 68:         }
Line 69:     }
Line 70: 


--
To view, visit http://gerrit.ovirt.org/10804
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6a1dbeadfb512bbed81c3d2fa7e18ee4a997d92
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to