Alon Bar-Lev has posted comments on this change. Change subject: packaging: updated setup to fail immediately if adding host fails ......................................................................
Patch Set 2: (2 inline comments) .................................................... File packaging/fedora/setup/common_utils.py Line 965: return False Line 966: else: Line 967: return askYesNo(question) Line 968: Line 969: def retry(func, expectedException=Exception, failOnException=None, tries=None, timeout=None, sleep=1): =False? Line 970: """ Line 971: Retry a function. Wraps the retry logic so you don't have to Line 972: implement it each time you need it. Line 973: Line 1001: # Check the message of the raised exception and compare it Line 1002: # with the message on 'failOn' exception. If they are the Line 1003: # same, stop the execution. This allows us to stop this flow Line 1004: # if there's a specific exception raised. Line 1005: if failOnException and e.message == failOnException.message: This *IS* ugly! better to throw a specific exception type. Line 1006: raise failOnException Line 1007: Line 1008: if tries == 0: Line 1009: raise -- To view, visit http://gerrit.ovirt.org/10578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I404af2b1702dbe5881cbd60d06a1b976b7a651a7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
