[Engine-patches] Change in ovirt-engine[master]: core: Improve logs in DbUserCacheManager

[abonas]

Alissa Bonas has uploaded a new change for review.

Change subject: core: Improve logs in DbUserCacheManager
......................................................................

core: Improve logs in DbUserCacheManager

Make loggings in DbUserCacheManager more clear

Change-Id: I46c0cffd1280f2781000b608496f1e4104faca8a
Signed-off-by: Alissa Bonas <abo...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/25/10825/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java
index 758cc69..483cd57 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java
@@ -29,6 +29,7 @@
 import org.ovirt.engine.core.utils.timer.SchedulerUtilQuartzImpl;
 
 public class DbUserCacheManager {
+    private static Log log = LogFactory.getLog(DbUserCacheManager.class);
     private static DbUserCacheManager _instance = new DbUserCacheManager();
     private String jobId;
     private boolean initialized = false;
@@ -80,9 +81,9 @@
     /**
      * detect differences between current DB users and the directory server 
users/groups and persist them
      *
-     * @param DbUser
+     * @param dbUser
      *            DB user
-     * @param LdapUser
+     * @param adUser
      *            LDAP user
      * @param updatedUsers
      *            list of changed users.
@@ -156,7 +157,7 @@
 
     public void refreshAllUserData(List<LdapGroup> updatedGroups) {
         try {
-            log.info("DbUserCacheManager::refreshAllUserData() - entered");
+            log.info("Start refreshing all users data");
             List<DbUser> allUsers = 
DbFacade.getInstance().getDbUserDao().getAll();
 
             List<String> domainsList = LdapBrokerUtils.getDomainsList(true);
@@ -221,7 +222,7 @@
                 }
             }
         } catch (RuntimeException e) {
-            log.error("DbUserCacheManager::refreshAllUserData() - failed with 
exception", e);
+            log.error("Failed to refresh users data.", e);
         }
     }
 
@@ -304,5 +305,4 @@
         }
     }
 
-    private static Log log = LogFactory.getLog(DbUserCacheManager.class);
 }


--
To view, visit http://gerrit.ovirt.org/10825
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I46c0cffd1280f2781000b608496f1e4104faca8a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches