Keith Robertson has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File src/engine-iso-uploader.py
Line 413: if self.configuration.get("insecure"):
Line 414: params["insecure"] = True
Line 415: # Otherwise, use ca_file
Line 416: else:
Line 417: params["ca_file"] =
self.configuration.get("engine_ca")
Repeating here for posterity:
What problem are you trying to solve with this patch? As near as I can tell
you are only trying to prevent a condition where the API would receive
'insecure=True' & 'ca_file!=None'. Why is this a problem? If 'insecure == true'
the API should prefer insecure over validation of certs? Please explain.
In any case, the API should do parameter validation. If a consumer calls the
API's constructor with an invalid set of options it should throw an exception
(and I think this is very possible/likely).
Line 418:
Line 419: # Create an API object
Line 420: self.api = API(**params)
Line 421:
--
To view, visit http://gerrit.ovirt.org/10815
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I015c6b5441f0d1e33bb3aae378a59ad8557f9da5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
