Muli Salem has posted comments on this change.
Change subject: engine: Add Vds Port Validation 65535 (#871328)
..
Patch Set 2: (3 inline comments)
File
backend/manager/modul
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2728/
Build Number: 2728
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 3,445
-
Changes Sinc
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: fix in GlusterManager
..
engine: fix in GlusterManager
A parallel change in the GlusterServersListVDSCommand had changed the
return type from Set
Omer Frenkel has posted comments on this change.
Change subject: engine: fix in GlusterManager
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9135
To unsubscribe, visit http://ger
ofri masad has posted comments on this change.
Change subject: core: Quota refactor - parameters
..
Patch Set 14: (6 inline comments)
File
backend/manager/modules/bll/src/ma
Hunt Xu has posted comments on this change.
Change subject: packaging: validate MAC addresses range provided by the user
..
Patch Set 3:
Hi, Simon and Moran
Now this patch is only to add a validation function for MAC
addresses
Eli Mesika has uploaded a new change for review.
Change subject: core:Hosts from another data center ...(#874660)
..
core:Hosts from another data center ...(#874660)
Hosts from another data center displayed when clicked on Hosts
Moti Asayag has posted comments on this change.
Change subject: engine: Add Vds Port Validation 65535 (#871328)
..
Patch Set 2: (3 inline comments)
File
backend/manager/modu
Itamar Heim has posted comments on this change.
Change subject: [wip] core: move the storage domain V3 to DC 3.2
..
Patch Set 1:
why do we need all the "if version > x" in the code, if the config has the list
of supported stor
Shahar Havivi has posted comments on this change.
Change subject: engine: prevent NPE in clusters tab
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9181
To unsubscribe, visit http://gerrit
Daniel Erez has posted comments on this change.
Change subject: engine: prevent NPE in clusters tab
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
please replace prefix with "webadmin:"
Sharad Mishra has posted comments on this change.
Change subject: engine: prevent NPE in clusters tab
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9181
To unsubscribe
Ravi Nori has posted comments on this change.
Change subject: tools: engine-config need to remove all ver 2.2 values
..
Patch Set 4:
I have moved EmulatedMachine, DesktopAudioDeviceType MaxNumOfCpuPerSocket
MaxNumOfVmSockets M
Arik Hadas has posted comments on this change.
Change subject: engine: Correct migration related events
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9199
To unsubscribe, visit http://gerrit.ovirt.org/setti
Arik Hadas has uploaded a new change for review.
Change subject: engine: Correct migration related events
..
engine: Correct migration related events
The misleading events:
"Migration of VM xp_desktop from Host knight failed. Er
Sharad Mishra has posted comments on this change.
Change subject: engine: Remove redundant event on run vm command
..
Patch Set 1: (1 inline comment)
File
backend/manager/mo
Moti Asayag has posted comments on this change.
Change subject: engine: Refactor statements with ternary operators
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9186
To unsubscribe, visit
Arik Hadas has posted comments on this change.
Change subject: engine: Refactor statements with ternary operators
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9186
To unsubscribe, visit http://gerrit.ovirt
Moti Asayag has posted comments on this change.
Change subject: engine: Refactor statements with ternary operators
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9186
To unsubscri
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Refactor statements with ternary operators
..
engine: Refactor statements with ternary operators
Re-format complex statements with ternary operato
Sharad Mishra has posted comments on this change.
Change subject: engine: Refactor statements with ternary operators
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9186
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:Fix NPE when import VM with clone
..
core:Fix NPE when import VM with clone
The following patch should fix an NPE which occurs when importing a
clon
Maor Lipchuk has posted comments on this change.
Change subject: core:Fix NPE when import VM with clone
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9176
To unsubscribe, visit h
Federico Simoncelli has posted comments on this change.
Change subject: [wip] core: move the storage domain V3 to DC 3.2
..
Patch Set 1:
WIP. It's probably a good idea to seize the opportunity and unify the logic in
one place.
Daniel Erez has posted comments on this change.
Change subject: core:Fix NPE when import VM with clone
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9176
To unsubscribe, visit http://gerri
Federico Simoncelli has uploaded a new change for review.
Change subject: [wip] core: move the storage domain V3 to DC 3.2
..
[wip] core: move the storage domain V3 to DC 3.2
Change-Id: Ia0f25ffe4ed85fad249f57d36c763059d17b0537
Yair Zaslavsky has posted comments on this change.
Change subject: core: Improve of IrsBrokerCommand
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9187
To unsubscribe, visit http://gerrit.
Arik Hadas has posted comments on this change.
Change subject: engine: re-run mechanism improvements
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9184
To unsubscribe, visit http://gerrit.ovirt.org/settings
Moti Asayag has posted comments on this change.
Change subject: webadmin: Messages text fixes
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9095
To unsubscribe, visit http://gerrit.ovirt.o
Moti Asayag has posted comments on this change.
Change subject: webadmin: Messages text fixes
..
Patch Set 3: (2 inline comments)
minor comments regarding the commit message
Yair Zaslavsky has posted comments on this change.
Change subject: core: Make connection timeout configurable
..
Patch Set 8: (1 inline comment)
File
backend/manager/modules
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: Setup Network- default boot protocol wasn't none.
..
webadmin: Setup Network- default boot protocol wasn't none.
https://bugzilla.redhat.com/875724
Wh
Muli Salem has posted comments on this change.
Change subject: engine: Fail Import Vm on MAC Address (#872100)
..
Patch Set 3: (3 inline comments)
File
backend/manager/modul
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix run VM with locked disk msg
..
Patch Set 7: (1 inline comment)
1. See minor format comment inline.
2. Although it is not that related to ,run VM functi
Itamar Heim has posted comments on this change.
Change subject: restapi: if filter: header is set, use query instead of search
(#869334)
..
Patch Set 2: (1 inline comment)
F
Shahar Havivi has posted comments on this change.
Change subject: webadmin: layout: fix layout in new storage domain - iscsi
username
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9185
To unsubscribe, visi
Liron Aravot has posted comments on this change.
Change subject: core: Quota refactor - parameters
..
Patch Set 14: (1 inline comment)
File
backend/manager/modules/bll/src/m
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Added version dependency for webadmin-portal package
..
packaging: Added version dependency for webadmin-portal package
Change-Id: I5876c46e
Juan Hernandez has posted comments on this change.
Change subject: packaging: Added version dependency for webadmin-portal package
..
Patch Set 2: Verified; Looks good to me, approved
Merging based on previous acks and verifica
Mike Kolesnik has posted comments on this change.
Change subject: engine: Fail Import Vm on MAC Address (#872100)
..
Patch Set 3: (3 inline comments)
File
backend/manager/mo
Juan Hernandez has posted comments on this change.
Change subject: packaging: Added version dependency for webadmin-portal package
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9127
To uns
Juan Hernandez has abandoned this change.
Change subject: packaging: Functions to configure for maintenance
..
Patch Set 3: Abandoned
Included in other patches.
--
To view, visit http://gerrit.ovirt.org/8790
To unsubscribe, vi
Juan Hernandez has posted comments on this change.
Change subject: core: Make connection timeout configurable
..
Patch Set 8: Verified
I am copying the verified flag from previous patch set as there are only
cosmetic changes.
Juan Hernandez has abandoned this change.
Change subject: core: Make connection timeout configurable
..
Patch Set 1: Abandoned
Wrong branch.
--
To view, visit http://gerrit.ovirt.org/9190
To unsubscribe, visit http://gerrit.ov
Juan Hernandez has uploaded a new change for review.
Change subject: core: Make connection timeout configurable
..
core: Make connection timeout configurable
The timeout that we currently use to connect to hosts is by default ve
Juan Hernandez has posted comments on this change.
Change subject: core: Make connection timeout configurable
..
Patch Set 7: (4 inline comments)
File backend/manager/dbscrip
Liron Aravot has posted comments on this change.
Change subject: core: Quota refactor - parameters
..
Patch Set 14: (6 inline comments)
File
backend/manager/modules/bll/src/
Arik Hadas has posted comments on this change.
Change subject: engine: Remove redundant event on run vm command
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9189
To unsubscribe, visit http://gerrit.ovirt.o
Arik Hadas has uploaded a new change for review.
Change subject: engine: Remove redundant event on run vm command
..
engine: Remove redundant event on run vm command
Currently, when VdsUpdateRunTimeInfo detects a VM which is dow
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: rewrite bootstrap using the new vdsm-bootstrap
package
..
Patch Set 2:
Rebase.
--
To view, visit http://gerrit.ovirt.org/9175
To unsubscribe, visit h
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: remove VdsInstallerSSH::getServerKeyFingerprint()
..
Patch Set 2:
Use SSHDialog interface to acquire fingerprint.
--
To view, visit http://gerrit.ovir
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 2:
Add forgotten javadoc for SSHDialog + move ssh fingerprint resolve to get
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: host add: differentiate between authentication error
and other errors
..
Patch Set 2:
Rebase.
--
To view, visit http://gerrit.ovirt.org/9178
To unsub
Alon Bar-Lev has posted comments on this change.
Change subject: core: Event log - a method to bypass flow
..
Patch Set 3:
Rebase.
--
To view, visit http://gerrit.ovirt.org/9148
To unsubscribe, visit http://gerrit.ovirt.org/se
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: handle bootstrap messages using string member
..
Patch Set 2:
Rebase.
--
To view, visit http://gerrit.ovirt.org/9173
To unsubscribe, visit http://gerr
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: split the logic of ovirt-node upgrade out
..
Patch Set 2:
Rebase.
--
To view, visit http://gerrit.ovirt.org/9172
To unsubscribe, visit http://gerrit.o
Alon Bar-Lev has posted comments on this change.
Change subject: utils: ssh: move to member '_' convention
..
Patch Set 2:
Rebase.
--
To view, visit http://gerrit.ovirt.org/9171
To unsubscribe, visit http://gerrit.ovirt.org/se
Alon Bar-Lev has posted comments on this change.
Change subject: utils: ssh: optimize progress streams
..
Patch Set 2:
Rebase.
--
To view, visit http://gerrit.ovirt.org/9170
To unsubscribe, visit http://gerrit.ovirt.org/settin
Alon Bar-Lev has posted comments on this change.
Change subject: utils: ssh: fixup activity detection
..
Patch Set 2:
Rebase.
--
To view, visit http://gerrit.ovirt.org/9169
To unsubscribe, visit http://gerrit.ovirt.org/setting
Alon Bar-Lev has posted comments on this change.
Change subject: utils: ssh: don't add ssh command to exception
..
Patch Set 2:
Rebase.
--
To view, visit http://gerrit.ovirt.org/9168
To unsubscribe, visit http://gerrit.ovirt.o
Alon Bar-Lev has posted comments on this change.
Change subject: utils: tests: do not use default key alias
..
Patch Set 2:
Rebase.
--
To view, visit http://gerrit.ovirt.org/9167
To unsubscribe, visit http://gerrit.ovirt.org/s
Alon Bar-Lev has posted comments on this change.
Change subject: utils: tests: tar: cleanup main() entry point
..
Patch Set 2:
Rebase.
--
To view, visit http://gerrit.ovirt.org/9166
To unsubscribe, visit http://gerrit.ovirt.or
Alon Bar-Lev has posted comments on this change.
Change subject: utils: tar: throw an exception if base does not exist
..
Patch Set 2:
Rebase.
--
To view, visit http://gerrit.ovirt.org/9165
To unsubscribe, visit http://gerrit.
Alon Bar-Lev has posted comments on this change.
Change subject: utils: tar: support long file names within tar
..
Patch Set 2:
Rebase.
--
To view, visit http://gerrit.ovirt.org/9164
To unsubscribe, visit http://gerrit.ovirt.o
Alon Bar-Lev has posted comments on this change.
Change subject: pki: accept subject name for certificate
..
Patch Set 2:
Rebase.
--
To view, visit http://gerrit.ovirt.org/9163
To unsubscribe, visit http://gerrit.ovirt.org/set
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: allow distinguish error from non error messages
..
Patch Set 2:
Rebase.
--
To view, visit http://gerrit.ovirt.org/9161
To unsubscribe, visit http://ge
Vered Volansky has posted comments on this change.
Change subject: core: Fix run VM with locked disk msg
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/8693
To unsubscribe, visit http://gerrit.ovirt.org/sett
Alon Bar-Lev has posted comments on this change.
Change subject: registration: fix null pointer exception
..
Patch Set 2:
Rebase.
--
To view, visit http://gerrit.ovirt.org/9158
To unsubscribe, visit http://gerrit.ovirt.org/set
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: do not check connectivity nor unique id when
VdsInstall=false
..
Patch Set 2:
Rebase.
--
To view, visit http://gerrit.ovirt.org/9157
To unsubscribe,
Juan Hernandez has posted comments on this change.
Change subject: packaging: Minor bugfix release 3.1.0-4
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9147
To unsubscribe, visit http://gerrit.ovirt.org/se
Juan Hernandez has posted comments on this change.
Change subject: packaging: Updated allinone plugin for new security mode
..
Patch Set 1: Verified
Verified that with 3.1.0 plus this patch the all in one plugin works correctly
Michael Kublin has posted comments on this change.
Change subject: core: Improve of IrsBrokerCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9187
To unsubscribe, visit http://gerrit.ovirt.org/settings
Michael Kublin has uploaded a new change for review.
Change subject: core: Improve of IrsBrokerCommand
..
core: Improve of IrsBrokerCommand
The following patch is removing getIsValidWithoutSpmStart() method and performs
some
cl
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2822/
Build Number: 2822
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,441
-
Changes Since La
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: remove VdsInstallerSSH::getServerKeyFingerprint()
..
Patch Set 1:
Please wait for the next patch.
--
To view, visit http://gerrit.ovirt.org/9160
To un
Shireesh Anjal has posted comments on this change.
Change subject: bootstrap: remove VdsInstallerSSH::getServerKeyFingerprint()
..
Patch Set 1:
I disagree. It looks like 25+ lines of code to me.
It looks like the compromise yo
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: remove VdsInstallerSSH::getServerKeyFingerprint()
..
Patch Set 1:
OK, I move this patch up the series, and use SSHDialog class. It is not makes
it muc
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: errors during preview of diskless snapshots
..
core: errors during preview of diskless snapshots
1. When creating a diskless snapshot, then adding
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: compensate on wrong object leads to NPE
..
core: compensate on wrong object leads to NPE
Compensation during unlock vm is performed on the vm itsel
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: NPEs in AddVmTemplate end methods after engine crash
..
core: NPEs in AddVmTemplate end methods after engine crash
AddVmTemplateCommand endSuccesfu
Maor Lipchuk has posted comments on this change.
Change subject: core: compensate on wrong object leads to NPE
..
Patch Set 8: Looks good to me, approved
Please remember to send a patch for the fix that you mentioned in patch 7
Liron Aravot has posted comments on this change.
Change subject: core: compensate on wrong object leads to NPE
..
Patch Set 7: (1 inline comment)
File
backend/manager/module
Maor Lipchuk has posted comments on this change.
Change subject: core: NPEs in AddVmTemplate end methods after engine crash
..
Patch Set 5: Looks good to me, approved
Please consider to change it in the future to more elegant s
Maor Lipchuk has posted comments on this change.
Change subject: core: errors during preview of diskless snapshots
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9128
To unsubscribe, visit
Liron Aravot has posted comments on this change.
Change subject: core: NPEs in AddVmTemplate end methods after engine crash
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/9106
To unsubscribe, visit http://ge
Liron Aravot has posted comments on this change.
Change subject: core: errors during preview of diskless snapshots
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/9128
To unsubscribe, visit http://gerrit.ovir
Arik Hadas has posted comments on this change.
Change subject: webadmin & engine: Add validation for snapshot description
length
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/9011
To unsubscribe, visit htt
Vered Volansky has posted comments on this change.
Change subject: core: NPEs in AddVmTemplate end methods after engine crash
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt
Einav Cohen has posted comments on this change.
Change subject: webadmin: Messages text fixes
..
Patch Set 3:
Moti - can you please review the engine-core changes?
--
To view, visit http://gerrit.ovirt.org/9095
To unsubscribe,
Liron Aravot has posted comments on this change.
Change subject: core: compensate on wrong object leads to NPE
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/9074
To unsubscribe, visit http://gerrit.ovirt.or
Arik Hadas has posted comments on this change.
Change subject: engine: Refactoring nested-if statements
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9186
To unsubscribe, visit http://gerrit.ovirt.org/setti
Einav Cohen has posted comments on this change.
Change subject: webadmin: reformat remove disk messages
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9101
To unsubscri
Arik Hadas has uploaded a new change for review.
Change subject: engine: Refactoring nested-if statements
..
engine: Refactoring nested-if statements
Changed nested-if statements in MigrateVmCommand#getAuditLogTypeValue
and RunV
Shahar Havivi has posted comments on this change.
Change subject: webadmin: layout: fix layout in new storage domain - iscsi
username
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9185
To unsubscribe, visi
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2821/
Build Number: 2821
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 3,440
-
Changes Since
Shahar Havivi has uploaded a new change for review.
Change subject: webadmin: layout: fix layout in new storage domain - iscsi
username
..
webadmin: layout: fix layout in new storage domain - iscsi username
Change-Id: I881bb2bf
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: split the logic of ovirt-node upgrade out
..
Patch Set 1: (1 inline comment)
File
backend/manager
Alon Bar-Lev has posted comments on this change.
Change subject: pki: cleanup the ca interface
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/utils/src/main
Allon Mureinik has posted comments on this change.
Change subject: bootstrap: do not get unique id at canDoAction
..
Patch Set 1: (1 inline comment)
File
backend/manager/mod
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: split the logic of ovirt-node upgrade out
..
Patch Set 1: (1 inline comment)
File
backend/manager
1 - 100 of 162 matches
Mail list logo
