Mike Kolesnik has posted comments on this change.
Change subject: engine: Fail Import Vm on MAC Address (#872100)
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java
Line 78: public void addWithExistingMacAddress() {
Line 79: VmNetworkInterface iface = createNewInterface();
Line 80:
Line 81: try {
Line 82: runAddAndVerify(iface, false, times(1));
Also, there should be a fail if this command succeeded. (Since you expected it
to fail)
Line 83: } catch (VdcBLLException e) {
Line 84: assertEquals(VdcBllErrors.MAC_ADDRESS_IS_IN_USE,
e.getErrorCode());
Line 85: } catch (Exception e) {
Line 86: fail(String.format("Expected to catch %s, but caught %s
instead.",
Line 183: verify(vmNetworkStatisticsDAO).save(iface.getStatistics());
Line 184: }
Line 185:
Line 186: /**
Line 187: * Verify that {@link
VmInterfaceManager#removeAllInterfacesAndMacs} or
No need to update the javadoc here, since it didn't change..
Line 188: * {@link VmInterfaceManager#removeAllInterfacesAndMacsFromList}
delegated correctly to {@link MacPoolManager} &
Line 189: * DAOs.
Line 190: *
Line 191: * @param iface
Line 197
Line 198
Line 199
Line 200
Line 201
You can remove freeMacVerification parameter since it is always sent constant
now..
--
To view, visit http://gerrit.ovirt.org/9144
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68d37ed183adb4adf8abf8b11332f6c822f8c4c0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
