Alon Bar-Lev has posted comments on this change.

Change subject: bootstrap: split the logic of ovirt-node upgrade out
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
Line 83:         ) {
Line 84:             try {
Line 85:                 T parameters = getParameters();
Line 86:                 _vdsInstaller = new OVirtUpgrader(getVds(), 
parameters.getoVirtIsoFile());
Line 87:                 
Backend.getInstance().getResourceManager().RunVdsCommand(
This code is obsolete by next patches, and taken as-is from bellow, so not 
worth to fix as at end the set vds id is done within the bootstrap class.
Line 88:                     VDSCommandType.SetVdsStatus,
Line 89:                     new SetVdsStatusVDSCommandParameters(
Line 90:                         getVdsId(),
Line 91:                         VDSStatus.Installing


--
To view, visit http://gerrit.ovirt.org/9172
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22dee8f1238de198abba72f576fb4ee82c513f34
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to