Maor Lipchuk has posted comments on this change.
Change subject: core: Fix run VM with locked disk msg
......................................................................
Patch Set 7: (1 inline comment)
1. See minor format comment inline.
2. Although it is not that related to ,run VM functionality, there might be a
related bug when moving a disk, since it is using the same message but I didn't
see a set for disk aliases there.
3. I would wormly suggest to use one message instead of two.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 339: // the stateless VM in the EndAction part.
Line 340: VmHandler.updateDisksFromDb(getVm());
Line 341: } else {
Line 342: if (areDisksLocked(vdcReturnValue))
Line 343: {
Please move the bracket to be part of the condition line
Line 344: throw new
VdcBLLException(VdcBllErrors.IRS_IMAGE_STATUS_ILLEGAL);
Line 345: }
Line 346: getReturnValue().setFault(vdcReturnValue.getFault());
Line 347: log.errorFormat("RunVmAsStateless - {0} - failed to
create snapshots", getVm().getvm_name());
--
To view, visit http://gerrit.ovirt.org/8693
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c56d9d2926eaf34b4a279c8d61a8cb166524da9
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
