Allon Mureinik has posted comments on this change.

Change subject: bootstrap: do not get unique id at canDoAction
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java
Line 495:     }
Line 496: 
Line 497:     public static List<VDS> getVdssByUniqueId(final Guid vdsId, 
String uniqueIdToCheck) {
Line 498:         List<VDS> list = 
DbFacade.getInstance().getVdsDao().getAllWithUniqueId(uniqueIdToCheck);
Line 499:         return LinqUtils.filter(list, new Predicate<VDS>() {
As I said, it's probably not wroth the effort in rewritting it now
Line 500:             @Override
Line 501:             public boolean eval(VDS vds) {
Line 502:                 return !vds.getId().equals(vdsId);
Line 503:             }


--
To view, visit http://gerrit.ovirt.org/9159
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0263dbae34aaa02c126c5ed1dc52a84f4f5e77f8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to