Moti Asayag has posted comments on this change. Change subject: engine: Add Vds Port Validation 65535 (#871328) ......................................................................
Patch Set 2: (3 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java Line 30: public static final int HOST_PM_TYPE_SIZE = 20; Line 31: public static final int HOST_MIN_SPM_PRIORITY = -1; Line 32: public static final int HOST_MAX_SPM_PRIORITY = 10; Line 33: public static final int SSH_KEY_FINGERPRINT_SIZE = 128; Line 34: public static final int HOST_MIN_LEGAL_PORT = 1; you may omit the "HOST_ prefix since the range of ports is a constant (not related to host specifically). Line 35: public static final int HOST_MAX_LEGAL_PORT = 65535; Line 36: Line 37: // Network Interface (vm_interface) Line 38: public static final int NETWORK_NAME_SIZE = 50; .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java Line 77: private String hostname; Line 78: Line 79: @Min(value = BusinessEntitiesDefinitions.HOST_MIN_LEGAL_PORT, message = "VALIDATION.VDS.PORT.RANGE") Line 80: @Max(value = BusinessEntitiesDefinitions.HOST_MAX_LEGAL_PORT, message = "VALIDATION.VDS.PORT.RANGE") Line 81: @Column(name = "port") why not use @Size instead ? @Size( min = BusinessEntitiesDefinitions.HOST_MIN_LEGAL_PORT, max = BusinessEntitiesDefinitions.HOST_MAX_LEGAL_PORT, message = "VALIDATION.VDS.PORT.RANGE" ) Line 82: private int port; Line 83: Line 84: @Column(name = "vds_group_id") Line 85: @Type(type = "guid") .................................................... File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties Line 592: VALIDATION.VM.NETWORK.MAC.ADDRESS.NOT_NULL=MAC address is required. Line 593: VALIDATION.VM.NETWORK.NAME.NOT_NULL=Interface name is required. Line 594: VALIDATION.CONNECTIVITY.TIMEOUT.INVALID=Connectivity timeout is not valid. Timeout must be between 1 and 120. Line 595: VALIDATION.REPETITIVE.IP.IN.VDS=Invalid list of interfaces, two or more network interfaces have the same IP. Line 596: VALIDATION.VDS.PORT.RANGE=The Port number must be between 1 and 65535. maybe s/The/A "A port number ..." Line 597: ERROR_CANNOT_FIND_ISO_IMAGE_PATH=Invalid ISO image path Line 598: ERROR_CANNOT_FIND_FLOPPY_IMAGE_PATH=Invalid Floppy image path Line 599: VDS_ADD_STORAGE_SERVER_STATUS_MUST_BE_UP=Cannot add storage server connection when Host status is not up Line 600: USER_FAILED_TO_AUTHENTICATE_WRONG_USERNAME_OR_PASSWORD=The user name or password is incorrect. -- To view, visit http://gerrit.ovirt.org/9149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e2cf636c32fc74f88f1c47ab609a616e2e5860f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msa...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Muli Salem <msa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
