[Engine-patches] Change in ovirt-engine[master]: core: WIP: Update Enums to support GLusterFS.

2012-10-31 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: WIP: Update Enums to support GLusterFS. .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8961 To

[Engine-patches] Change in ovirt-engine[master]: api: WIP: Add Gluster FS to api StorageType.

2012-10-31 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: api: WIP: Add Gluster FS to api StorageType. .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8966 To u

[Engine-patches] Change in ovirt-engine[master]: engine: Removing unused code

2012-10-31 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine: Removing unused code .. Patch Set 1: Looks good to me, but someone else must approve I'll let Gilad have a glance as well, Either than that, looks good.

[Engine-patches] Change in ovirt-engine[master]: tools : rhevm-manage-domains location option no longer valid...

2012-10-31 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools : rhevm-manage-domains location option no longer valid (#871085) .. Patch Set 1: (1 inline comment) Hi Ravi, Can you please also check what happens with

[Engine-patches] Change in ovirt-engine[master]: tools: rhevm-manage-domains -passwordFile=

2012-10-31 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools: rhevm-manage-domains -passwordFile= throws exception (#870052) .. Patch Set 1: (1 inline comment) Please see comments for commit message. The code looks

[Engine-patches] Change in ovirt-engine[master]: api: WIP: Add Gluster FS to api StorageType.

2012-10-31 Thread Sharad Mishra
Sharad Mishra has uploaded a new change for review. Change subject: api: WIP: Add Gluster FS to api StorageType. .. api: WIP: Add Gluster FS to api StorageType. Updated StorageType to include GlusterFs. Change-Id: I89517787469d

[Engine-patches] Change in ovirt-engine[master]: tools: rhevm-manage-domains -passwordFile=

2012-10-31 Thread rnori
Ravi Nori has posted comments on this change. Change subject: tools: rhevm-manage-domains -passwordFile= throws exception (#870052) .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8965 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: tools: rhevm-manage-domains -passwordFile=

2012-10-31 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: tools: rhevm-manage-domains -passwordFile= throws exception (#870052) .. tools: rhevm-manage-domains -passwordFile= throws exception (#870052) When running rhevm-

[Engine-patches] Change in ovirt-engine[master]: core: WIP: Add capability check fot Gluster FS.

2012-10-31 Thread Sharad Mishra
Sharad Mishra has uploaded a new change for review. Change subject: core: WIP: Add capability check fot Gluster FS. .. core: WIP: Add capability check fot Gluster FS. Enable it for ovirt 3.2 Change-Id: I4228cc8777d0da5e199ac316

[Engine-patches] Change in ovirt-engine[master]: tools : rhevm-manage-domains location option no longer valid...

2012-10-31 Thread rnori
Ravi Nori has posted comments on this change. Change subject: tools : rhevm-manage-domains location option no longer valid (#871085) .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8963 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: tools : rhevm-manage-domains location option no longer valid...

2012-10-31 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: tools : rhevm-manage-domains location option no longer valid (#871085) .. tools : rhevm-manage-domains location option no longer valid (#871085) In command line pa

[Engine-patches] Change in ovirt-engine[master]: core: WIP: Add GlusterFS support to AsyncDataProvider

2012-10-31 Thread Sharad Mishra
Sharad Mishra has uploaded a new change for review. Change subject: core: WIP: Add GlusterFS support to AsyncDataProvider .. core: WIP: Add GlusterFS support to AsyncDataProvider Added Gluster to AsyncDataProvider.java Change-I

[Engine-patches] Change in ovirt-engine[master]: core: WIP: Update Enums to support GLusterFS.

2012-10-31 Thread Sharad Mishra
Sharad Mishra has uploaded a new change for review. Change subject: core: WIP: Update Enums to support GLusterFS. .. core: WIP: Update Enums to support GLusterFS. GLUSTER FS was added to Enums Change-Id: Id22ab1020bdf4c13d5ca30

[Engine-patches] Change in ovirt-engine[master]: core(WIP): Add VDSM missing error messages.

2012-10-31 Thread abaron
Ayal Baron has posted comments on this change. Change subject: core(WIP): Add VDSM missing error messages. .. Patch Set 1: (1 inline comment) File backend/manager/modules/da

[Engine-patches] Change in ovirt-iso-uploader[master]: tools: Better API error handling

2012-10-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: tools: Better API error handling .. Patch Set 2: Please separate style change patches from logic change patches. -- To view, visit http://gerrit.ovirt.org/8954 T

[Engine-patches] Change in ovirt-engine[master]: core: Don't use PostgreSQL UUID extension

2012-10-31 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Don't use PostgreSQL UUID extension .. Patch Set 2: Looks good to me, but someone else must approve Great, giving +1 for now , waiting for Alex/Ohad to give +

[Engine-patches] Change in ovirt-engine[master]: engine: Removing unused code

2012-10-31 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Removing unused code .. Patch Set 1: (1 inline comment) Commit Message Line 3: AuthorDate: 2012-10-

[Engine-patches] Change in ovirt-engine[master]: core: Don't use PostgreSQL UUID extension

2012-10-31 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Don't use PostgreSQL UUID extension .. Patch Set 2: Verified Replace the existing uuid_generate_v1 function instead of creating a new one with a differen

[Engine-patches] Change in ovirt-engine[master]: engine: Removing unused code

2012-10-31 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: engine: Removing unused code .. Patch Set 1: (1 inline comment) Commit Message Line 3: AuthorDate: 2012-10-3

[Engine-patches] Change in ovirt-engine[master]: : Enhanced loging of HA VM failure recovery

2012-10-31 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: : Enhanced loging of HA VM failure recovery .. Patch Set 2: (1 inline comment) File backend/manager/modules

[Engine-patches] Change in ovirt-engine[master]: core(WIP): Add VDSM missing error messages.

2012-10-31 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: core(WIP): Add VDSM missing error messages. .. core(WIP): Add VDSM missing error messages. Add VDSM messages to the engine, which weren't part of the engine mess

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 2810 - Fixed!

2012-10-31 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2810/ Build Number: 2810 Build Status: Fixed Triggered By: Started by upstream project "ovirt_engine" build number 3,375 - Changes Since La

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 2809 - Still Unstable!

2012-10-31 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2809/ Build Number: 2809 Build Status: Still Unstable Triggered By: Started by upstream project "ovirt_engine" build number 3,374 - Changes

[Engine-patches] Change in ovirt-engine[master]: core: Don't use PosrgreSQL UUID extension

2012-10-31 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Don't use PosrgreSQL UUID extension .. Patch Set 1: This is problematic 1) We should not change upgrade scripts, upgrade scripts has there md5 recorded in t

[Engine-patches] Change in ovirt-engine[master]: webadmin: Integer should be compare with ==

2012-10-31 Thread alkaplan
Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Integer should be compare with == .. webadmin: Integer should be compare with == Integer should be compate with equals and not == Change-Id:

[Engine-patches] Change in ovirt-engine[master]: webadmin: Integer should be compare with ==

2012-10-31 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: Integer should be compare with == .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/8956 To unsubs

[Engine-patches] Change in ovirt-engine[master]: webadmin: Integer should be compare with ==

2012-10-31 Thread masayag
Moti Asayag has posted comments on this change. Change subject: webadmin: Integer should be compare with == .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8956 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: webadmin: Integer should be compare with ==

2012-10-31 Thread alkaplan
Alona Kaplan has uploaded a new change for review. Change subject: webadmin: Integer should be compare with == .. webadmin: Integer should be compare with == Integer should be compate with equals and not == Change-Id: I6931034

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 2808 - Still Unstable!

2012-10-31 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2808/ Build Number: 2808 Build Status: Still Unstable Triggered By: Started by upstream project "ovirt_engine" build number 3,373 - Changes

[Engine-patches] Change in ovirt-engine[master]: core: better log when LUN in problem state

2012-10-31 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: better log when LUN in problem state .. core: better log when LUN in problem state Change-Id: Ief846e766101e0060cb415e6226632c72f7b80f8 Bug-Url: ht

[Engine-patches] Change in ovirt-engine[master]: core: better log when LUN in problem state

2012-10-31 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: better log when LUN in problem state .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8880 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: core: Don't use PosrgreSQL UUID extension

2012-10-31 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Don't use PosrgreSQL UUID extension .. Patch Set 1: Verified Verified building a new set of packages, installing them, registering a Fedora 17 host, addi

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 2807 - Still Unstable!

2012-10-31 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2807/ Build Number: 2807 Build Status: Still Unstable Triggered By: Started by upstream project "ovirt_engine" build number 3,372 - Changes

[Engine-patches] Change in ovirt-engine[master]: core: better log when LUN in problem state

2012-10-31 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: better log when LUN in problem state .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8880 To uns

[Engine-patches] Change in ovirt-engine[master]: core: Don't use PosrgreSQL UUID extension

2012-10-31 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Don't use PosrgreSQL UUID extension .. core: Don't use PosrgreSQL UUID extension Replace the calls to the uuid_generate_v1 function with a custom functio

[Engine-patches] Change in ovirt-engine[master]: core: better log when LUN in problem state

2012-10-31 Thread gpadgett
Greg Padgett has posted comments on this change. Change subject: core: better log when LUN in problem state .. Patch Set 3: Verified Thanks Maor, changed as suggested -- To view, visit http://gerrit.ovirt.org/8880 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: engine: Get Volume Advanced Details Query

2012-10-31 Thread dgopal
Dhandapani Gopal has posted comments on this change. Change subject: engine: Get Volume Advanced Details Query .. Patch Set 23: (1 inline comment) Incorporated review comments. .

[Engine-patches] Change in ovirt-engine[master]: webadmin: Layout - Custom Properties select-box not fit for ...

2012-10-31 Thread shavivi
Shahar Havivi has submitted this change and it was merged. Change subject: webadmin: Layout - Custom Properties select-box not fit for JP Locale .. webadmin: Layout - Custom Properties select-box not fit for JP Locale Change-I

[Engine-patches] Change in ovirt-engine[master]: webadmin: Layout - Custom Properties select-box not fit for ...

2012-10-31 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: webadmin: Layout - Custom Properties select-box not fit for JP Locale .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: core: Fix LoadBalancing messeges

2012-10-31 Thread dfediuck
Doron Fediuck has submitted this change and it was merged. Change subject: core: Fix LoadBalancing messeges .. core: Fix LoadBalancing messeges When VM migration was triggered by a Load Balancing algorithm only the "migration f

[Engine-patches] Change in ovirt-engine[master]: core: Fix LoadBalancing messeges

2012-10-31 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: Fix LoadBalancing messeges .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8951 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: core: Fix LoadBalancing messeges

2012-10-31 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: Fix LoadBalancing messeges .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8951 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core: Fix LoadBalancing messeges

2012-10-31 Thread omasad
ofri masad has posted comments on this change. Change subject: core: Fix LoadBalancing messeges .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8951 To unsubscribe, visit http://gerrit.ovirt.org/settings Ger

[Engine-patches] Change in ovirt-engine[master]: core: better log when LUN in problem state

2012-10-31 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: better log when LUN in problem state .. Patch Set 2: (2 inline comments) File backend/manager/modules/

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 2806 - Unstable!

2012-10-31 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2806/ Build Number: 2806 Build Status: Unstable Triggered By: Started by upstream project "ovirt_engine" build number 3,371 - Changes Since

[Engine-patches] Change in ovirt-engine[master]: engine: Get Volume Advanced Details Query

2012-10-31 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: Get Volume Advanced Details Query .. Patch Set 23: Looks good to me, but someone else must approve (1 inline comment) .

[Engine-patches] Change in ovirt-engine[master]: core: better log when LUN in problem state

2012-10-31 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: better log when LUN in problem state .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8880 To uns

[Engine-patches] Change in ovirt-engine[master]: core: better log when LUN in problem state

2012-10-31 Thread gpadgett
Greg Padgett has posted comments on this change. Change subject: core: better log when LUN in problem state .. Patch Set 2: Verified Rebased, re-verified -- To view, visit http://gerrit.ovirt.org/8880 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: webadmin: Layout - Custom Properties select-box not fit for ...

2012-10-31 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Layout - Custom Properties select-box not fit for JP Locale .. Patch Set 2: Verified; Looks good to me, approved verified -- To view, visit http://ge

[Engine-patches] Change in ovirt-iso-uploader[master]: tools: Better API error handling

2012-10-31 Thread kroberts
Keith Robertson has uploaded a new change for review. Change subject: tools: Better API error handling .. tools: Better API error handling Print the actual exception string when attempting to create an instance of the API and fi

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 6)

2012-10-31 Thread alkaplan
Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Network as Main Tab- (Phase 6) .. webadmin: Network as Main Tab- (Phase 6) - Cluster sub tab uses new query - GetVdsGroupsAndNetworksByNetworkI

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 5)

2012-10-31 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: Network as Main Tab- (Phase 5) .. Patch Set 6: rebased -- To view, visit http://gerrit.ovirt.org/8831 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 3)

2012-10-31 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: Network as Main Tab- (Phase 3) .. Patch Set 7: rebased -- To view, visit http://gerrit.ovirt.org/8623 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 6)

2012-10-31 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: Network as Main Tab- (Phase 6) .. Patch Set 9: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/8905 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 5)

2012-10-31 Thread alkaplan
Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Network as Main Tab- (Phase 5) .. webadmin: Network as Main Tab- (Phase 5) - Main tab - Role- adding custom tooltip. - Cluster sub tab- adding

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 5)

2012-10-31 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: Network as Main Tab- (Phase 5) .. Patch Set 6: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/8831 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 4)

2012-10-31 Thread alkaplan
Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Network as Main Tab- (Phase 4) .. webadmin: Network as Main Tab- (Phase 4) - Update the search syntax in CommonModel. - Change the main tab sea

[Engine-patches] Change in ovirt-engine[master]: webadmin: add Network as main tab (phase 1)

2012-10-31 Thread alkaplan
Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: add Network as main tab (phase 1) .. webadmin: add Network as main tab (phase 1) https://bugzilla.redhat.com/858742 - Adding the networks to t

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 2)

2012-10-31 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: Network as Main Tab- (Phase 2) .. Patch Set 10: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/8562 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 4)

2012-10-31 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: Network as Main Tab- (Phase 4) .. Patch Set 7: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/8741 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 3)

2012-10-31 Thread alkaplan
Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Network as Main Tab- (Phase 3) .. webadmin: Network as Main Tab- (Phase 3) Add to Network->Host subtab radio button that will show either- 1.Al

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 3)

2012-10-31 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: Network as Main Tab- (Phase 3) .. Patch Set 7: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/8623 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 2)

2012-10-31 Thread alkaplan
Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Network as Main Tab- (Phase 2) .. webadmin: Network as Main Tab- (Phase 2) Add, edit, remove network commandd for dc, cluster and network tab h

[Engine-patches] Change in ovirt-engine[master]: webadmin: add Network as main tab (phase 1)

2012-10-31 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: add Network as main tab (phase 1) .. Patch Set 11: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/8454 To unsub

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add checkbox to override NFS mount options

2012-10-31 Thread gpadgett
Greg Padgett has posted comments on this change. Change subject: webadmin: Add checkbox to override NFS mount options .. Patch Set 10: Rebased, verified -- To view, visit http://gerrit.ovirt.org/8798 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: core, webadmin: Use NFS v3 as default

2012-10-31 Thread gpadgett
Greg Padgett has posted comments on this change. Change subject: core, webadmin: Use NFS v3 as default .. Patch Set 14: Rebased, verified -- To view, visit http://gerrit.ovirt.org/8242 To unsubscribe, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: core, restapi: Convert NFS version to enum

2012-10-31 Thread gpadgett
Greg Padgett has posted comments on this change. Change subject: core, restapi: Convert NFS version to enum .. Patch Set 10: Rebased, verified -- To view, visit http://gerrit.ovirt.org/8797 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add checkbox to override NFS mount options

2012-10-31 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: Add checkbox to override NFS mount options .. webadmin: Add checkbox to override NFS mount options With the change to make nfs v3 the default,

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add checkbox to override NFS mount options

2012-10-31 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: webadmin: Add checkbox to override NFS mount options .. Patch Set 10: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8798 To unsub

[Engine-patches] Change in ovirt-engine[master]: core, webadmin: Use NFS v3 as default

2012-10-31 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core, webadmin: Use NFS v3 as default .. Patch Set 14: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8242 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: core, webadmin: Use NFS v3 as default

2012-10-31 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core, webadmin: Use NFS v3 as default .. core, webadmin: Use NFS v3 as default Change NFS version to v3 as default in UI, and add 'auto' param support to

[Engine-patches] Change in ovirt-engine[master]: core, restapi: Convert NFS version to enum

2012-10-31 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core, restapi: Convert NFS version to enum .. core, restapi: Convert NFS version to enum In order to support optional advanced nfs options, the "auto" ve

[Engine-patches] Change in ovirt-engine[master]: core, restapi: Convert NFS version to enum

2012-10-31 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core, restapi: Convert NFS version to enum .. Patch Set 10: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8797 To unsubscribe, vi

[Engine-patches] Change in ovirt-log-collector[master]: tools: Get pg conf data from .pgpass (BZ732852)

2012-10-31 Thread kroberts
Keith Robertson has posted comments on this change. Change subject: tools: Get pg conf data from .pgpass (BZ732852) .. Patch Set 2: The LC calls SoS report to dump the PG DB which, by extension, does call pg_dump. SoS shouldn

[Engine-patches] Change in ovirt-engine[master]: core: Don't try to modify template0

2012-10-31 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Don't try to modify template0 .. Patch Set 3: Fails; Do not submit While this patch works fine for local database installation, it doesn't work for remot

[Engine-patches] Change in ovirt-engine[master]: packaging: Updated interaction with user on async tasks

2012-10-31 Thread alourie
Alex Lourie has posted comments on this change. Change subject: packaging: Updated interaction with user on async tasks .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/8952 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: core, restapi: Convert NFS version to enum

2012-10-31 Thread gpadgett
Greg Padgett has posted comments on this change. Change subject: core, restapi: Convert NFS version to enum .. Patch Set 9: Maor, > p.s. quick question. Does VDSM knows how to handle two different types of NFS > protocol_versi

[Engine-patches] Change in ovirt-dwh[master]: history: added localization values for enum translator table

2012-10-31 Thread emesika
Eli Mesika has posted comments on this change. Change subject: history: added localization values for enum translator table .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8634 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: engine: Added missed vdsm errors

2012-10-31 Thread masayag
Moti Asayag has submitted this change and it was merged. Change subject: engine: Added missed vdsm errors .. engine: Added missed vdsm errors - vdsm error 4149 and 4154 are added. - Gluster Vdsm errors are sorted based on t

[Engine-patches] Change in ovirt-engine[master]: engine: Added missed vdsm errors

2012-10-31 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Added missed vdsm errors .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8953 To unsubscribe, visit http://gerrit.ovirt.org/settings Ge

[Engine-patches] Change in ovirt-engine[master]: core, webadmin: Use NFS v3 as default

2012-10-31 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core, webadmin: Use NFS v3 as default .. Patch Set 13: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8242 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: core, restapi: Convert NFS version to enum

2012-10-31 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core, restapi: Convert NFS version to enum .. Patch Set 9: Looks good to me, approved ack for the engine part (I assume Rest and GUI are also acked) p.s. quick qu

[Engine-patches] Change in ovirt-engine[master]: engine: Added missed vdsm errors

2012-10-31 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Added missed vdsm errors .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8953 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: engine: Added missed vdsm errors

2012-10-31 Thread sesubram
Selvasundaram has uploaded a new change for review. Change subject: engine: Added missed vdsm errors .. engine: Added missed vdsm errors - vdsm error 4149 and 4154 are added. - Gluster Vdsm errors are sorted based on the err

[Engine-patches] Change in ovirt-engine[master]: core: Fix run VM with locked disk msg

2012-10-31 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: core: Fix run VM with locked disk msg .. Patch Set 5: Will submit another patch in the future, applying changes according to comments. -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[master]: core: Fix run VM with locked disk msg

2012-10-31 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: core: Fix run VM with locked disk msg .. Patch Set 5: (2 inline comments) File backend/manager/modules/bll

[Engine-patches] Change in ovirt-engine[master]: core: WIP: prevent simultaneous reconstructs on the same poo...

2012-10-31 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: core: WIP: prevent simultaneous reconstructs on the same pool .. Patch Set 7: (2 inline comments) File bac

[Engine-patches] Change in ovirt-engine[master]: engine: Get Volume Advanced Details Query

2012-10-31 Thread dgopal
Dhandapani Gopal has posted comments on this change. Change subject: engine: Get Volume Advanced Details Query .. Patch Set 22: (1 inline comment) Incorporated review comment. ..

[Engine-patches] Change in ovirt-engine[master]: packaging: Updated initial interaction with user on async ta...

2012-10-31 Thread alourie
Alex Lourie has uploaded a new change for review. Change subject: packaging: Updated initial interaction with user on async tasks .. packaging: Updated initial interaction with user on async tasks The previous try/finally clause

[Engine-patches] Change in ovirt-engine[master]: webadmin: add Network as main tab (phase 1)

2012-10-31 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: add Network as main tab (phase 1) .. Patch Set 10: Verified; Looks good to me, approved looks very good, please merge it and fix the issues in a separa

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 2)

2012-10-31 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Network as Main Tab- (Phase 2) .. Patch Set 9: Verified; Looks good to me, approved looks very good, please merge it and fix the issues in a separate c

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 3)

2012-10-31 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Network as Main Tab- (Phase 3) .. Patch Set 6: Verified; Looks good to me, approved looks very good, please merge it and fix the issues in a separate c

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 4)

2012-10-31 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Network as Main Tab- (Phase 4) .. Patch Set 6: Verified; Looks good to me, approved looks very good, please merge it and fix the issues in a separate c

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 5)

2012-10-31 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Network as Main Tab- (Phase 5) .. Patch Set 5: Verified; Looks good to me, approved looks very good, please merge it and fix the issues in a separate c

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 6)

2012-10-31 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Network as Main Tab- (Phase 6) .. Patch Set 8: Verified; Looks good to me, approved (*) please refer to Moti's comments (*) please support re-sizable c

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 6)

2012-10-31 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: Network as Main Tab- (Phase 6) .. Patch Set 7: (1 inline comment) File frontend/webadmin/modules/u

[Engine-patches] Change in ovirt-engine[master]: core: Don't try to modify template0

2012-10-31 Thread alourie
Alex Lourie has posted comments on this change. Change subject: core: Don't try to modify template0 .. Patch Set 3: No score -- To view, visit http://gerrit.ovirt.org/8926 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: core: Alert for deprecated NFS mount options in vdsm.conf

2012-10-31 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Alert for deprecated NFS mount options in vdsm.conf .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: Fix LoadBalancing messeges

2012-10-31 Thread omasad
ofri masad has uploaded a new change for review. Change subject: core: Fix LoadBalancing messeges .. core: Fix LoadBalancing messeges When VM migration was triggered by a Load Balancing algorithm only the "migration finished" me

[Engine-patches] Change in ovirt-engine[master]: webadmin: Network as Main Tab- (Phase 6)

2012-10-31 Thread masayag
Moti Asayag has posted comments on this change. Change subject: webadmin: Network as Main Tab- (Phase 6) .. Patch Set 7: (1 inline comment) File frontend/webadmin/modules/ui

  1   2   >