Maor Lipchuk has posted comments on this change.
Change subject: core: better log when LUN in problem state
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
Line 140:
Line 141: // Get translated error by error code ,if no translation
found (should not happened) ,
Line 142: // will set the error code instead.
Line 143: String translatedError = getTranslatedStorageError(errorCode);
Line 144: logable.AddCustomValue("ErrorCode", translatedError);
ErrorCode as a key name, might be misleading.
If you already fixing the message, perhaps changing the key name to
ErrorMessage/ TranslatedError might be much clearer.
Line 145: AuditLogDirector.log(logable,
AuditLogType.STORAGE_DOMAIN_ERROR);
Line 146: return connectionField;
Line 147: }
Line 148:
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 515: UPDATE_TAGS_VM_DEFAULT_DISPLAY_TYPE=Vm ${VmName} tag default display
type was updated
Line 516: UPDATE_TAGS_VM_DEFAULT_DISPLAY_TYPE_FAILED=Failed to update Vm
${VmName} tag default display type
Line 517: CONNECT_STORAGE_SERVERS_FAILED=Failed to connect Host ${VdsName} to
Storage Servers
Line 518: CONNECT_STORAGE_POOL_FAILED=Failed to connect Host ${VdsName} to
Storage Pool ${StoragePoolName}
Line 519: STORAGE_DOMAIN_ERROR=The error message for connection ${Connection}
returned by VDSM was: ${ErrorCode}
same as previous comment
ErrorCode as a key name, might be misleading.
If you already fixing the message, perhaps changing the key name to
ErrorMessage/ TranslatedError might be much clearer.
Line 520: VDS_LOW_MEM=Available memory of host ${HostName} [${AvailableMemory}
MB] is under defined threshold [${Threshold} MB].
Line 521: IMPORTEXPORT_FAILED_TO_IMPORT_VM=Failed to read VM
'${ImportedVmName}' OVF, it may be corrupted
Line 522: IMPORTEXPORT_FAILED_TO_IMPORT_TEMPLATE=Failed to read Template
'${Template}' OVF, it may be corrupted
Line 523: CANNOT_HIBERNATE_RUNNING_VMS_AFTER_CLUSTER_CPU_UPGRADE=Hibernation of
VMs after CPU upgrade of Cluster ${VdsGroup} is not supported. Please stop and
restart those VMs in case you wish to hibernate them
--
To view, visit http://gerrit.ovirt.org/8880
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief846e766101e0060cb415e6226632c72f7b80f8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
