Sharad Mishra has posted comments on this change.
Change subject: <engine>: Enhanced loging of HA VM failure recovery
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
Line 306: event.setVmId(vmId);
Line 307:
Line 308: // Alert that the virtual machine failed:
Line 309: AuditLogDirector.log(event, AuditLogType.HA_VM_FAILED);
Line 310: log.infoFormat("Restart of the Highly Available VM was
initiated due to failure. VM Name:{0}, VM Id:{1}",
Can we improve the message by saying "Failed to start Highly Available VM.
Attempting to restart. VM Name: {0}, VM Id:{1}", event.getVmName(), vmId);
Line 311: event.getVmName(), vmId);
Line 312:
Line 313: // Try to start it again:
Line 314: final VdcReturnValueBase result =
Backend.getInstance().runInternalAction(VdcActionType.RunVm,
--
To view, visit http://gerrit.ovirt.org/8923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea83a09b824dcd391cd42b030fccc52ebc82c436
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <nslom...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslom...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
