Keith Robertson has posted comments on this change. Change subject: tools: Get pg conf data from .pgpass (BZ732852) ......................................................................
Patch Set 2: The LC calls SoS report to dump the PG DB which, by extension, does call pg_dump. SoS shouldn't be in the business of making any assumptions about environment variables or the location of files like .pgpass. As a consequence, SoS expects theses important PG variables to be passed in as command line options. Hence, the LC must collect them and pass them as such. -- To view, visit http://gerrit.ovirt.org/8927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4eff0378e8515e5a399cb6700bc46fec698431ad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Keith Robertson <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Keith Robertson <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
