Moti Asayag has posted comments on this change.

Change subject: webadmin: Network as Main Tab- (Phase 6)
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java
Line 172:     private void UpdateActionAvailability()
Line 173:     {
Line 174:         List<PairQueryable<VdsNetworkInterface, VDS>> selectedItems = 
getSelectedItems() != null ? getSelectedItems() : new ArrayList();
Line 175: 
Line 176:         Version v31 = new Version(3, 1);
can you use Version.v3_1 instead ?
Line 177:         
getSetupNetworksCommand().setIsExecutionAllowed(selectedItems.size() == 1 && 
selectedItems.get(0).getSecond().getvds_group_compatibility_version().compareTo(v31)
 < 0);
Line 178:     }
Line 179: 
Line 180:     @Override


--
To view, visit http://gerrit.ovirt.org/8905
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe5a15afaf4a3c5edb9fce432c8b490e7a15eb76
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to