Maor Lipchuk has uploaded a new change for review.

Change subject: core(WIP): Add VDSM missing error messages.
......................................................................

core(WIP): Add VDSM missing error messages.

Add VDSM messages to the engine, which weren't part of the engine messages
support for VDSM.
When engine will get those error messages from VDSM it will not start
fail over or reconstruct.

Change-Id: Id8395c75bbba1f66d08bcd9c21fdeacc7f5e6d4f
Signed-off-by: Maor Lipchuk <mlipc...@redhat.com>
---
M 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java
3 files changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/58/8958/1

diff --git 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
index 425bb0b..be51c3f 100644
--- 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
+++ 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
@@ -226,6 +226,8 @@
     iSCSIDiscoveryError(475),
     ISCSI_LOGIN_AUTH_ERROR(476),
     ProblemWhileTryingToMountTarget(477),
+    StorageServerConnectionRefIdAlreadyInUse(478),
+    StorageServerConnectionRefIdDoesNotExist(479),
     VolumeGroupActionError(500),
     VolumeGroupPermissionsError(501),
     VolumeGroupCreateError(502),
@@ -293,6 +295,9 @@
     DomainAlreadyLocked(657),
     DomainLockDoesNotExist(658),
     CannotRetrieveSpmStatus(659),
+    ReleaseLockFailure(660),
+    AcquireHostIdFailure(661),
+    ReleaseHostIdFailure(662),
     HostIdMismatch(700),
     MetaDataGeneralError(749),
     MetaDataKeyError(750),
diff --git 
a/backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties 
b/backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
index 3ec0cb4..b2d45e3 100644
--- 
a/backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
+++ 
b/backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
@@ -141,6 +141,8 @@
 iSCSILoginError=Failed to login to iSCSI node
 ISCSI_LOGIN_AUTH_ERROR=Failed to login to iSCSI node due to authorization 
failure
 ProblemWhileTryingToMountTarget=Problem while trying to mount target
+StorageServerConnectionRefIdAlreadyInUse=Connection Reference ID is already in 
use
+StorageServerConnectionRefIdDoesNotExist=Connection Reference ID was not in 
the registered with this VDSM
 iSCSISetupError=Failed to setup iSCSI subsystem
 IsoCannotBeMasterDomain=ISO domain cannot be a master storage domain
 IsSpm=Operatino not allowed while SPM is active
@@ -235,6 +237,9 @@
 DomainAlreadyLocked=Cannot acquire lock, resource marked as locked
 DomainLockDoesNotExist=Cannot release lock, resource not found
 CannotRetrieveSpmStatus=Cannot retrieve SPM status, master domain probably 
unavailable
+ReleaseLockFailure=Cannot release lock
+AcquireHostIdFailure=Cannot acquire host id
+ReleaseHostIdFailure=Cannot release host id
 FileStorageDomainStaleNFSHandle=Stale NFS handle on underlying NFS server
 InvalidJob=Job is invalid
 ReachedMaxNumberOfHostsInDC=The maximum number of Hosts allowed in the Data 
Center has been reached
diff --git 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java
 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java
index 74e9497..a45f16e 100644
--- 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java
+++ 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java
@@ -141,6 +141,9 @@
         case PartitionedPhysDev:
         case DomainAlreadyLocked:
         case DomainLockDoesNotExist:
+        case ReleaseLockFailure:
+        case AcquireHostIdFailure:
+        case ReleaseHostIdFailure:
         case MetaDataKeyError:
         case MetaDataSealIsBroken:
         case MetaDataValidationError:
@@ -157,6 +160,8 @@
         case iSCSILogoutError:
         case iSCSIDiscoveryError:
         case ISCSI_LOGIN_AUTH_ERROR:
+        case StorageServerConnectionRefIdAlreadyInUse:
+        case StorageServerConnectionRefIdDoesNotExist:
         case PoolUpgradeInProgress:
         case MixedSDVersionError:
         case NoSpaceLeftOnDomain:


--
To view, visit http://gerrit.ovirt.org/8958
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8395c75bbba1f66d08bcd9c21fdeacc7f5e6d4f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to