Greg Padgett has posted comments on this change.
Change subject: webadmin, core: Use NFS v3 as default
..
Patch Set 2: Verified
This patch set cleans up the code in ConnectStorageServerVDSCommand by
combining some helper metho
Vered Volansky has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
..
Patch Set 12: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7956
To u
Daniel Paikov has posted comments on this change.
Change subject: Don't add the cdrom device if iso_path is empty
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/8092
To unsubscribe, visit http://gerrit.ovirt
Doron Fediuck has posted comments on this change.
Change subject: core: QuotaManager Test - test 5,6
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8465
To unsubscribe, visit http://gerrit.
Doron Fediuck has posted comments on this change.
Change subject: core: QuotaManager Test - test 2,3,4
..
Patch Set 2:
It would be nice to have a comment on each test saying what it actually tests.
--
To view, visit http://ger
Daniel Paikov has posted comments on this change.
Change subject: Don't add the cdrom device if iso_path is empty
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/8092
To unsubscribe, visit http://gerrit.ovirt
Doron Fediuck has posted comments on this change.
Change subject: core: QuotaManager Test - test 1
..
Patch Set 4: (2 inline comments)
File
backend/manager/modules/bll/src/t
ofri masad has posted comments on this change.
Change subject: core: QuotaManager Test - test 5,6
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/8465
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
ofri masad has posted comments on this change.
Change subject: core: QuotaManager Test - test 2,3,4
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/8464
To unsubscribe, visit http://gerrit.ovirt.org/settings
ofri masad has posted comments on this change.
Change subject: core: Fix quota calculation for specific storage quota
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8451
To unsubscribe, visit http://gerrit.o
ofri masad has posted comments on this change.
Change subject: core: QuotaManager Test - test 1
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/8439
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
ofri masad has posted comments on this change.
Change subject: core : QuotaMnager Test - basic structure
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/8422
To unsubscribe, visit http://gerrit.ovirt.org/sett
Doron Fediuck has posted comments on this change.
Change subject: core : QuotaMnager Test - basic structure
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8422
To unsubscribe, visit http://
Michael Kublin has posted comments on this change.
Change subject: core: removed unused fqn from VdsSelector
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8404
To unsubscribe, visit http:/
Michael Kublin has posted comments on this change.
Change subject: core: minor cleanup in VdsSelector
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8441
To unsubscribe, visit http://gerrit
Shahar Havivi has posted comments on this change.
Change subject: webadmin: remove domain column from template main grid (#837025)
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/8229
To unsubscribe, visit ht
Shahar Havivi has posted comments on this change.
Change subject: webadmin: rename Allocation to Space Allocation in new VM
dialog (#837025)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/8228
To unsubscrib
Shahar Havivi has posted comments on this change.
Change subject: webadmin: reorder VMs column display (#837025)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/8227
To unsubscribe, visit http://gerrit.ovirt.
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix stuck progress in add Posix FS storage (#855244)
..
webadmin: Fix stuck progress in add Posix FS storage (#855244)
When adding new Posix FS ba
Tal Nisan has posted comments on this change.
Change subject: webadmin: Fix stuck progress in add Posix FS storage (#855244)
..
Patch Set 2: Verified; Looks good to me, approved
Rebase
--
To view, visit http://gerrit.ovirt.org
Tal Nisan has posted comments on this change.
Change subject: webadmin: Fix stuck progress in add Posix FS storage (#855244)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8471
To unsubscribe, visit http://g
Daniel Erez has posted comments on this change.
Change subject: webadmin: Fix stuck progress in add Posix FS storage (#855244)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8471
To unsubsc
Shahar Havivi has posted comments on this change.
Change subject: webadmin: remove domain column from template main grid (#837025)
..
Patch Set 2: (1 inline comment)
File
fr
Shahar Havivi has posted comments on this change.
Change subject: webadmin: rename Allocation to Format in new VM dialog (#837025)
..
Patch Set 1: (1 inline comment)
Commit M
Gal Hammer has posted comments on this change.
Change subject: replaced agent license to apache software license (asl) 2.0.
..
Patch Set 1: Verified
rpm build was successful.
--
To view, visit http://gerrit.ovirt.org/8469
To u
Daniel Erez has submitted this change and it was merged.
Change subject: core: Validate maximum number of hosts in DC.(#771699)
..
core: Validate maximum number of hosts in DC.(#771699)
http://bugzilla.redhat.com/show_bug.cgi?i
Daniel Erez has posted comments on this change.
Change subject: core: Validate maximum number of hosts in DC.(#771699)
..
Patch Set 16: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/8321
To unsubscribe, visit http
Daniel Erez has posted comments on this change.
Change subject: core: Validate maximum number of hosts in DC.(#771699)
..
Patch Set 16: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8321
To unsubscribe, v
Daniel Erez has posted comments on this change.
Change subject: core: Validate maximum number of hosts in DC.(#771699)
..
Patch Set 15: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8321
To unsubscribe, v
Liron Aravot has posted comments on this change.
Change subject: core: Validate maximum number of hosts in DC.(#771699)
..
Patch Set 15: Verified
--
To view, visit http://gerrit.ovirt.org/8321
To unsubscribe, visit http://gerri
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Improve UpdateVdsCommand
..
engine: Improve UpdateVdsCommand
Improvements:
1. Command should be Nontransactive
2. Some code clean ups
Change-I
Michael Kublin has posted comments on this change.
Change subject: engine: Improve UpdateVdsCommand
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/8468
To unsubscribe, vi
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Clean up of AddVdsVDSCommand
..
engine: Clean up of AddVdsVDSCommand
I have not any idea why that code was there and what was reason for it,
bu
Michael Kublin has submitted this change and it was merged.
Change subject: core: Clean up and improve ResourceManager
..
core: Clean up and improve ResourceManager
The following patch is a clean up of ResourceManager:
1. Remov
Michael Kublin has posted comments on this change.
Change subject: core: Clean up and improve ResourceManager
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/8466
To unsub
Michael Kublin has posted comments on this change.
Change subject: engine: Clean up of AddVdsVDSCommand
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/8467
To unsubscribe
Tal Nisan has uploaded a new change for review.
Change subject: webadmin: Fix stuck progress in add Posix FS storage (#855244)
..
webadmin: Fix stuck progress in add Posix FS storage (#855244)
When adding new Posix FS based stor
Yair Zaslavsky has posted comments on this change.
Change subject: core: Clean up and improve ResourceManager
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8466
To unsubscribe, visit http:
Allon Mureinik has posted comments on this change.
Change subject: core: [WIP]: Live Storage Migration commands
..
Patch Set 16:
new to this patchset:
1. some cleanup of old commented out code
2. rebasing
--
To view, visit htt
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Improve UpdateVdsCommand
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8468
To unsubscribe, visit http://gerrit.o
Hello Daniel Erez,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/8470
to review the following change.
Change subject: webadmin: adding live disk migration support
..
webadmin: adding live disk mig
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Clean up of AddVdsVDSCommand
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8467
To unsubscribe, visit http://gerr
Yair Zaslavsky has posted comments on this change.
Change subject: core: Clean up and improve ResourceManager
..
Patch Set 1:
Why did we have the sleep on the first place?
--
To view, visit http://gerrit.ovirt.org/8466
To unsu
Shahar Havivi has posted comments on this change.
Change subject: webadmin: reorder VMs column display (#837025)
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/mo
ofri masad has posted comments on this change.
Change subject: core: QuotaManager Test - test 1
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/src/test/
ofri masad has posted comments on this change.
Change subject: core : QuotaMnager Test - basic structure
..
Patch Set 6: (3 inline comments)
File
backend/manager/modules/bll
Michael Kublin has posted comments on this change.
Change subject: core: Clean up and improve ResourceManager
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8466
To unsubscribe, visit http://gerrit.ovirt.org
Liron Aravot has posted comments on this change.
Change subject: core: Validate maximum number of hosts in DC.(#771699)
..
Patch Set 13: Verified
rebased, verified
--
To view, visit http://gerrit.ovirt.org/8321
To unsubscribe,
Michael Kublin has posted comments on this change.
Change subject: engine: Clean up of AddVdsVDSCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8467
To unsubscribe, visit http://gerrit.ovirt.org/setti
Michael Kublin has posted comments on this change.
Change subject: engine: Improve UpdateVdsCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8468
To unsubscribe, visit http://gerrit.ovirt.org/settings
Michael Kublin has uploaded a new change for review.
Change subject: core: Clean up and improve ResourceManager
..
core: Clean up and improve ResourceManager
The following patch is a clean up of ResourceManager:
1. Removed unnee
Michael Kublin has uploaded a new change for review.
Change subject: engine: Improve UpdateVdsCommand
..
engine: Improve UpdateVdsCommand
Improvements:
1. Command should be Nontransactive
2. Some code clean ups
Change-Id: Icd05
Michael Kublin has uploaded a new change for review.
Change subject: engine: Clean up of AddVdsVDSCommand
..
engine: Clean up of AddVdsVDSCommand
I have not any idea why that code was there and what was reason for it,
but these
ofri masad has posted comments on this change.
Change subject: core: QuotaManager Test - test1
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/src/main/j
Mike Kolesnik has submitted this change and it was merged.
Change subject: restapi: Failed to attach vlan over bond
..
restapi: Failed to attach vlan over bond
When attempt to attach a vlan over bond, a NPE is thrown on SetupNe
Mike Kolesnik has posted comments on this change.
Change subject: restapi: Failed to attach vlan over bond
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no changes since ack by mpastern
NPE on BE side will be l
Shireesh Anjal has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
..
Patch Set 18:
Looks like my usage of the term "Gluster Configuration" has caused some
confusion. I don't mean the
Michael Pasternak has posted comments on this change.
Change subject: restapi: Failed to attach vlan over bond
..
Patch Set 2:
i suggest you defend NPE at BE rather relying on clients to pass all relevant
info
--
To view, vis
Michael Pasternak has posted comments on this change.
Change subject: restapi: Failed to attach vlan over bond
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8359
To unsubscribe, visit http
Daniel Erez has submitted this change and it was merged.
Change subject: core: removed disks:format from search(bug 859041)
..
core: removed disks:format from search(bug 859041)
There's no indication to COW or RAW in the UI. He
Daniel Erez has posted comments on this change.
Change subject: core: removed disks:format from search(bug 859041)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8430
To unsubscri
Daniel Erez has posted comments on this change.
Change subject: core: removed disks:format from search(bug 859041)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8430
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: QuotaManager Test - test1
..
Patch Set 3: I would prefer that you didn't submit this
I still have the same issue with this patch.
If you disagree with me
Allon Mureinik has posted comments on this change.
Change subject: core : QuotaMnager Test - basic structure
..
Patch Set 6: Looks good to me, but someone else must approve
(4 inline comments)
minor issues, see inline
...
ofri masad has posted comments on this change.
Change subject: core : QuotaMnager Test - basic structure
..
Patch Set 5: (2 inline comments)
File
backend/manager/modules/bll
ofri masad has uploaded a new change for review.
Change subject: core: QuotaManager Test - test 5,6
..
core: QuotaManager Test - test 5,6
RollbackQuota test
RemoveQuotaFromCache test
Change-Id: Ia371593a4233c6411798b57b8377f0ad
ofri masad has uploaded a new change for review.
Change subject: core: QuotaManager Test - test 2,3,4
..
core: QuotaManager Test - test 2,3,4
DecreaseStorageQuota test (currently ignored).
ValidateAndSetClusterQuota For VCPU te
Michael Kublin has submitted this change and it was merged.
Change subject: core: Remove Serializable class
..
core: Remove Serializable class
For some reason we had additional Serializable, I removed it.
Change-Id: I603cb6136
Yair Zaslavsky has posted comments on this change.
Change subject: core: Remove Serializable class
..
Patch Set 1: Looks good to me, approved
The reason is remains from the porting days (you have other leftovers - i.e
LinqUti
Michal Skrivanek has posted comments on this change.
Change subject: engine:cannot start stateless VM
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
.
Michael Kublin has posted comments on this change.
Change subject: core: Remove Serializable class
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8463
To unsubscribe, visit http://gerrit.ovirt.org/settings
Michael Kublin has uploaded a new change for review.
Change subject: core: Remove Serializable class
..
core: Remove Serializable class
For some reason we had additional Serializable, I removed it.
Change-Id: I603cb61368a9aa852
Allon Mureinik has posted comments on this change.
Change subject: core: [WIP]: Live Storage Migration commands
..
Patch Set 15:
changes in this patchset:
1. Fixed sending a blank UUID as a parameter for deleteImage
2. Removed
Kanagaraj M has posted comments on this change.
Change subject: engine: Execution messages for Gluster Volume Actions (#856102)
..
Patch Set 5: Verified
Rebased and Verified.
--
To view, visit http://gerrit.ovirt.org/7967
To u
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
..
Patch Set 18:
Regarding Allon's comment -
I agree here.
For some reason when I asked Shireesh at the beginning abou
Michael Kublin has submitted this change and it was merged.
Change subject: core: Performance improvements - replacing search by query
..
core: Performance improvements - replacing search by query
The following patch will repla
Michael Kublin has posted comments on this change.
Change subject: core: Performance improvements - replacing search by query
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.o
Daniel Erez has posted comments on this change.
Change subject: webadmin: allow import and clone
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8456
To unsubscribe, visit http://gerrit.ovir
Yair Zaslavsky has posted comments on this change.
Change subject: core: Performance improvements - replacing search by query
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8457
To unsubscr
Frank Kobzik has uploaded a new change for review.
Change subject: engine:cannot start stateless VM
..
engine:cannot start stateless VM
1. create a vm with disk
2. edit vm -> check the stateless checkbox
3. run the vm
The machi
Allon Mureinik has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
..
Patch Set 18:
Regarding involving the db in the tests:
I think that this is a bad practice.
bll /unit/ tests are s
Michael Kublin has posted comments on this change.
Change subject: core: Performance improvements - replacing search by query
..
Patch Set 1: (1 inline comment)
File
backend
Michael Kublin has submitted this change and it was merged.
Change subject: core: Changed illegal error msg to locked(#840304)
..
core: Changed illegal error msg to locked(#840304)
Replaced VM in illegal state error message to
Michael Kublin has posted comments on this change.
Change subject: core: Changed illegal error msg to locked(#840304)
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8078
To unsubs
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Adding Gluster Services Sub Tab to Cluster
..
webadmin: Adding Gluster Services Sub Tab to Cluster
A new sub tab named 'Services' is added to the Cluste
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Start Gluster Volume Profile command
..
Patch Set 8:
Execution message added in ExecutionMessages.properties.
--
To view, visit http://gerrit.ovirt.o
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: fixed dr20 filtering (#857683)
..
reports: fixed dr20 filtering (#857683)
The clause to filter only to highly available vm was commented
out by mi
Yaniv Dary has posted comments on this change.
Change subject: reports: fixed dr20 filtering (#857683)
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8459
To unsubscribe, visit ht
Yaniv Dary has uploaded a new change for review.
Change subject: reports: fixed dr20 filtering (#857683)
..
reports: fixed dr20 filtering (#857683)
The clause to filter only to highly available vm was commented
out by mistake.
Yair Zaslavsky has posted comments on this change.
Change subject: core: Performance improvements - replacing search by query
..
Patch Set 1: (1 inline comment)
Minor comment.
Besides that - looks good.
...
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: fixed date display on br16 (#863763)
..
reports: fixed date display on br16 (#863763)
Had missing field in date display that caused error.
Changed
Yaniv Dary has posted comments on this change.
Change subject: reports: fixed date display on br16 (#863763)
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8458
To unsubscribe, vi
Yaniv Dary has uploaded a new change for review.
Change subject: reports: fixed date display on br16 (#863763)
..
reports: fixed date display on br16 (#863763)
Had missing field in date display that caused error.
Changed query t
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Start Gluster Volume Profile command
..
Patch Set 7: Looks good to me, but someone else must approve
I would like derez to review UI part.
--
To view,
Vered Volansky has posted comments on this change.
Change subject: core: Changed illegal error msg to locked(#840304)
..
Patch Set 7:
Same patch, do not review.
--
To view, visit http://gerrit.ovirt.org/8078
To unsubscribe, vi
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Start Gluster Volume Profile command
..
Patch Set 5: (4 inline comments)
Incorporated review comments.
..
Michael Kublin has posted comments on this change.
Change subject: core: Performance improvements - replacing search by query
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8457
To unsubscribe, visit http://
Michael Kublin has uploaded a new change for review.
Change subject: core: Performance improvements - replacing search by query
..
core: Performance improvements - replacing search by query
The following patch will replace a sea
Gilad Chaplik has submitted this change and it was merged.
Change subject: engine: Allow empty quota in audit mode (#855633)
..
engine: Allow empty quota in audit mode (#855633)
https://bugzilla.redhat.com/855633
this is a kno
Gilad Chaplik has posted comments on this change.
Change subject: engine: Allow empty quota in audit mode (#855633)
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8059
To unsubscr
1 - 100 of 145 matches
Mail list logo
