[Engine-patches] Change in ovirt-engine[master]: engine: Improve UpdateVdsCommand

[mkublin]

Michael Kublin has uploaded a new change for review.

Change subject: engine: Improve UpdateVdsCommand
......................................................................

engine: Improve UpdateVdsCommand

Improvements:
1. Command should be Nontransactive
2. Some code clean ups

Change-Id: Icd0565b03266e5686d9b03e1c7d9f863da8952be
Signed-off-by: Michael Kublin <mkub...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java
1 file changed, 9 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/68/8468/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java
index b339119..3e966c2 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java
@@ -30,6 +30,7 @@
 import org.ovirt.engine.core.utils.transaction.TransactionMethod;
 import org.ovirt.engine.core.utils.transaction.TransactionSupport;
 
+@NonTransactiveCommandAttribute(forceCompensation = true)
 public class UpdateVdsCommand<T extends UpdateVdsActionParameters> extends 
VdsCommand<T> {
 
     private VDS _oldVds;
@@ -106,19 +107,18 @@
         } else {
             addCanDoActionMessage(VdcBllMessages.VDS_INVALID_SERVER_ID);
         }
-
-        if (!returnValue) {
-            addCanDoActionMessage(VdcBllMessages.VAR__ACTION__UPDATE);
-            addCanDoActionMessage(VdcBllMessages.VAR__TYPE__HOST);
-
-        }
-
         return returnValue;
     }
 
     @Override
+    protected void setActionMessageParameters() {
+        addCanDoActionMessage(VdcBllMessages.VAR__ACTION__UPDATE);
+        addCanDoActionMessage(VdcBllMessages.VAR__TYPE__HOST);
+    }
+
+    @Override
     protected void executeCommand() {
-        UpdateVdsData();
+        updateVdsData();
         if (NeedToUpdateVdsBroker()) {
             InitializeVds();
         }
@@ -186,7 +186,7 @@
         return getSucceeded() ? AuditLogType.USER_UPDATE_VDS : 
AuditLogType.USER_FAILED_UPDATE_VDS;
     }
 
-    private void UpdateVdsData() {
+    private void updateVdsData() {
         TransactionSupport.executeInNewTransaction(new 
TransactionMethod<Void>() {
             @Override
             public Void runInTransaction() {


--
To view, visit http://gerrit.ovirt.org/8468
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd0565b03266e5686d9b03e1c7d9f863da8952be
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches