Frank Kobzik has uploaded a new change for review. Change subject: engine:cannot start stateless VM ......................................................................
engine:cannot start stateless VM 1. create a vm with disk 2. edit vm -> check the stateless checkbox 3. run the vm The machine doesn't run with NPE. The problem was that the parent command and its parameters were set incorrectly in classes CreateAllSnapshotsFromVmCommand and RunVmCommand. Fixed by setting the right parent command/parameters. Change-Id: I6152049360dd0254b9bd07b2397abd9d7d56c5d8 Signed-off-by: Frantisek Kobzik <fkob...@redhat.com> bug-url: https://bugzilla.redhat.com/show_bug.cgi?id=863766 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 2 files changed, 7 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/61/8461/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java index cf8ac61..6c45fde 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java @@ -109,12 +109,14 @@ tempVar.setQuotaId(image.getQuotaId()); tempVar.setVmSnapshotId(newActiveSnapshotId); tempVar.setEntityId(getParameters().getEntityId()); - tempVar.setParentCommand(getParameters().getParentCommand() != VdcActionType.Unknown ? getParameters() - .getParentCommand() : VdcActionType.CreateAllSnapshotsFromVm); + VdcActionType parentCommand = getParameters().getParentCommand() != VdcActionType.Unknown ? getParameters() + .getParentCommand() : VdcActionType.CreateAllSnapshotsFromVm; + tempVar.setParentCommand(parentCommand); ImagesActionsParametersBase p = tempVar; - // ParametersCurrentUser = CurrentUser, getParameters().getImagesParameters().add(p); - p.setParentParameters(getParameters()); + + p.setParentParameters(getParametersForTask(parentCommand, getParameters())); + VdcReturnValueBase vdcReturnValue = Backend.getInstance().runInternalAction( VdcActionType.CreateSnapshot, p, diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java index cdda825..ae9a158 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java @@ -307,6 +307,7 @@ "stateless snapshot"); tempVar.setShouldBeLogged(false); tempVar.setParentCommand(getActionType()); + tempVar.setParentParameters(getParameters()); tempVar.setEntityId(getParameters().getEntityId()); CreateAllSnapshotsFromVmParameters p = tempVar; p.setSnapshotType(SnapshotType.STATELESS); -- To view, visit http://gerrit.ovirt.org/8461 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6152049360dd0254b9bd07b2397abd9d7d56c5d8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
