Allon Mureinik has posted comments on this change.
Change subject: core : QuotaMnager Test - basic structure
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
(4 inline comments)
minor issues, see inline
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java
Line 22: import java.util.List;
Line 23:
Line 24: import static org.junit.Assert.assertTrue;
Line 25: import static org.mockito.Matchers.any;
Line 26: import static org.mockito.Mockito.*;
why did you revert to * imports?
please use FQCNs.
Line 27:
Line 28: @RunWith(MockitoJUnitRunner.class)
Line 29: public class QuotaManagerTest {
Line 30:
Line 235: private List<QuotaVdsGroup> getQuotaVdsGroups(int vCpu, int
vCpuUsed, long mem, long memUsed) {
Line 236: ArrayList<QuotaVdsGroup> quotaVdsGroups = new
ArrayList<QuotaVdsGroup>();
Line 237: quotaVdsGroups.add(getQuotaVdsGroup(UNLIMITED_VCPU, 0,
UNLIMITED_MEM, 0));
Line 238: quotaVdsGroups.add(getQuotaVdsGroup(10, 2, 1000, 100));
Line 239: quotaVdsGroups.get(0).setVdsGroupId(new Guid());
s/new Guid/Guid.NewGuid/
Line 240: quotaVdsGroups.get(1).setVdsGroupId(new Guid());
Line 241: quotaVdsGroups.add(getQuotaVdsGroup(vCpu, vCpuUsed, mem,
memUsed));
Line 242: return quotaVdsGroups;
Line 243: }
Line 236: ArrayList<QuotaVdsGroup> quotaVdsGroups = new
ArrayList<QuotaVdsGroup>();
Line 237: quotaVdsGroups.add(getQuotaVdsGroup(UNLIMITED_VCPU, 0,
UNLIMITED_MEM, 0));
Line 238: quotaVdsGroups.add(getQuotaVdsGroup(10, 2, 1000, 100));
Line 239: quotaVdsGroups.get(0).setVdsGroupId(new Guid());
Line 240: quotaVdsGroups.get(1).setVdsGroupId(new Guid());
here too
Line 241: quotaVdsGroups.add(getQuotaVdsGroup(vCpu, vCpuUsed, mem,
memUsed));
Line 242: return quotaVdsGroups;
Line 243: }
Line 244:
....................................................
Commit Message
Line 3: AuthorDate: 2012-10-09 10:51:03 +0200
Line 4: Commit: Ofri Masad <[email protected]>
Line 5: CommitDate: 2012-10-10 12:42:06 +0200
Line 6:
Line 7: core : QuotaMnager Test - basic structure
same typo as before - please fix on your next rebsae.
Line 8:
Line 9: Basic structure for QuotaManagerTest
Line 10:
Line 11: Change-Id: Ie2ff7377f01fdc9de9edb5650cc796e24a8f65c3
--
To view, visit http://gerrit.ovirt.org/8422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2ff7377f01fdc9de9edb5650cc796e24a8f65c3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
