Tal Nisan has uploaded a new change for review. Change subject: webadmin: Fix stuck progress in add Posix FS storage (#855244) ......................................................................
webadmin: Fix stuck progress in add Posix FS storage (#855244) When adding new Posix FS based storage the dialog got stuck on progress indicator, this was caused due to an obsolete callback which was left after a cleanup and contained the cleanup logic Change-Id: I0512ee572069330fcc748e3d078702836dc9b446 Bug-Url: https://bugzilla.redhat.com/855244 Signed-off-by: Tal Nisan <tni...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 2 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/71/8471/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java index 6b7c33c..2157f27 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java @@ -1212,7 +1212,6 @@ StorageDomainManagementParameter parameter = new StorageDomainManagementParameter(storageDomain); parameter.setVdsId(host.getId()); parameters.add(parameter); - parameters.add(new StorageServerConnectionParametersBase(this.connection, host.getId())); IFrontendActionAsyncCallback callback1 = new IFrontendActionAsyncCallback() { @Override @@ -1231,17 +1230,9 @@ StorageListModel storageListModel = (StorageListModel) result.getState(); VdcReturnValueBase vdcReturnValueBase = result.getReturnValue(); storageListModel.storageId = (NGuid) vdcReturnValueBase.getActionReturnValue(); - } - }; - - IFrontendActionAsyncCallback callback3 = new IFrontendActionAsyncCallback() { - @Override - public void Executed(FrontendActionAsyncResult result) { - - StorageListModel storageListModel = (StorageListModel) result.getState(); - StorageModel storageModel = (StorageModel) storageListModel.getWindow(); // Attach storage to data center as necessary. + StorageModel storageModel = (StorageModel) storageListModel.getWindow(); storage_pool dataCenter = (storage_pool) storageModel.getDataCenter().getSelectedItem(); if (!dataCenter.getId().equals(StorageModel.UnassignedDataCenterId)) { storageListModel.AttachStorageToDataCenter((Guid) storageListModel.storageId, dataCenter.getId()); @@ -1264,7 +1255,7 @@ Frontend.RunMultipleActions(actionTypes, parameters, new ArrayList<IFrontendActionAsyncCallback>(Arrays.asList(new IFrontendActionAsyncCallback[] { - callback1, callback2, callback3})), + callback1, callback2 })), failureCallback, this); } -- To view, visit http://gerrit.ovirt.org/8471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0512ee572069330fcc748e3d078702836dc9b446 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
