Allon Mureinik has posted comments on this change. Change subject: engine: Refresh gluster data periodically ......................................................................
Patch Set 18: Regarding involving the db in the tests: I think that this is a bad practice. bll /unit/ tests are supposed to check bll's logic only, not the entire stack of db->dal->bll. Form what I can gather, the use of the DB is, in any event, limited to handling the Config object (which could be mocked away with MockConfigRule), and getting some BEs from the DB, which could just be replaced with new object creation. [I'll be happy yo assist on both issues, of course.] -- To view, visit http://gerrit.ovirt.org/7288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b61eb6e93105e46e2706eac1d94bc10717224c2 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
