Ayal Baron has posted comments on this change.
Change subject: core: removed disks:format from search(bug 859041)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8430
To
Ayal Baron has posted comments on this change.
Change subject: core,webadmin: Failure to reconnect authenticated iSCSI LUNs
..
Patch Set 2:
Please fix in vdsm.
--
To view, visit http://gerrit.ovirt.org/8344
To unsubscribe, vis
Selvasundaram has uploaded a new change for review.
Change subject: engine: Passwordless ssh status query
..
engine: Passwordless ssh status query
- Bll and VDS query command to fetch the passwordless ssh setup status
betw
ofri masad has posted comments on this change.
Change subject: core : QuotaMnager Test - basic structure
..
Patch Set 4: (10 inline comments)
File
backend/manager/modules/bl
Shireesh Anjal has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
..
Patch Set 17: (1 inline comment)
New patch-set to follow with suggested changes to ListUtils#getAddedElements()
..
Allon Mureinik has posted comments on this change.
Change subject: engine: upgrade.sh for upgrading multiple DBs
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8146
To
Allon Mureinik has posted comments on this change.
Change subject: core: QuotaManager Test - test1
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
IMO, this test is structured wrong.
You have nu
Allon Mureinik has posted comments on this change.
Change subject: core : QuotaMnager Test - basic structure
..
Patch Set 4: (2 inline comments)
File
backend/manager/modules
Allon Mureinik has posted comments on this change.
Change subject: core : QuotaMnager Test - basic structure
..
Patch Set 4: (9 inline comments)
some commends, see inline.
Also, I'm not sure i wouldn't squash this patch into t
Ayal Baron has posted comments on this change.
Change subject: core: prevent simultaneous reconstructs on the same
pool(#845838)
..
Patch Set 12: (1 inline comment)
File
ba
Ayal Baron has posted comments on this change.
Change subject: core: prevent simultaneous reconstructs on the same
pool(#845838)
..
Patch Set 12: (1 inline comment)
File
ba
Daniel Erez has posted comments on this change.
Change subject: webadmin: [SetupNetworks] bond is jumping on mouse hover
..
Patch Set 2: Looks good to me, approved
(1 inline comment)
...
Vered Volansky has posted comments on this change.
Change subject: core: Validate maximum number of hosts in DC.(#771699)
..
Patch Set 12: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Vered Volansky has posted comments on this change.
Change subject: core: ReconstructMasterDomainCommand-added methods for commands
execution
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit htt
Vered Volansky has posted comments on this change.
Change subject: core: Changed illegal error msg to locked(#840304)
..
Patch Set 6: Verified
There is no bug in the current patch that I know of. If you think otherwise
please
ofri masad has uploaded a new change for review.
Change subject: core: QuotaManager Test - test1
..
core: QuotaManager Test - test1
ValidateAndSetStorageQuota test.
Change-Id: I374769dfcc4bb99de2e578d4267fb03484d9c63f
Signed-of
Michael Kublin has submitted this change and it was merged.
Change subject: core: Fixing find bugs errors
..
core: Fixing find bugs errors
The following patch will fix a find bugs warning
1. Possible NullPointerException, by re
Michael Kublin has posted comments on this change.
Change subject: core: Fixing find bugs errors
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/8438
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
..
Patch Set 17: (1 inline comment)
File
backend/manager/modules
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixing find bugs errors
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8438
To unsubscribe, visit http://gerrit.ovir
Michael Kublin has posted comments on this change.
Change subject: core: Fixing find bugs errors
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8438
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Michael Kublin has uploaded a new change for review.
Change subject: core: Fixing find bugs errors
..
core: Fixing find bugs errors
The following patch will fix a find bugs warning
1. Possible NullPointerException, by removing u
Michael Kublin has submitted this change and it was merged.
Change subject: core: Fixing possible ConcurrentModificationException
..
core: Fixing possible ConcurrentModificationException
The following class is used all around t
Michael Kublin has posted comments on this change.
Change subject: core: Fixing possible ConcurrentModificationException
..
Patch Set 2: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/843
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: misc cleanups related to pgpass
..
Patch Set 1:
Alex, do you take care of this one?
--
To view, visit http://gerrit.ovirt.org/8348
To unsubscribe, vis
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: open up firewall rules for console and migration in
aio mode
..
packaging: open up firewall rules for console and migration in aio mode
The
Juan Hernandez has posted comments on this change.
Change subject: packaging: open up firewall rules for console and migration in
aio mode
..
Patch Set 5: Verified; Looks good to me, approved
Merging based on previous acks/ver
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
..
Patch Set 17:
Good catch regarding my comment on GlusterCoreUtil - still, I think these
methods can be applied in
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: clean up iptables rules
..
packaging: clean up iptables rules
RH-Firewall-1-INPUT was a symbol used in RHEL5, no need to keep it
around.
Fi
Juan Hernandez has posted comments on this change.
Change subject: packaging: clean up iptables rules
..
Patch Set 3: Verified; Looks good to me, approved
Merging based on previous acks/verification.
--
To view, visit http://g
Shireesh Anjal has posted comments on this change.
Change subject: engine: upgrade.sh for upgrading multiple DBs
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/8146
To unsubscribe, visit http://gerrit.ovirt.
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: cleanup _configIptables
..
packaging: cleanup _configIptables
1. use template file, do not search for comments.
2. remove code duplications.
Juan Hernandez has posted comments on this change.
Change subject: packaging: cleanup _configIptables
..
Patch Set 3: Verified; Looks good to me, approved
Merging based on previous acks/verification.
--
To view, visit http://g
Shireesh Anjal has posted comments on this change.
Change subject: engine: Moved generic methods from GlusterCoreUtil
..
Patch Set 2:
Michael, commons-lang is not permitted to be used in some projects e.g. common,
as it is sup
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixing possible ConcurrentModificationException
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8436
To uns
Juan Hernandez has posted comments on this change.
Change subject: packaging: cleanup _configIptables
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8373
To unsubscribe, visit http://gerrit
Juan Hernandez has posted comments on this change.
Change subject: packaging: open up firewall rules for console and migration in
aio mode
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/83
Juan Hernandez has posted comments on this change.
Change subject: packaging: clean up iptables rules
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8377
To unsubscribe, visit http://gerrit
Moran Goldboim has posted comments on this change.
Change subject: packaging: clean up iptables rules
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8377
To unsubscribe
Moran Goldboim has posted comments on this change.
Change subject: packaging: open up firewall rules for console and migration in
aio mode
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http:
Michael Kublin has posted comments on this change.
Change subject: core: validate that lun has a valid LunType
..
Patch Set 2:
you enforcing a rest usually sent all data about lun, even if a lun located in
DB.
So a rest flow w
Michael Kublin has posted comments on this change.
Change subject: core: removed unused fqn from VdsSelector
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/
Michael Kublin has posted comments on this change.
Change subject: core: log should be final in VdsSelector
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8403
To unsubscribe, visit http://
Michael Kublin has posted comments on this change.
Change subject: core: camel-case methods in VdsSelector
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8402
To unsubscribe, visit http://g
Michael Kublin has posted comments on this change.
Change subject: core: break down spaghetti-code in VdsSelector
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8401
To unsubscribe, visit h
Alona Kaplan has posted comments on this change.
Change subject: webadmin: "Fully configured" message for guide me dialogs
(#850439)
..
Patch Set 1: (5 inline comments)
File
Michael Kublin has posted comments on this change.
Change subject: core: VdsSelector cleanup
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8400
To unsubscribe, visit http://gerrit.ovirt.or
Michael Kublin has posted comments on this change.
Change subject: core: remove unused code from VdsSelector
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8399
To unsubscribe, visit http:/
Liron Aravot has posted comments on this change.
Change subject: core: validate that lun has a valid LunType
..
Patch Set 2:
mkublin, it depends - take look at
StorageDomainCommandBase.proceedLUNInDb
if the connection exist we
Michael Kublin has posted comments on this change.
Change subject: core: Changed illegal error msg to locked(#840304)
..
Patch Set 6: I would prefer that you didn't submit this
I don't understand a reason commit a code with a b
Mike Kolesnik has posted comments on this change.
Change subject: core: Query GetVdsGroupsByNetworkId (WIP)
..
Patch Set 1: (3 inline comments)
Please add DAO tests
File bac
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: [SetupNetworks] Cannot detach unsynced VLAN interface
from nic
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/83
Michael Kublin has posted comments on this change.
Change subject: core: validate that lun has a valid LunType
..
Patch Set 2:
Allon, lun disk is point on lun, lun can be in DB
--
To view, visit http://gerrit.ovirt.org/8437
To
Allon Mureinik has posted comments on this change.
Change subject: core: validate that lun has a valid LunType
..
Patch Set 2: (3 inline comments)
File
backend/manager/modul
Allon Mureinik has posted comments on this change.
Change subject: core: validate that lun has a valid LunType
..
Patch Set 2:
sorry, "mkublin", in the previous comment, of course.
--
To view, visit http://gerrit.ovirt.org/843
Allon Mureinik has posted comments on this change.
Change subject: core: validate that lun has a valid LunType
..
Patch Set 2:
mkunlin: the issue is creating a new LUN disk - it should not already be in the
db
(in fact, it fai
Michael Kublin has posted comments on this change.
Change subject: engine: Moved generic methods from GlusterCoreUtil
..
Patch Set 2:
You already have ObjectUtils at org.apache.commons.lang.ObjectUtils ?
--
To view, visit http
Michael Kublin has posted comments on this change.
Change subject: core: validate that lun has a valid LunType
..
Patch Set 2: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/8437
To unsubsc
Michael Kublin has posted comments on this change.
Change subject: core: validate that lun has a valid LunType
..
Patch Set 2:
I have question, why I need pass via Rest storage type, if I already pass lunId
which is points on
Tal Nisan has posted comments on this change.
Change subject: core: validate that lun has a valid LunType
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8437
To unsubscribe, visit http://ge
Liron Aravot has posted comments on this change.
Change subject: core: validate that lun has a valid LunType
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/8437
To unsubscribe, visit http://gerrit.ovirt.org/
Liron Aravot has uploaded a new change for review.
Change subject: core: validate that lun has valid LunType
..
core: validate that lun has valid LunType
adding lun disk through rest API could be done with no lun type which
led
Shireesh Anjal has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
..
Patch Set 16: (6 inline comments)
File
backend/manager/module
Michael Kublin has posted comments on this change.
Change subject: core: Fixing possible ConcurrentModificationException
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8436
To unsubscribe, visit http://gerri
Michael Kublin has uploaded a new change for review.
Change subject: core: Fixing possible ConcurrentModificationException
..
core: Fixing possible ConcurrentModificationException
The following class is used all around the code,
Alexey Chub has uploaded a new change for review.
Change subject: webadmin: "Fully configured" message for guide me dialogs
(#850439)
..
webadmin: "Fully configured" message for guide me dialogs (#850439)
http://bugzilla.redhat
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2645/
Build Number: 2645
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,211
-
Changes Since La
Shireesh Anjal has uploaded a new change for review.
Change subject: engine: Moved generic methods from GlusterCoreUtil
..
engine: Moved generic methods from GlusterCoreUtil
Generic methods like objectsEqual, listsEquel have bee
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2644/
Build Number: 2644
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 3,210
-
Changes Since
Michael Kublin has submitted this change and it was merged.
Change subject: core: Clean up of EnumUtils
..
core: Clean up of EnumUtils
Removed unused and unneeded methods.
Change-Id: I939be2b873812d00fe33b2d3a498f6f0a90e8ec1
S
Ori Liel has uploaded a new change for review.
Change subject: restapi: BZ861929 - Don't require template for clone-vm from
snapshot
..
restapi: BZ861929 - Don't require template for clone-vm from snapshot
Change-Id: I5e49482c2
Michael Kublin has posted comments on this change.
Change subject: core: ReconstructMasterDomain - refresh storage pool before
connect(#841525)
..
Patch Set 11: I would prefer that you didn't submit this
(1 inline comment)
..
Yair Zaslavsky has posted comments on this change.
Change subject: core: Clean up of EnumUtils
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8432
To unsubscribe, visit http://gerrit.ovirt.
Michael Kublin has posted comments on this change.
Change subject: core: Clean up of EnumUtils
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Michael Kublin has uploaded a new change for review.
Change subject: core: Clean up of EnumUtils
..
core: Clean up of EnumUtils
Removed unused and unneeded methods.
Change-Id: I939be2b873812d00fe33b2d3a498f6f0a90e8ec1
Signed-of
Michael Kublin has submitted this change and it was merged.
Change subject: core: Removing annotattion Singelton from GlusterUtils and
ClusterUtils
..
core: Removing annotattion Singelton from GlusterUtils and ClusterUtils
The
Michael Kublin has posted comments on this change.
Change subject: core: Removing annotattion Singelton from GlusterUtils and
ClusterUtils
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://
Yair Zaslavsky has posted comments on this change.
Change subject: core: Removing annotattion Singelton from GlusterUtils and
ClusterUtils
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/84
Vered Volansky has posted comments on this change.
Change subject: core: removed disks:format from search(bug 859041)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8430
To unsubscribe, visit http://gerrit.o
Vered Volansky has uploaded a new change for review.
Change subject: core: removed disks:format from search(bug 859041)
..
core: removed disks:format from search(bug 859041)
There's no indication to COW or RAW in the UI. Hence r
Michael Pasternak has uploaded a new change for review.
Change subject: restapi: Allow copying template disks to another storage domain
#851099
..
restapi: Allow copying template disks to another storage domain #851099
https://
Vered Volansky has posted comments on this change.
Change subject: core: Changed illegal error msg to locked(#840304)
..
Patch Set 5: Verified
(3 inline comments)
File
back
Michael Kublin has posted comments on this change.
Change subject: core: Reduce host connection timeout
..
Patch Set 2: No score
I am agree, I made mistake.
But, I am not sure that 2 seconds is good enough,I think that
defaut d
Daniel Paikov has posted comments on this change.
Change subject: core: ReconstructMasterDomain - refresh storage pool before
connect(#841525)
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/7137
To unsubsc
Roy Golan has submitted this change and it was merged.
Change subject: core: fix a utils method to detect compat level lower than 3.1
..
core: fix a utils method to detect compat level lower than 3.1
Change-Id: Ie9b8325bb1999af
Roy Golan has posted comments on this change.
Change subject: core: fix a utils method to detect compat level lower than 3.1
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8349
To
Roy Golan has posted comments on this change.
Change subject: core: fix a utils method to detect compat level lower than 3.1
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8349
To unsubscribe, visit http://g
Muli Salem has uploaded a new change for review.
Change subject: core: Query GetVdsGroupsByNetworkId (WIP)
..
core: Query GetVdsGroupsByNetworkId (WIP)
This patch adds the query above as part of the
Network Main Tab feature.
Ch
Juan Hernandez has posted comments on this change.
Change subject: core: Reduce host connection timeout
..
Patch Set 2:
Dan, I would appreciate your input.
--
To view, visit http://gerrit.ovirt.org/8410
To unsubscribe, visit h
Juan Hernandez has posted comments on this change.
Change subject: core: Reduce host connection timeout
..
Patch Set 2:
Michael, the operation timeout is not affected by the change, only the connect
timeout. This means that if
Eli Mesika has posted comments on this change.
Change subject: core: fix a utils method to detect compat level lower than 3.1
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8349
To unsubscr
Yair Zaslavsky has posted comments on this change.
Change subject: core: Removing annotattion Singelton from GlusterUtils and
ClusterUtils
..
Patch Set 1:
Good, but what about the initialization?
Do we want to assume this will
Michael Kublin has posted comments on this change.
Change subject: core: Removing annotattion Singelton from GlusterUtils and
ClusterUtils
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8425
To unsubscribe,
Michael Kublin has uploaded a new change for review.
Change subject: core: Removing annotattion Singelton from GlusterUtils and
ClusterUtils
..
core: Removing annotattion Singelton from GlusterUtils and ClusterUtils
The followi
Muli Salem has submitted this change and it was merged.
Change subject: core: Remove Redundant Char (#858719)
..
core: Remove Redundant Char (#858719)
See subject above.
Change-Id: If8686ffb1964f204f69da7fd03fe922554979120
Bug
Muli Salem has posted comments on this change.
Change subject: core: Remove Redundant Char (#858719)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8424
To unsubscribe, visit http
Muli Salem has posted comments on this change.
Change subject: core: Remove Redundant Char (#858719)
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8424
To unsubscribe, visit http
Michael Kublin has posted comments on this change.
Change subject: core: Reduce host connection timeout
..
Patch Set 2: I would prefer that you didn't submit this
180 sec was required by product and vdsm team, operation on stor
Yair Zaslavsky has posted comments on this change.
Change subject: core: Reduce host connection timeout
..
Patch Set 2:
Laszlo, good comment - i thought about this myself, but wasn't too sure if a
user will be interested in th
Mike Kolesnik has posted comments on this change.
Change subject: core: Remove Redundant Char (#858719)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8424
To unsubscribe, visit http://gerr
1 - 100 of 134 matches
Mail list logo
