Liron Aravot has posted comments on this change. Change subject: core: validate that lun has a valid LunType ......................................................................
Patch Set 2: mkublin, it depends - take look at StorageDomainCommandBase.proceedLUNInDb if the connection exist we can use it's stored storage type, otherwise we take it from the LUN. we can't know what will be the scenario and therefore it should be passed by REST. anyway, regarding this solution - it's being checked if it can be eliminated and be solved in REST side instead. -- To view, visit http://gerrit.ovirt.org/8437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I302b399fd93419fb1f621fd315b50d5971ae9c11 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
