Allon Mureinik has posted comments on this change. Change subject: core : QuotaMnager Test - basic structure ......................................................................
Patch Set 4: (2 inline comments) .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QuotaManagerTest.java Line 66: @Mock Line 67: private QuotaDAO quotaDAO; Line 68: Line 69: @Mock Line 70: private DbFacade dbFacade; Unless I'm missing something, this is redundent Line 71: Line 72: @Mock Line 73: private AuditLogDAO auditLogDAO; Line 74: Line 69: @Mock Line 70: private DbFacade dbFacade; Line 71: Line 72: @Mock Line 73: private AuditLogDAO auditLogDAO; this too Line 74: Line 75: private QuotaManager quotaManager = Mockito.spy(QuotaManager.getInstance()); Line 76: Line 77: private storage_pool storage_pool = new storage_pool(); -- To view, visit http://gerrit.ovirt.org/8422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2ff7377f01fdc9de9edb5650cc796e24a8f65c3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <oma...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: ofri masad <oma...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
