Michael Kublin has uploaded a new change for review.
Change subject: core: Fixing find bugs errors
......................................................................
core: Fixing find bugs errors
The following patch will fix a find bugs warning
1. Possible NullPointerException, by removing unneeded log
2. Not java method name
Change-Id: I61c73c2be5a0f24dcd7554ff41a04c6cf7754140
Signed-off-by: Michael Kublin <mkub...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
1 file changed, 2 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/38/8438/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
index b8c7bcb..8d8f985 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
@@ -165,7 +165,7 @@
protected void executeQueryCommand() {
try {
log.info("Running Command: RegisterVds");
- ExecuteRegisterVdsCommand();
+ executeRegisterVdsCommand();
} catch (RuntimeException ex) {
log.error("RegisterVdsQuery::ExecuteWithoutTransaction: An
exception has been thrown.", ex);
} finally {
@@ -173,7 +173,7 @@
}
}
- protected void ExecuteRegisterVdsCommand() {
+ protected void executeRegisterVdsCommand() {
synchronized (doubleRegistrationLock) {
// force to reload vdss by unique ID used later on
_vdssByUniqueId = null;
@@ -207,12 +207,6 @@
} else {
vdsGroupId = getParameters().getVdsGroupId();
}
-
- log.debugFormat(
- "RegisterVdsQuery::ExecuteCommand - found vds {0} with
existing Unique Id {1}. Will try to update existing vds",
- vdsByUniqueId.getId(),
- vdsByUniqueId.getUniqueId());
-
// TODO: always add in pending state, and if auto approve call
// approve command action after registration
RefObject<Boolean> isPending = new
RefObject<Boolean>(Boolean.FALSE);
--
To view, visit http://gerrit.ovirt.org/8438
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61c73c2be5a0f24dcd7554ff41a04c6cf7754140
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
