oVirt Jenkins CI Server has posted comments on this change.
Change subject: Change descriptions of LocalAdminPassword and AdminPassword
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/142/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine-manage-domain is missing details on error reports.
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/141/ : FA
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine-manage-domain is missing details on error reports.
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/140/ : AB
Yaniv Bronhaim has uploaded a new change for review.
Change subject: engine-manage-domain is missing details on error reports.
..
engine-manage-domain is missing details on error reports.
https://bugzilla.redhat.com/show_bug.cgi
Doron Fediuck has posted comments on this change.
Change subject: webadmin: merge the 2 SPM columns into 1 (#845320)
..
Patch Set 3: (1 inline comment)
Some minor indentations needs handling.
..
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: new VM: pin to host not used from template(#845570)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6935
To unsubs
Gilad Chaplik has posted comments on this change.
Change subject: userportal,webadmin: redesign vCPU editing (#809800)
..
Patch Set 6: Looks good to me, approved
acked, if RangeEntityModel is no longer in use - can you please r
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Irregular behavior of checkbox in QuotaPopupView ->
QuotaStorageTable (#846267)
..
webadmin: Irregular behavior of checkbox in QuotaPopupView
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Irregular behavior of checkbox in QuotaPopupView ->
QuotaStorageTable (#846267)
..
Patch Set 2: Verified; Looks good to me, approved
rebased & reviewe
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: merge the 2 SPM columns into 1 (#845320)
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/137/ : SUCCE
Oved Ourfali has posted comments on this change.
Change subject: core: Removing unused class
InternalGetAdUserByUserIdListCommand.
..
Patch Set 1: Do not submit
These are in use.
When the AdBrokerCommands are called, we take t
Oved Ourfali has posted comments on this change.
Change subject: core: Removed unused class InternalGetAdUserByUserIdCommand
..
Patch Set 1: Do not submit
These are in use.
When the AdBrokerCommands are called, we take the comm
Oved Ourfali has posted comments on this change.
Change subject: core: Removing InternalGetAdGroupByGroupIdCommand class.
..
Patch Set 1: Do not submit
These are in use.
When the AdBrokerCommands are called, we take the command
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: returning InternalAuthenticateUserCommand as it is used
..
core: returning InternalAuthenticateUserCommand as it is used
Previous ACK removed thi
Yair Zaslavsky has posted comments on this change.
Change subject: core: returning InternalAuthenticateUserCommand as it is used
..
Patch Set 1: Verified; Looks good to me, approved
Without this login with internal user will no
Oved Ourfali has uploaded a new change for review.
Change subject: core: returning InternalAuthenticateUserCommand as it is used
..
core: returning InternalAuthenticateUserCommand as it is used
Previous ACK removed this file, wh
Oved Ourfali has submitted this change and it was merged.
Change subject: core: InternalAuthenticateUserCommand is not used.
..
core: InternalAuthenticateUserCommand is not used.
Removing unused classes.
Change-Id: I84a16792c9
Oved Ourfali has posted comments on this change.
Change subject: core: InternalAuthenticateUserCommand is not used.
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7193
To unsubscr
Oved Ourfali has posted comments on this change.
Change subject: core: InternalAuthenticateUserCommand is not used.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7193
To unsubscribe, visit http://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: core: ReconstructMasterDomainCommand-added methods for commands
execution
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit htt
Oved Ourfali has posted comments on this change.
Change subject: core: InternalAuthenticateUserCommand is not used.
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7193
To unsubscribe, visit
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: ldap - no need to set default to AD.
..
core: ldap - no need to set default to AD.
LdapProviderType should come from constructor so there is no n
Yair Zaslavsky has posted comments on this change.
Change subject: core: ldap - no need to set default to AD.
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7188
To unsubscribe, v
Yair Zaslavsky has posted comments on this change.
Change subject: core: ldap - no need to set default to AD.
..
Patch Set 1: Verified; Looks good to me, approved
Thanks for the cleanup!
--
To view, visit http://gerrit.ovirt.o
Asaf Shakarchi has uploaded a new change for review.
Change subject: webadmin: VM subtab disks corrections (#846551)
..
webadmin: VM subtab disks corrections (#846551)
https://bugzilla.redhat.com/846551
- Fixed auto collapse of
Sharad Mishra has uploaded a new change for review.
Change subject: core: Removing unused class
InternalGetAdUserByUserIdListCommand.
..
core: Removing unused class InternalGetAdUserByUserIdListCommand.
This class is not used.
Sharad Mishra has uploaded a new change for review.
Change subject: core: Removed unused class InternalGetAdUserByUserIdCommand
..
core: Removed unused class InternalGetAdUserByUserIdCommand
This class is not used.
Change-Id: I
Sharad Mishra has uploaded a new change for review.
Change subject: core: Removing InternalGetAdGroupByGroupIdCommand class.
..
core: Removing InternalGetAdGroupByGroupIdCommand class.
This class is unused.
Change-Id: I2ffa6a69
Sharad Mishra has uploaded a new change for review.
Change subject: core: InternalAuthenticateUserCommand is not used.
..
core: InternalAuthenticateUserCommand is not used.
Removing unused classes.
Change-Id: I84a16792c99c5b545
Greg Padgett has uploaded a new change for review.
Change subject: core: Don't erroneously remove template->storage mappings
..
core: Don't erroneously remove template->storage mappings
If a storage domain is destroyed and a tem
Daniel Erez has posted comments on this change.
Change subject: webadmin: merge the 2 SPM columns into 1 (#845320)
..
Patch Set 2: (1 inline comment)
File
frontend/webadmin/
Sharad Mishra has posted comments on this change.
Change subject: core: Added final to member variables.
..
Patch Set 1: Verified
builds successfully in my env
--
To view, visit http://gerrit.ovirt.org/7189
To unsubscribe, vis
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: ldap - no need to set default to AD.
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/136/ : FAILURE
http://j
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: fix bug in disks subtab (#834240)
..
Patch Set 1: I would prefer that you didn't submit this
Build Failed
http://jenkins.ovirt.info/job/pat
Project: http://jenkins.ovirt.info/job/patch_engine_create_rpms/
Build: http://jenkins.ovirt.info/job/patch_engine_create_rpms/133/
Build Number: 133
Build Status: Fixed
Triggered By: Manually triggered by user rmiddle for Gerrit:
http://gerrit.ovirt.org/7188
---
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Added final to member variables.
..
Patch Set 1: I would prefer that you didn't submit this
Build Failed
http://jenkins.ovirt.info/job/patch_en
Sharad Mishra has posted comments on this change.
Change subject: core: AsyncTaskDAO: static IdRowMapper instance
..
Patch Set 6: Looks good to me, but someone else must approve
built successfully in my env.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: set default quota in quota drop down (#838454)
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/134/ : SUC
Project: http://jenkins.ovirt.info/job/patch_engine_create_rpms/
Build: http://jenkins.ovirt.info/job/patch_engine_create_rpms/132/
Build Number: 132
Build Status: Still Failing
Triggered By: Manually triggered by user rmiddle for Gerrit:
http://gerrit.ovirt.org/7181
---
Project: http://jenkins.ovirt.info/job/patch_engine_create_rpms/
Build: http://jenkins.ovirt.info/job/patch_engine_create_rpms/131/
Build Number: 131
Build Status: Failure
Triggered By: Manually triggered by user rmiddle for Gerrit:
http://gerrit.ovirt.org/7189
-
Moti Asayag has posted comments on this change.
Change subject: core: Block Hotplug Nic in Certain Vm States (#826931)
..
Patch Set 2: (3 inline comments)
File
backend/manag
Daniel Erez has posted comments on this change.
Change subject: webadmin: set default quota in quota drop down (#838454)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7182
To unsubscribe,
Daniel Erez has posted comments on this change.
Change subject: webadmin: fix bug in disks subtab (#834240)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7181
To unsubscribe, visit http://
Sharad Mishra has uploaded a new change for review.
Change subject: core: Added final to member variables.
..
core: Added final to member variables.
These varibles should only be initialized from within the constructor.
Change-
Daniel Erez has submitted this change and it was merged.
Change subject: core: validate storage format by data center version
..
core: validate storage format by data center version
https://bugzilla.redhat.com/843502
https://bu
Daniel Erez has posted comments on this change.
Change subject: core: validate storage format by data center version
..
Patch Set 7: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/6990
T
Sharad Mishra has uploaded a new change for review.
Change subject: core: ldap - no need to set default to AD.
..
core: ldap - no need to set default to AD.
LdapProviderType should come from constructor so there is no need to de
Juan Hernandez has posted comments on this change.
Change subject: core: Add local configuration helper
..
Patch Set 3:
Rebased and added methods to build the external HTTP and HTTPS URLs of the
engine.
--
To view, visit http
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: We are not blocking reconstruct on domains during spm
recontend (#843100)
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/pat
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Show disabled prestared field in New Pool Dialog
..
Patch Set 1: I would prefer that you didn't submit this
Build Unstable
http://jenkins.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin- Bond with unmanaged network(#840825)
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/129/ : SUCCESS
http
Juan Hernandez has uploaded a new change for review.
Change subject: core: Fix notifier parameters
..
core: Fix notifier parameters
The default parameters of the notifier service are not adjusted
when the engine is configured. T
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Added new column 'fingerprint' in the vds_static table
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/128/
Yair Zaslavsky has posted comments on this change.
Change subject: [WIP] core: Improved version support (#760546)
..
Patch Set 1: Verified
Verified -
A. Saw that VDSM version appears at RPM format.
B. Used select host flow.
--
Hello Alexey Chub, Eli Mesika,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/7186
to review the following change.
Change subject: [WIP] core: Improved version support (#760546)
..
[WIP] core: Impr
Juan Hernandez has posted comments on this change.
Change subject: packaging: Better failed start message (#838527)
..
Patch Set 2:
Updated the message as suggested in the bug.
--
To view, visit http://gerrit.ovirt.org/7175
To
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Redirect to index when page not found
..
core: Redirect to index when page not found
This is a fix for commit 2107a03979 (ouput index.html as err
Juan Hernandez has posted comments on this change.
Change subject: core: Redirect to index when page not found
..
Patch Set 3: Verified; Looks good to me, approved
Based on previous acks.
--
To view, visit http://gerrit.ovirt.
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: set default quota in quota drop down (#838454)
..
webadmin: set default quota in quota drop down (#838454)
https://bugzilla.redhat.com/838454
"Move D
Gilad Chaplik has uploaded a new change for review.
Change subject: core: user query for quota (#847511)
..
core: user query for quota (#847511)
https://bugzilla.redhat.com/847511
When user fetches quota from the engine, it sho
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin,userportal: filter quota in quota dropdown (#847511)
..
webadmin,userportal: filter quota in quota dropdown (#847511)
https://bugzilla.redhat.com/84751
Gilad Chaplik has uploaded a new change for review.
Change subject: core: avoid prms check when quota unchanged
..
core: avoid prms check when quota unchanged
incase the quota refernce of an object (vm, disk or template)
isn't c
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: fix bug in disks subtab (#834240)
..
webadmin: fix bug in disks subtab (#834240)
https://bugzilla.redhat.com/834240
Change-Id: I806552b95070ff43ce8cc
Asaf Shakarchi has posted comments on this change.
Change subject: core: Redirect to index when page not found
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7153
To unsubscribe, visit http
Yair Zaslavsky has posted comments on this change.
Change subject: core: Redirect to index when page not found
..
Patch Set 2: Looks good to me, but someone else must approve
I would prefer Vojtech/Asaf to take a look as well,
Yair Zaslavsky has posted comments on this change.
Change subject: core: Redirect to index when page not found
..
Patch Set 2:
Looks good to me.
--
To view, visit http://gerrit.ovirt.org/7153
To unsubscribe, visit http://gerri
Federico Simoncelli has posted comments on this change.
Change subject: core: Add the QEMU guest agent support
..
Patch Set 1: (3 inline comments)
File backend/manager/dbscri
Federico Simoncelli has uploaded a new change for review.
Change subject: core: Add the QEMU guest agent support
..
core: Add the QEMU guest agent support
This patch adds the core support for the QEMU guest agent. The new
option
Einav Cohen has posted comments on this change.
Change subject: webadmin: merge the 2 SPM columns into 1 (#845320)
..
Patch Set 2: (3 inline comments)
File
frontend/webadmin
Ayal Baron has posted comments on this change.
Change subject: webadmin: Show disabled prestared field in New Pool Dialog
..
Patch Set 1: I would prefer that you didn't submit this
This should be enabled, not blocked.
--
To vi
ofri masad has posted comments on this change.
Change subject: webadmin: merge the 2 SPM columns into 1 (#845320)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7170
To unsubscribe, visit http://gerrit.ovirt
Muli Salem has posted comments on this change.
Change subject: core: Block Hotplug Nic in Certain Vm States (#826931)
..
Patch Set 2:
Change according to masayag's comments.
--
To view, visit http://gerrit.ovirt.org/7176
To un
Muli Salem has posted comments on this change.
Change subject: core: Block Hotplug Nic in Certain Vm States (#826931)
..
Patch Set 1: (3 inline comments)
File
backend/manage
Shahar Havivi has posted comments on this change.
Change subject: UI: close button is not closing configure and about dialogue
(#839481)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7177
To unsubscribe, v
Shahar Havivi has uploaded a new change for review.
Change subject: UI: close button is not closing configure and about dialogue
(#839481)
..
UI: close button is not closing configure and about dialogue (#839481)
https://bugzil
Michael Kublin has posted comments on this change.
Change subject: core:Add connection to DB after connectVds(#815083)
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3784
To unsubscribe, vi
Shireesh Anjal has abandoned this change.
Change subject: engine: Method to fetch SSH fingerprint of server
..
Patch Set 4: Abandoned
Same function sent by Alon Bar-Lev in another patch
http://gerrit.ovirt.org/6997
--
To view,
Einav Cohen has posted comments on this change.
Change subject: webadmin: merge the 2 SPM columns into 1 (#845320)
..
Patch Set 1: (9 inline comments)
File
frontend/webadmin
Yair Zaslavsky has posted comments on this change.
Change subject: core: Improve error message on failed host install.
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7076
To unsubscribe, vi
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Improve error message on failed host install.
..
core: Improve error message on failed host install.
I ran into this issue earlier this week when
Yair Zaslavsky has posted comments on this change.
Change subject: core: Improve error message on failed host install.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7076
To unsubscribe, visit http://gerrit.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Updated to version 3.2
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/120/ : SUCCESS
http://jenkins.ovi
Moti Asayag has posted comments on this change.
Change subject: core: Block Hotplug Nic in Certain Vm States (#826931)
..
Patch Set 1: (3 inline comments)
File
backend/manag
Muli Salem has posted comments on this change.
Change subject: core: Block Hotplug Nic in Certain Vm States (#826931)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7176
To unsubscribe, visit http://gerrit.o
Muli Salem has uploaded a new change for review.
Change subject: core: Block Hotplug Nic in Certain Vm States (#826931)
..
core: Block Hotplug Nic in Certain Vm States (#826931)
https://bugzilla.redhat.com/826931
This patch add
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Better failed start message (#838527)
..
packaging: Better failed start message (#838527)
https://bugzilla.redhat.com/838527
Improve the message pr
Robert Middleswarth has abandoned this change.
Change subject: : Adding a README just to testing out the patch process
(#xx)
..
Patch Set 1: Abandoned
Never a real patch just did this for testing
--
To view, visit http://
Tomas Jelinek has submitted this change and it was merged.
Change subject: engine: It is not possible to take prestared VM from pool
(#844917)
..
engine: It is not possible to take prestared VM from pool (#844917)
https://bugz
Tomas Jelinek has posted comments on this change.
Change subject: engine: It is not possible to take prestared VM from pool
(#844917)
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerri
Oved Ourfali has submitted this change and it was merged.
Change subject: core+ui: adding isFileDomain and isBlockDomain to StorageType
enum
..
core+ui: adding isFileDomain and isBlockDomain to StorageType enum
This patch adds
Oved Ourfali has posted comments on this change.
Change subject: core+ui: adding isFileDomain and isBlockDomain to StorageType
enum
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org
Tomas Jelinek has posted comments on this change.
Change subject: engine: It is not possible to take prestared VM from pool
(#844917)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6868
To
Tomas Jelinek has posted comments on this change.
Change subject: engine: It is not possible to take prestared VM from pool
(#844917)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6868
To unsubscribe, visi
Daniel Erez has posted comments on this change.
Change subject: core+ui: adding isFileDomain and isBlockDomain to StorageType
enum
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7164
To un
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: ReconstructMasterDomain - refresh storage pool before
connect(#841525)
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.info/job/patch_engine
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core:Add connection to DB after connectVds(#815083)
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/123/ : SUCCESS
Omer Frenkel has posted comments on this change.
Change subject: core:Add connection to DB after connectVds(#815083)
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3784
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: merge the 2 SPM columns into 1 (#845320)
..
Patch Set 1: I would prefer that you didn't submit this
Build Failed
http://jenkins.ovirt.info/
Tomas Jelinek has uploaded a new change for review.
Change subject: webadmin: Show disabled prestared field in New Pool Dialog
..
webadmin: Show disabled prestared field in New Pool Dialog
In Edit Pool Dialog the "Prestarted" fi
Michael Kublin has posted comments on this change.
Change subject: engine: We are not blocking reconstruct on domains during spm
recontend (#843100)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7172
To un
1 - 100 of 164 matches
Mail list logo
