Daniel Erez has posted comments on this change.
Change subject: webadmin: merge the 2 SPM columns into 1 (#845320)
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
Line 538: int lowValue = defaultSpmPriority / 2;
Line 539: items.add(new EntityModel("Low", lowValue)); //$NON-NLS-1$
Line 540: items.add(new EntityModel("Normal", defaultSpmPriority));
//$NON-NLS-1$
Line 541: int highValue = defaultSpmPriority + (maxSpmPriority -
defaultSpmPriority) / 2;
Line 542: items.add(new EntityModel("High", highValue)); //$NON-NLS-1$
You should use localization constants for these strings ("Never", "Low",
"Normal" and "High").
E.g. ConstantsManager.getInstance().getConstants().highTitle() instead of
"High".
Line 543:
Line 544: // Determine whether to set custom SPM priority, and where.
Line 545: EntityModel selectedItem = null;
Line 546:
--
To view, visit http://gerrit.ovirt.org/7170
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1db81336eac01ea2e713912a37e5bec90e10dfd5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
