Einav Cohen has posted comments on this change.
Change subject: webadmin: merge the 2 SPM columns into 1 (#845320)
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java
Line 184:
Line 185: if (value == -1) {
Line 186: return constants.spmNeverText();
Line 187: } else if (value == lowValue) {
Line 188: return constants.spmLowText(); //$NON-NLS-1$
"//$NON-NLS-1$" should be removed (refer to my original comment for this file
in patch set 1, in which I mentioned that both "//$NON-NLS-1$" and
"//$NON-NLS-2$" should be removed, since there are no hard coded strings in
this line anymore)
Line 189: } else if (value == defaultSpmPriority) {
Line 190: return constants.spmNormalText();
//$NON-NLS-1$
Line 191: } else if (value == highValue) {
Line 192: return constants.spmHighText(); //$NON-NLS-1$
Line 186: return constants.spmNeverText();
Line 187: } else if (value == lowValue) {
Line 188: return constants.spmLowText(); //$NON-NLS-1$
Line 189: } else if (value == defaultSpmPriority) {
Line 190: return constants.spmNormalText();
//$NON-NLS-1$
see my previous comment
Line 191: } else if (value == highValue) {
Line 192: return constants.spmHighText(); //$NON-NLS-1$
Line 193: }
Line 194:
Line 188: return constants.spmLowText(); //$NON-NLS-1$
Line 189: } else if (value == defaultSpmPriority) {
Line 190: return constants.spmNormalText();
//$NON-NLS-1$
Line 191: } else if (value == highValue) {
Line 192: return constants.spmHighText(); //$NON-NLS-1$
see my previous comment
Line 193: }
Line 194:
Line 195: return "Custom"; //$NON-NLS-1$
Line 196: }
--
To view, visit http://gerrit.ovirt.org/7170
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1db81336eac01ea2e713912a37e5bec90e10dfd5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
