Doron Fediuck has posted comments on this change.
Change subject: webadmin: merge the 2 SPM columns into 1 (#845320)
......................................................................
Patch Set 3: (1 inline comment)
Some minor indentations needs handling.
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
Line 385: String neverTitle();
Line 386:
Line 387: @DefaultStringValue("Normal")
Line 388: String normalTitle();
Line 389:
The new block you added is using spaces (which is a good thing),
but the rest of the code uses tabs for indentation. Since the project's policy
is whitespaces instead of tabs, I suggest you add an initial formatting patch
to proceed this one.
Line 390: @DefaultStringValue("[None]")
Line 391: String noneTitle();
Line 392:
Line 393: @DefaultStringValue("Remove Virtual Machine")
--
To view, visit http://gerrit.ovirt.org/7170
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1db81336eac01ea2e713912a37e5bec90e10dfd5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
