Moti Asayag has posted comments on this change.
Change subject: core: Block Hotplug Nic in Certain Vm States (#826931)
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugUnplugVmNicCommand.java
Line 32: if (isVmStatusProperForHotPlugNic(getVm().getstatus())) {
Line 33: setVdsId(getVm().getrun_on_vds().getValue());
Line 34: returnValue = isHotPlugSupported() &&
isOSSupportingHotPlug();
Line 35: } else {
Line 36:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_VM_STATUS_ILLEGAL);
you're not using the new message type you've added. replace it with
HOT_PLUG_NIC_VM_STATUS_ILLEGAL.
Line 37: returnValue = false;
Line 38: }
Line 39:
Line 40: if (returnValue) {
Line 50:
Line 51: @Override
Line 52: protected void ExecuteVmCommand() {
Line 53: // HotPlug in the host needs to be called only if the Vm is UP
Line 54: if (getVm().getstatus() == VMStatus.Up) {
shouldn't vm status PoweringUp should be supported as well ?
Line 55: runVdsCommand(getParameters().getAction().getCommandType(),
Line 56: new
HotPlugUnplgNicVDSParameters(getVm().getrun_on_vds().getValue(),
Line 57: getVm().getId(),
Line 58:
DbFacade.getInstance().getVmNetworkInterfaceDAO().get(getParameters().getNicId()),
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 684: ACTION_TYPE_FAILED_GUEST_OS_VERSION_IS_NOT_SUPPORTED=Cannot ${action}
${type}. Guest OS version is not supported.
Line 685: HOT_PLUG_DISK_IS_NOT_VIRTIO=Can plug only virtIO disks.
Line 686: HOT_PLUG_DISK_IS_NOT_UNPLUGGED=Disk is already activated.
Line 687: HOT_UNPLUG_DISK_IS_NOT_PLUGGED=Disk is already deactivated.
Line 688: HOT_PLUG_NIC_VM_STATUS_ILLEGAL=Cannot activate/deactivate interface
due to VM status. The VM status must be Down, Powering Up or Up.
maybe:
Cannot activate/deactivate VM Network Interface due...
that way we maintain same entities naming conventions.
Line 689: VM_CANNOT_RUN_FROM_DISK_WITHOUT_PLUGGED_DISK=Cannot ${action} ${type}
without at least one active disk.\nPlease activate a disk and rerun the VM.
Line 690: SHAREABLE_DISK_IS_NOT_SUPPORTED_FOR_DISK=Cannot ${action} ${type}.
Disk cannot be shareable if it depends on a snapshot. In order to share it,
remove the disk's snapshots.
Line 691: ERROR_CANNOT_DETACH_DISK_WITH_SNAPSHOT=Cannot ${action} ${type}. The
disk is already configured in a snapshot. In order to detach it, remove the
disk's snapshots.
Line 692: DISK_IS_ALREADY_SHARED_BETWEEN_VMS=Cannot ${action} ${type}. Disk is
shared between vms and cannot become unshareable . Detach the disk from the
rest of the vms it is attached to and then update the disk to be unshareable.
--
To view, visit http://gerrit.ovirt.org/7176
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id759ca8152b455047c9c83447f526aaccdd77d6c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
