Allon Mureinik has posted comments on this change.
Change subject: core: Support undoing diskless previews
..
Patch Set 8: Verified
Fixed typo in the commit message, as per ofrenkel's comment.
Restored the null checking in end
Michael Kublin has posted comments on this change.
Change subject: core:Use %d instead %i for String format (#843099)
..
Patch Set 1: Looks good to me, approved
Where is verified? Even that it is obvious that patch is correct,
Selvasundaram has posted comments on this change.
Change subject: engine: Brick existance validation for add brick
..
Patch Set 3: Verified
Junit updated.
--
To view, visit http://gerrit.ovirt.org/5432
To unsubscribe, visit ht
Daniel Erez has posted comments on this change.
Change subject: core: validate storage format by DataCenter version
..
Patch Set 2: (1 inline comment)
Commit Message
Line 15:
Itamar Heim has posted comments on this change.
Change subject: core: validate storage format by DataCenter version
..
Patch Set 2: (1 inline comment)
Commit Message
Line 15:
Itamar Heim has posted comments on this change.
Change subject: core: validate storage format by DataCenter version
..
Patch Set 1: (1 inline comment)
File
backend/manager/m
Daniel Erez has posted comments on this change.
Change subject: core: validate storage format by DataCenter version
..
Patch Set 1: (1 inline comment)
File
backend/manager/m
Itamar Heim has posted comments on this change.
Change subject: core: validate storage format by DataCenter version
..
Patch Set 1: (1 inline comment)
File
backend/manager/m
Daniel Erez has posted comments on this change.
Change subject: core: validate storage format by DataCenter version
..
Patch Set 1: (1 inline comment)
File
backend/manager/m
Ayal Baron has posted comments on this change.
Change subject: core: validate storage format by DataCenter version
..
Patch Set 1: (1 inline comment)
File
backend/manager/mo
Itamar Heim has posted comments on this change.
Change subject: core: validate storage format by DataCenter version
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Doron Fediuck has posted comments on this change.
Change subject: core: fix null-support in search queries (#845297)
..
Patch Set 3: (2 inline comments)
File
backend/manager
Amador Pahim has uploaded a new change for review.
Change subject: tools: Add tolerance to engine-setup min memory threshold
..
tools: Add tolerance to engine-setup min memory threshold
engine-setup exits with error if system is
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine
..
Patch Set 3:
Sync with latest bootstrap changes, tarball name was updated to contain
interface number.
--
To v
Daniel Erez has posted comments on this change.
Change subject: webadmin: add quota to import vm (#846224)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6989
To unsubscribe, visit http://g
Daniel Erez has uploaded a new change for review.
Change subject: core: validate storage format by DataCenter version
..
core: validate storage format by DataCenter version
https://bugzilla.redhat.com/843502
https://bugzilla.red
Sharad Mishra has posted comments on this change.
Change subject: core:Use %d instead %i for String format (#843099)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6986
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: no error messages after jboss restart (#842112)
..
webadmin: no error messages after jboss restart (#842112)
https://bugzilla.redhat.com/84211
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: no error messages after jboss restart (#842112)
..
Patch Set 4: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: no error messages after jboss restart (#842112)
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: add quota to import vm (#846224)
..
webadmin: add quota to import vm (#846224)
https://bugzilla.redhat.com/846224
Change-Id: I2100035468d8a9b53b8a183
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: no error messages after jboss restart (#842112)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6912
To unsubscrib
Allon Mureinik has posted comments on this change.
Change subject: core:Use %d instead %i for String format (#843099)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/698
Moti Asayag has posted comments on this change.
Change subject: engine: Improve tests to expect violating entity (#844158)
..
Patch Set 1:
Is there a unit test for a multiple entities violation ?
--
To view, visit http://gerri
Moti Asayag has posted comments on this change.
Change subject: engine: Removed old add violation command (#844158)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6949
To unsubscribe, visit
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: [SetupNetworks] nets behaviour on bond create/extend
(#840825)
..
webadmin: [SetupNetworks] nets behaviour on bond create/extend (#840825)
https://bug
Moti Asayag has posted comments on this change.
Change subject: engine: Replace message of too few bond slaves (#844158)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6948
To unsubscribe,
Moti Asayag has posted comments on this change.
Change subject: engine: Replace message of network not exists (#844158)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6947
To unsubscribe, v
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: no error messages after jboss restart (#842112)
..
Patch Set 1: (1 inline comment)
File
frontend/
Moti Asayag has posted comments on this change.
Change subject: engine: Replace message of unsync networks (#844158)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6946
To unsubscribe, visi
Moti Asayag has posted comments on this change.
Change subject: engine: Replace message of network already attached (#844158)
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
..
Moti Asayag has posted comments on this change.
Change subject: engine: Replace message of nic specified more than once
(#844158)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6943
To uns
Moti Asayag has posted comments on this change.
Change subject: engine: Change violations to Map (#844158)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6942
To unsubscribe, visit http://g
Moti Asayag has posted comments on this change.
Change subject: engine: Add method to add violation (#844158)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6941
To unsubscribe, visit http:
Maor Lipchuk has uploaded a new change for review.
Change subject: core:Use %d instead %i for String format (#843099)
..
core:Use %d instead %i for String format (#843099)
Fix UnknownFormatConversionException by changing %i in s
Moti Asayag has posted comments on this change.
Change subject: engine: Change return of violation to list of String (#844158)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6940
To unsubsc
Doron Fediuck has posted comments on this change.
Change subject: core: quota search for disks (#845297)
..
Patch Set 3: I would prefer that you didn't submit this
Laszlo, please split into cleanup and code change patches.
--
Doron Fediuck has posted comments on this change.
Change subject: core: quota search for vms (#845297)
..
Patch Set 3: I would prefer that you didn't submit this
I agree with Allon.
Please split into cleanup and change patches
Doron Fediuck has posted comments on this change.
Change subject: core: autocompletion support for NULL (#845297)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6952
To unsubscribe, visit h
Doron Fediuck has posted comments on this change.
Change subject: core: fix null-support in search queries (#845297)
..
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
Laszlo,
There's one part ther
Moti Asayag has posted comments on this change.
Change subject: engine: Replace message of interface not exists (#844158)
..
Patch Set 1: (1 inline comment)
File
backend/man
Moti Asayag has posted comments on this change.
Change subject: core: ERROR: managed non pluggable device (#845207)
..
Patch Set 1: (1 inline comment)
there is another typo in the error message
Doron Fediuck has posted comments on this change.
Change subject: webadmin: Fixing vlan capitalization (#821456)
..
Patch Set 1: Fails
(2 inline comments)
Commit Message
Lin
Omer Frenkel has posted comments on this change.
Change subject: core: Support undoing diskless previews
..
Patch Set 7: (3 inline comments)
File
backend/manager/modules/bll
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: [SetupNetworks] unmanaged networks (#820504)
..
webadmin: [SetupNetworks] unmanaged networks (#820504)
https://bugzilla.redhat.com/820504
Add u
Daniel Erez has posted comments on this change.
Change subject: webadmin: [SetupNetworks] unmanaged networks (#820504)
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6973
To unsubscribe, vi
Alona Kaplan has posted comments on this change.
Change subject: webadmin: [SetupNetworks] unmanaged networks (#820504)
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/6973
To unsubscribe, visit http://gerrit
Daniel Erez has posted comments on this change.
Change subject: webadmin: [SetupNetworks] unmanages networks (#820504)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6973
To unsubscribe, vi
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine
..
Patch Set 2:
Add cleanup of temp directory to bootstrap command.
--
To view, visit http://gerrit.ovirt.org/6963
Alon Bar-Lev has posted comments on this change.
Change subject: engine: Method to fetch SSH fingerprint of server
..
Patch Set 4:
Hello,
I splited[1] the connect() into connect() and authenticate() you can do the
magic betwe
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: new implementation for apache-sshd usage
..
Patch Set 12:
As suggested at [1], split connect() into connect() and authenticate() this
will allow testi
Alona Kaplan has posted comments on this change.
Change subject: webadmin: [SetupNetworks] unmanages networks (#820504)
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/6973
To unsubscribe, visit http://gerrit
Allon Mureinik has posted comments on this change.
Change subject: core: Support undoing diskless previews
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/6676
To unsubscribe, visit http://gerrit.ovirt.org/se
Eli Mesika has uploaded a new change for review.
Change subject: core: ERROR: managed non pluggable device (#845207)
..
core: ERROR: managed non pluggable device (#845207)
ERROR: managed non pluggable device was removed unexpect
Shahar Havivi has posted comments on this change.
Change subject: UI: fix NPE in new cluster dialogue
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6982
To unsubscribe, visit http://gerrit.ovirt.org/setting
Allon Mureinik has posted comments on this change.
Change subject: core: adding a db function to get a config value
..
Patch Set 1: (1 inline comment)
File backend/manager/db
Shahar Havivi has uploaded a new change for review.
Change subject: UI: fix NPE in new cluster dialogue
..
UI: fix NPE in new cluster dialogue
Change-Id: Ic5de999ab1a18e7c9c44e5073380da8c41122355
Signed-off-by: Shahar Havivi
---
Eli Mesika has uploaded a new change for review.
Change subject: core: adding a db function to get a config value
..
core: adding a db function to get a config value
Adding a new function that accepts the option_name and value a
Michael Pasternak has uploaded a new change for review.
Change subject: cli: support utf-8 encoding
..
cli: support utf-8 encoding
Change-Id: I0353e14b1f5268bea4077c40da167d5370a02bd6
Signed-off-by: Michael Pasternak
---
M src/
Shireesh Anjal has posted comments on this change.
Change subject: engine: Method to fetch SSH fingerprint of server
..
Patch Set 4:
Responses to Alon's comments.
"Please always rebase patches... I've moved the @Override to ba
Livnat Peer has posted comments on this change.
Change subject: UI: add missing bonding options to bonding type selection
..
Patch Set 1: I would prefer that you didn't submit this
The fix for this BZ is not by enabling all bon
Maor Lipchuk has posted comments on this change.
Change subject: core: Support undoing diskless previews
..
Patch Set 6:
Is there a bug open on it?
--
To view, visit http://gerrit.ovirt.org/6676
To unsubscribe, visit http://ge
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: no error messages after jboss restart (#842112)
..
Patch Set 1: (1 inline comment)
File
frontend/
Maor Lipchuk has posted comments on this change.
Change subject: core : create template from VM with no snappable disks (#841534)
..
Patch Set 3: (1 inline comment)
File
bac
Maor Lipchuk has posted comments on this change.
Change subject: core : create template from VM with no snappable disks (#841534)
..
Patch Set 3: (6 inline comments)
File
ba
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Clean up engineeringcryptutils' test logging
..
core: Clean up engineeringcryptutils' test logging
Fixed log4j to reference org.apache.log4j.help
Yair Zaslavsky has posted comments on this change.
Change subject: core: Clean up engineeringcryptutils' test logging
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6683
To unsubs
Yair Zaslavsky has posted comments on this change.
Change subject: core: Clean up engineeringcryptutils' test logging
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6683
To unsubscribe, vis
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Reloadable AutoRecoveryAllowedTypes config
..
core: Reloadable AutoRecoveryAllowedTypes config
Flagged the AutoRecoveryAllowedTypes config value
Yair Zaslavsky has posted comments on this change.
Change subject: core: Reloadable AutoRecoveryAllowedTypes config
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6918
To unsubscr
Yair Zaslavsky has posted comments on this change.
Change subject: core: Reloadable AutoRecoveryAllowedTypes config
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6918
To unsubscr
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: comment out tests that depend on powermock
..
core: comment out tests that depend on powermock
There are other tests that needs to be taken care
Yair Zaslavsky has posted comments on this change.
Change subject: core: comment out tests that depend on powermock
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/6808
To unsubscribe, visit http://gerrit.ovi
Yair Zaslavsky has posted comments on this change.
Change subject: core: comment out tests that depend on powermock
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6808
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: engine: Method to fetch SSH fingerprint of server
..
Patch Set 4:
Hi,
Please always rebase patches... I've moved the @Override to base patch.
Imaging this seque
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Implement dialog close button (icon)
..
Patch Set 3:
Refactored popup presenter widget hierarchy:
* eliminating duplicate code
* consolidat
Michael Kublin has posted comments on this change.
Change subject: core: minor SearchObjectAutoCompleter cleanup
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6833
To unsubscribe, visit ht
Maor Lipchuk has posted comments on this change.
Change subject: core : NewTemplateVmModelBehavior - added Override annotation
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6931
To unsubsc
Shireesh Anjal has posted comments on this change.
Change subject: engine: Method to fetch SSH fingerprint of server
..
Patch Set 3:
Responses to Alon's comments below. New patch-set to follow.
"You already have the server key
noam slomianko has uploaded a new change for review.
Change subject: webadmin: Fixing vlan capitalization (#821456)
..
webadmin: Fixing vlan capitalization (#821456)
https://bugzilla.redhat.com/821456
Vlan -> VLAN
Change-Id: I
Allon Mureinik has posted comments on this change.
Change subject: core: minor SearchObjectAutoCompleter cleanup
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6833
To
Allon Mureinik has posted comments on this change.
Change subject: core: Support undoing diskless previews
..
Patch Set 6: Verified
answered mlipchuk's review.
--
To view, visit http://gerrit.ovirt.org/6676
To unsubscribe, vis
Shahar Havivi has posted comments on this change.
Change subject: UI: add missing bonding options to bonding type selection
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6974
To unsubscribe, visit http://ge
Shahar Havivi has uploaded a new change for review.
Change subject: UI: add missing bonding options to bonding type selection
..
UI: add missing bonding options to bonding type selection
Change-Id: I0566ec05b80a766cb074d63f79d66
Daniel Erez has posted comments on this change.
Change subject: core:Edit job message referencing template/VM(#818295)
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6353
To unsubscribe, vi
Ori Liel has posted comments on this change.
Change subject: restapi: making gluster enums lower case in request/response
..
Patch Set 4: (1 inline comment)
File
backend/man
Michael Pasternak has posted comments on this change.
Change subject: restapi: Fix Response Body For Setup-Networks
..
Patch Set 1: (1 inline comment)
File
backend/manager/m
Michael Pasternak has posted comments on this change.
Change subject: restapi: Response Body For Activate-Deactivate Disk
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6972
To unsubscribe,
Michael Pasternak has posted comments on this change.
Change subject: restapi: Fix Response Body For Setup-Networks
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
...
Allon Mureinik has posted comments on this change.
Change subject: core: MigrateVmCommand cleanup
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6828
To unsubscribe, vi
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: [SetupNetworks] unmanages networks (#820504)
..
webadmin: [SetupNetworks] unmanages networks (#820504)
https://bugzilla.redhat.com/820504
Add unmanage
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Move Gluster host
..
engine: Move Gluster host
- Move host vdc command enhanced to support gluster host move between
cluster
if cluste
Omer Frenkel has posted comments on this change.
Change subject: engine: Move Gluster host
..
Patch Set 13: Verified; Looks good to me, approved
just rebase, verified by Selvasundaram
--
To view, visit http://gerrit.ovirt.org/
Ori Liel has uploaded a new change for review.
Change subject: restapi: Response Body For Activate-Deactivate Disk
..
restapi: Response Body For Activate-Deactivate Disk
Change-Id: Ic05e80172552faec173c833a7c812856b7829147
Signe
Omer Frenkel has posted comments on this change.
Change subject: engine: Move Gluster host
..
Patch Set 12: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5285
To unsubscribe, visit http://gerrit.ovirt.org
Allon Mureinik has posted comments on this change.
Change subject: core:Edit job message referencing template/VM(#818295)
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Allon Mureinik has posted comments on this change.
Change subject: core: quota search for vms (#845297)
..
Patch Set 3: Looks good to me, but someone else must approve
I approve of all the changes, but please separate them to a
Allon Mureinik has posted comments on this change.
Change subject: core: quota search for disks (#845297)
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6955
To unsubsc
Moti Asayag has uploaded a new change for review.
Change subject: core: Cannot replace management network nic (#840888)
..
core: Cannot replace management network nic (#840888)
https://bugzilla.redhat.com/840888
The patch allow
Allon Mureinik has posted comments on this change.
Change subject: core: autocompletion support for NULL (#845297)
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6952
T
1 - 100 of 126 matches
Mail list logo
