Allon Mureinik has posted comments on this change.
Change subject: core: adding a db function to get a config value
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File backend/manager/dbscripts/dbfunctions.sh
Line 380: echo $(head -1 ${filename})
why do you need a temp file?
why not just echo `${cmd} ${DATABASE} ${SERVERNAME} ${PORT}`?
--
To view, visit http://gerrit.ovirt.org/6981
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib91b52e62f9a3d004d9bcc83e674d538e25a14b9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
