Daniel Erez has posted comments on this change. Change subject: core: validate storage format by DataCenter version ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java Line 162: Version vdsVersion = Collections.max(getVds().getSupportedClusterVersionsSet()); 1,2. This section is only for creating an unattached storage domain (i.e. choosing DC (none) in the UI). Should we validate the compatibility level based on the Cluster instead? 3. I guess we can return a default formats set if needed? -- To view, visit http://gerrit.ovirt.org/6990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia062c1587bc6c35c7ec27270d450d1e312742086 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
