Shireesh Anjal has posted comments on this change. Change subject: engine: Method to fetch SSH fingerprint of server ......................................................................
Patch Set 4: Responses to Alon's comments. "Please always rebase patches... I've moved the @Override to base patch." >> I actually had tried to do that, but looks like I goofed up somewhere >> (possibly rebased with the older patch-set!). Will rebase correctly when I >> send the next patch-set. "What if destination X changes IP address between (1) and (2)?" >> Interesting scenario. Maybe we should have a version of the connect() method >> which takes an additional argument - the fingerprint verified by the user, >> and validates against it before sending the credentials? Also, the use case here is more like: - connect to host h1, get fingerprint - connect to host h2, get fingerprint - ... - connect to host hn, get fingerprint - display all these fingerprints to user - If user approves all fingerprints, add all of them to the cluster "floating features within product is not something that is wise" >> Let us agree to disagree on this one :) Also I'm not sure whether I conveyed >> correctly that the other patch that is supposed to consume this method is >> actually under development and will be sent to gerrit very soon. "A better process is to write several patches then either merge them at same time" >> I'm completely ok with this one! As I said, We're working on the feature >> that uses this method right now, and the corresponding patch will be in real >> soon - so no problem in merging both these patches at same time. Generally, >> we work on multiple patches that are dependent on each other, and are >> developed and reviewed by different folks. In some cases it may not be >> possible to merge them at exactly same time, but we make sure that they get >> merged in quick succession. "I will add something similar to the core patch, superseding this one." >> Are you suggesting that this patch can be abandoned and you'll take care of >> providing a similar method (getFingerprint) in your core patch? -- To view, visit http://gerrit.ovirt.org/6927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I398fac6cbf641b49c8281937280ae0c351e1d3b6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
