Omer Frenkel has posted comments on this change.
Change subject: core: Support undoing diskless previews
......................................................................
Patch Set 7: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
Line 111: }
in previous code, if one task create suceeded, the command will be set to
succeeded, regardless to any failure.
in new code, if one failed the succeede will be false, regardless to any
success,
is this intentional? how does it affect the flow? (rollback?)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
Line 258: protected void endActionOnVmConfiguration() {
i strongly disagree with removing the check for vm is null,
can you be sure that there is no case that vm is deleted before getting here?
this code is called for almost all async tasks IIRC, including remove vm
this is defensive code that i believe was introduced because of a bad
experience...
....................................................
Commit Message
Line 10: on disks.
typo, should be "no disks"
--
To view, visit http://gerrit.ovirt.org/6676
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic62eee3cfb03abd21905ad6aa132c8cc10dbfb70
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
