Doron Fediuck has posted comments on this change.
Change subject: core: fix null-support in search queries (#845297)
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
Laszlo,
There's one part there, which is unreadable.
See inline. Please improve it to be more human readable.
....................................................
File
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SqlInjectionChecker.java
Line 23: public static final String SQLNULL = "null";
why is this public, while all other constants are private?
....................................................
File
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
Line 986:
if(!SqlInjectionChecker.SQLNULL.equalsIgnoreCase(customizedValue)) {
Laszlo,
I *know* you didn't write it. Still, this is almost unreadable.
Can you please reformat / move this part to a more readable function?
--
To view, visit http://gerrit.ovirt.org/6951
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b407adcdc8b13b652fd6cdf09a27b00bd92d36f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
