Yair Zaslavsky has posted comments on this change.
Change subject: core: Add engine-java-launcher script
..
Patch Set 4:
I liked the idea of OVIRT_VARS.
--
To view, visit http://gerrit.ovirt.org/5129
To unsubscribe, visit http
Ayal Baron has posted comments on this change.
Change subject: ImagesHandler PerformImageChecks refactor (WIP)
..
Patch Set 1: I would prefer that you didn't submit this
(27 inline comments)
...
Yair Zaslavsky has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 11: Verified
Verified by checking that engine-manage-domains managed to add an AD domain
with composite password.
Yair Zaslavsky has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 11:
Patchset 11 - Followed Juan's comments on patch of "chmod" command.
--
To view, visit http://gerrit.ovirt.org/6
Yair Zaslavsky has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 10: (3 inline comments)
File
backend/manager/modules/utils/src
Alon Bar-Lev has posted comments on this change.
Change subject: core: Add engine-java-launcher script
..
Patch Set 4:
> > I think we should not distinguish between dev and prod, but have
> > configuration of product with file
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: lowering log level of repetitive messages
..
webadmin: lowering log level of repetitive messages
* Lowering messages log level to FINE for reduc
Daniel Erez has posted comments on this change.
Change subject: webadmin: lowering log level of repetitive messages
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/6028
To
Daniel Erez has posted comments on this change.
Change subject: webadmin: Disks - adding tool-tips to icon columns
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/6027
To
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Disks - adding tool-tips to icon columns
..
webadmin: Disks - adding tool-tips to icon columns
Adding tool-tips to icon columns:
VM/Template, bo
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: adding support for ImageCell tool-tip
..
webadmin: adding support for ImageCell tool-tip
ImageResourceColumn:
* setTitle - adds a tool-tip by a
Daniel Erez has posted comments on this change.
Change subject: webadmin: adding support for ImageCell tool-tip
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/6026
To uns
Juan Hernandez has posted comments on this change.
Change subject: core: Add engine-java-launcher script
..
Patch Set 4:
> I think we should not distinguish between dev and prod, but have
> configuration of product with file l
Alon Bar-Lev has posted comments on this change.
Change subject: build: use maven deploy and move jar handling to Makefile
..
Patch Set 1: (6 inline comments)
>> I have not test this on live machine yet.
> Yes, please, test it
Alon Bar-Lev has posted comments on this change.
Change subject: core: Add engine-java-launcher script
..
Patch Set 4:
I was just about to ask why there is no such script :)
That's great!
I think we should not distinguish betw
Juan Hernandez has posted comments on this change.
Change subject: packaging: adding functionality to MYUM class
..
Patch Set 1: (3 inline comments)
File packaging/fedora/set
Alex Lourie has posted comments on this change.
Change subject: packaging: adding functionality to MYUM class
..
Patch Set 1: No score
(4 inline comments)
File packaging/fed
Juan Hernandez has posted comments on this change.
Change subject: packaging: adding functionality to MYUM class
..
Patch Set 1: (4 inline comments)
File packaging/fedora/set
Alex Lourie has posted comments on this change.
Change subject: packaging: adding functionality to MYUM class
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
Verified manually by importing the class an
Alex Lourie has uploaded a new change for review.
Change subject: packaging: adding functionality to MYUM class
..
packaging: adding functionality to MYUM class
* Added member function packageAvailable that returns true if
provi
Juan Hernandez has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 10: (3 inline comments)
See the comments in line.
In general it is advisable to avoid running external programs fro
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/2030/
Build Number: 2030
Build Status: Fixed
Triggered By: Started by user Eyal Edri
-
Changes Since Last Success:
--
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixing CompositePasswordValueHelper
..
Patch Set 2: Verified
Verified -
Tested that engine-manage-domains works with adding a domain, and using
--admin-p
Moti Asayag has uploaded a new change for review.
Change subject: webadmin: Get network connectivity timeout from configuration
..
webadmin: Get network connectivity timeout from configuration
The patch replaces a hard-coded con
Moti Asayag has uploaded a new change for review.
Change subject: core: Pass timeout greater than zero to VDSM
..
core: Pass timeout greater than zero to VDSM
The connectivity timeout should be sent to VDSM for setupNetworks onl
Juan Hernandez has posted comments on this change.
Change subject: packaging: Add the quick_rpm make target
..
Patch Set 2:
That is indeed a good reason. Thanks for explaining.
--
To view, visit http://gerrit.ovirt.org/5955
To
Eyal Edri has posted comments on this change.
Change subject: packaging: Add the quick_rpm make target
..
Patch Set 2:
i want to be able to run make rpm in an isolated environment, so if more than
one job will run on the same
Juan Hernandez has posted comments on this change.
Change subject: packaging: Add the quick_rpm make target
..
Patch Set 2:
Verified that "make RPMBUIDL=..." works correctly. But I still wonder why you
need this. That director
Ofer Schreiber has posted comments on this change.
Change subject: packaging: updated storage format in AIO host creation.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Alex Lourie has posted comments on this change.
Change subject: packaging: updated storage format in AIO host creation.
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.o
Juan Hernandez has posted comments on this change.
Change subject: packaging: Add the quick_rpm make target
..
Patch Set 2:
Should be as simple as this:
make RPMBUILD=/whatever/you/want/to/use quick_rpm
But I will test it.
Alex Lourie has uploaded a new change for review.
Change subject: packaging: updated storage format in AIO host creation.
..
packaging: updated storage format in AIO host creation.
Change-Id: I768fddbb387cc31c941c3fdcbb84b6b65ed
Eyal Edri has posted comments on this change.
Change subject: packaging: Add the quick_rpm make target
..
Patch Set 2:
just to be sure.
does the makefile support alternative RPMBUILD dir?
can it be set via envrionment variable
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: lowering log level of repetitive messages
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6028
To unsubs
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Disks - adding tool-tips to icon columns
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6027
To unsubsc
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: adding support for ImageCell tool-tip
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6026
To unsubscrib
Tal Nisan has uploaded a new change for review.
Change subject: ImagesHandler PerformImageChecks refactor (WIP)
..
ImagesHandler PerformImageChecks refactor (WIP)
Change-Id: I1a8a8312b8e1e31456ad7ee4f5d6edc96029e5ea
Signed-off-b
Juan Hernandez has posted comments on this change.
Change subject: core: Fixing CompositePasswordValueHelper
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
..
Juan Hernandez has posted comments on this change.
Change subject: packaging: Add the quick_rpm make target
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/5955
To unsubscribe, visit http://gerrit.ovirt.org/s
Maor Lipchuk has submitted this change and it was merged.
Change subject: engine:Validate if disk plugged on detach.(#838960)
..
engine:Validate if disk plugged on detach.(#838960)
If disk is already deactivate from VM, there i
Maor Lipchuk has posted comments on this change.
Change subject: engine:Validate if disk plugged on detach.(#838960)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6152
To unsubsc
Alon Bar-Lev has posted comments on this change.
Change subject: agent: new implementation for nics' information function.
..
Patch Set 1:
I was totally wrong... a pointer to the function is stored and not the return
value.
So
Juan Hernandez has posted comments on this change.
Change subject: build: use maven deploy and move jar handling to Makefile
..
Patch Set 1: (1 inline comment)
File Makefile
Yair Zaslavsky has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 9: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6096
To unsubscribe, visit http://gerrit.ovi
Hello Eli Mesika,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/6196
to review the following change.
Change subject: core: clear VM device address when changing a vm disk interface
..
core: clear
Shahar Havivi has posted comments on this change.
Change subject: core: Fixing CompositePasswordValueHelper
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6191
To unsubscribe, visit http://
Juan Hernandez has posted comments on this change.
Change subject: build: use maven deploy and move jar handling to Makefile
..
Patch Set 1: (6 inline comments)
> I prefer the brew method of handling maven output, using the mav
Allon Mureinik has posted comments on this change.
Change subject: engine: Disable gluster tests in default build.
..
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
Shireesh Anjal has uploaded a new change for review.
Change subject: engine: Disable gluster tests in default build.
..
engine: Disable gluster tests in default build.
Disabled gluster tests in default build, as they still use P
Michal Skrivanek has posted comments on this change.
Change subject: agent: new implementation for nics' information function.
..
Patch Set 1: (1 inline comment)
File ovirt-g
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/2028/
Build Number: 2028
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 2,216
-
Kanagaraj M has uploaded a new change for review.
Change subject: restapi: filtering rsdl according to ApplicationMode
..
restapi: filtering rsdl according to ApplicationMode
The rsdl response will be filtered according to the
A
Juan Hernandez has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6096
To unsubscribe, vi
Shahar Havivi has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 8: (3 inline comments)
File
backend/manager/tools/engine-config
Moti Asayag has posted comments on this change.
Change subject: core: Removing unneeded opened transaction
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6193
To unsubs
Michael Kublin has posted comments on this change.
Change subject: core: Fixing CompositePasswordValueHelper
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6191
To unsu
Michael Kublin has posted comments on this change.
Change subject: core: Removing unneeded opened transaction
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6193
To unsubscribe, visit http://gerrit.ovirt.org
Michael Kublin has uploaded a new change for review.
Change subject: core: Removing unneeded opened transaction
..
core: Removing unneeded opened transaction
A cancel for all task was run inside global transaction, for such case
Michael Kublin has posted comments on this change.
Change subject: core: Small improvements at reconstruct flow
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6192
To unsubscribe, visit http://gerrit.ovirt.o
Michael Kublin has posted comments on this change.
Change subject: core: Change reconstruct flow
..
Patch Set 7: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/6066
To unsubscribe, visit http://gerrit.ovirt.org/set
Michael Kublin has uploaded a new change for review.
Change subject: core: Small improvements at reconstruct flow
..
core: Small improvements at reconstruct flow
We don't need to use a query in order to retrieve id of master dom
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Fixing CompositePasswordValueHelper
..
core: Fixing CompositePasswordValueHelper
CompositePasswordValueHelper should support --admin-pass-file as well
C
Juan Hernandez has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 8: (3 inline comments)
I verified this with a new build. It works mostly correct, but I found an issue
with the int
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: Use AspectJ annotations instead of compiler
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Alon Bar-Lev has posted comments on this change.
Change subject: agent: new implementation for nics' information function.
..
Patch Set 1:
I don't know the code well...
Just a question...
It seems that this change convert dyn
Yaniv Dary has posted comments on this change.
Change subject: packaging: updated setup to use correct DB name.
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6189
To unsubscribe,
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: updated setup to use correct DB name.
..
packaging: updated setup to use correct DB name.
Updated setup to use ovirt_engine_history db name
inst
Alex Lourie has uploaded a new change for review.
Change subject: packaging: updated setup to use correct DB name.
..
packaging: updated setup to use correct DB name.
Updated setup to use ovirt_engine_history db name
instead of
Juan Hernandez has posted comments on this change.
Change subject: webadmin: Use AspectJ annotations instead of compiler
..
Patch Set 2:
Removed complete the references to the AspectJ plugin.
--
To view, visit http://gerrit.ov
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: updated pgpass parsing (#839519)
..
packaging: updated pgpass parsing (#839519)
https://bugzilla.redhat.com/show_bug.cgi?id=839519
Signed-off-b
Yaniv Dary has posted comments on this change.
Change subject: packaging: updated pgpass parsing (#839519)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6186
To unsubscribe, visit http://g
Kiril Nesenko has posted comments on this change.
Change subject: packaging: updated pgpass parsing (#839519)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6186
To unsubscribe, visit http://gerrit.ovirt.org
Michael Pasternak has submitted this change and it was merged.
Change subject: codegen: store persistent_auth in cache rather than in proxy
instance
..
codegen: store persistent_auth in cache rather than in proxy instance
Chan
Michael Pasternak has posted comments on this change.
Change subject: codegen: store persistent_auth in cache rather than in proxy
instance
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.o
Michael Pasternak has submitted this change and it was merged.
Change subject: codegen: generate root resource attribute methods
programmatically
..
codegen: generate root resource attribute methods programmatically
Change-Id:
Michael Pasternak has posted comments on this change.
Change subject: codegen: generate root resource attribute methods
programmatically
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovir
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: refactor /status/ command
..
cli: refactor /status/ command
Change-Id: Ice5be34c0ef14f3b5713c25623ee053c8b9d5821
Signed-off-by: Michael Pastern
Michael Pasternak has posted comments on this change.
Change subject: cli: refactor /status/ command
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6181
To unsubscribe, visit http
Michael Pasternak has posted comments on this change.
Change subject: cli: do not force credentials check on sdk > 3.1.0.4
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6177
To u
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: do not force credentials check on sdk > 3.1.0.4
..
cli: do not force credentials check on sdk > 3.1.0.4
sdk >= 3.1.0.4 verifying credentials du
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: implement /info/ command
..
cli: implement /info/ command
Change-Id: I4b02037317dfcadbf41ea3547a307062eeafd6a5
Signed-off-by: Michael Pasternak
Michael Pasternak has posted comments on this change.
Change subject: cli: implement /info/ command
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6155
To unsubscribe, visit http:
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: regenerate python bindings (python<->xml mappings) using
new codegen tool
..
sdk: regenerate python bindings (python<->xml mappings) using ne
Michael Pasternak has posted comments on this change.
Change subject: sdk: regenerate python bindings (python<->xml mappings) using
new codegen tool
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http:
Ori Liel has posted comments on this change.
Change subject: codegen: generate root resource attribute methods
programmatically
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ov
Ori Liel has posted comments on this change.
Change subject: codegen: store persistent_auth in cache rather than in proxy
instance
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Ori Liel has posted comments on this change.
Change subject: cli: implement /info/ command
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6155
To unsubscribe, visit htt
Ori Liel has posted comments on this change.
Change subject: cli: refactor /status/ command
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6181
To unsubscribe, visit ht
Michael Pasternak has uploaded a new change for review.
Change subject: codegen: store persistent_auth in cache rather than in proxy
instance
..
codegen: store persistent_auth in cache rather than in proxy instance
Change-Id: I
Alex Lourie has posted comments on this change.
Change subject: packaging: updated pgpass parsing (#839519)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6186
To unsub
Michal Skrivanek has posted comments on this change.
Change subject: agent: new implementation for nics' information function.
..
Patch Set 1: (1 inline comment)
File ovirt-g
Alex Lourie has uploaded a new change for review.
Change subject: packaging: updated pgpass parsing (#839519)
..
packaging: updated pgpass parsing (#839519)
https://bugzilla.redhat.com/show_bug.cgi?id=839519
Signed-off-by: Alex
Michael Pasternak has uploaded a new change for review.
Change subject: codegen: generate root resource attribute methods
programmatically
..
codegen: generate root resource attribute methods programmatically
Change-Id: If63363
Juan Hernandez has posted comments on this change.
Change subject: packaging, tools: Generate engine-config.xml from template
..
Patch Set 14: Verified
--
To view, visit http://gerrit.ovirt.org/5362
To unsubscribe, visit http:/
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: engine-setup - Use semange instead of setsebool
..
packaging: engine-setup - Use semange instead of setsebool
engine-setup should use semana
Ofer Schreiber has posted comments on this change.
Change subject: packaging: engine-setup - Use semange instead of setsebool
..
Patch Set 4: Looks good to me, approved
ACked by juan
--
To view, visit http://gerrit.ovirt.org/5
Juan Hernandez has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 8: Looks good to me, but someone else must approve
Shahar, thanks for taking my suggestions into consideration.
--
Ofer Schreiber has posted comments on this change.
Change subject: packaging: engine-setup - Use semange instead of setsebool
..
Patch Set 4: Verified
This patch doesn't work on F17 due to BZ#835100. (same status as before)
Ver
Juan Hernandez has posted comments on this change.
Change subject: packaging: engine-setup - Use semange instead of setsebool
..
Patch Set 4: Looks good to me, but someone else must approve
The long options make it really easy
Juan Hernandez has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 7: Looks good to me, but someone else must approve
I would like to see more File objects and less Strings, but it lo
1 - 100 of 114 matches
Mail list logo
