Juan Hernandez has posted comments on this change.

Change subject: packaging: adding functionality to MYUM class
......................................................................


Patch Set 1: (3 inline comments)

....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 343:             self.yumbase.install(name=pkg)
Ok, understood, thanks for explaining.

Line 354:                 return False
Forget it, was just less than minor suggestion.

Line 367:                 self.yumbase.remove(name=pkg.name)
Ok.

--
To view, visit http://gerrit.ovirt.org/6203
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib26e517771d24242c1279358563dba74aca7cade
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to