Juan Hernandez has posted comments on this change. Change subject: packaging: adding functionality to MYUM class ......................................................................
Patch Set 1: (4 inline comments) .................................................... File packaging/fedora/setup/engine-upgrade.py Line 343: self.yumbase.install(name=pkg) Won't this actually install the package? Is that what you want? It doesn't match the name of the method. Line 354: return False return len(pkglist) > 0 ? Line 365: eap5pkgs = self.yumbase.doPackageLists(patterns=pkgs).installed The name "eap5pkgs" tells a bit about what you intend to do with these methods, but doesn't look like a good name for this variable. Line 367: self.yumbase.remove(name=pkg.name) Won't this actually remove the package? -- To view, visit http://gerrit.ovirt.org/6203 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib26e517771d24242c1279358563dba74aca7cade Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
