Alon Bar-Lev has posted comments on this change. Change subject: agent: new implementation for nics' information function. ......................................................................
Patch Set 1: I don't know the code well... Just a question... It seems that this change convert dynamic list to a static cached list. In the past whenever you called getAllNetworkInterfaces(), you get a fresh list, and now you get a static cached list. If that true, if a change is happening out side of our code we are not aware of it. -- To view, visit http://gerrit.ovirt.org/6183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2cc663150cb1dc17e568fb429ea786b6baa4ca9e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Gal Hammer <gham...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Gal Hammer <gham...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
