Maor Lipchuk has submitted this change and it was merged. Change subject: engine:Validate if disk plugged on detach.(#838960) ......................................................................
engine:Validate if disk plugged on detach.(#838960) If disk is already deactivate from VM, there is no need to deactivate it again when trying to detach it from VM. In the proposed solution I re-factor the condition to be in a separate method, and also validate that the disk is not already detached from the VM. Change-Id: I681a6feb7e7cbf010d7c37453efe1ccab40af98e Signed-off-by: Maor Lipchuk <mlipc...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6152 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I681a6feb7e7cbf010d7c37453efe1ccab40af98e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
