Alon Bar-Lev has posted comments on this change. Change subject: build: use maven deploy and move jar handling to Makefile ......................................................................
Patch Set 1: (6 inline comments) >> I have not test this on live machine yet. > Yes, please, test it. Will do. > We also need to check if the "%add_maven_depmap" macro in the .spec works > correctly with the changes in the POM files, as it is very picky. I will check. > I don't like the fact that the complexity of the Makefile is growing. However > I understand it is needed. I am starting to think that a python script or a > shell script would be a better tool for the job, as in fact we are seldom > using make capabilities and we are using more and more imperative programming > constructs. But this shouldn't block this patch. I agree, if we add more complexity we convert this to script. But I don't expect much more complexity. Thanks! .................................................... File Makefile Line 28: javadir=/usr/share/java automake convention is similar... bindir vs CFLAGS. libdir vs AM_LDFLAGS Just wanted to be consistent, although it seem weird... :) Line 64: vdsbroker OK, I will do that. Line 68: $(BUILD_FILE): I want to add tmp.* to .git ignore... If we have a proper prefix we can automatically ignore these temp files... I converted this to variable so that we have the name of the file once. What do you think? Line 87: all \ No... For example from automake (make masters!) -- install-am: all-am --- 'make install' should be the same of 'make all && make install' Line 173: install -p -m 644 "$$POM" $(PREFIX)$(mavenpomdir)/JPP.ovirt-engine-$$artifact_id.pom; \ No. I did not want to touch this. I did consider if do it in spec file or not. I assume you agree it should be added by spec, I will do this. Line 175: done Right. I fully agree, a simple shell script may be simpler. But people will look for Makefiles. I don't think we are going to be much more complex so we can keep using Makefile. If you see I am adding more complexity alert. -- To view, visit http://gerrit.ovirt.org/6171 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9eb8b8f60f2be71b2054582b5e898ae996f324ac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
