Oved Ourfali has submitted this change and it was merged.
Change subject: core: changing audit messages to contain UNKNOWN when no such
variable
..
core: changing audit messages to contain UNKNOWN when no such variable
This pa
Oved Ourfali has posted comments on this change.
Change subject: core: changing audit messages to contain UNKNOWN when no such
variable
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt
Oved Ourfali has submitted this change and it was merged.
Change subject: core: making all tag and bookmark operations non-monitored
..
core: making all tag and bookmark operations non-monitored
This patch changes all the tag a
Oved Ourfali has posted comments on this change.
Change subject: core: making all tag and bookmark operations non-monitored
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6079
To
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Fix disk messages and tasks description
..
core: Fix disk messages and tasks description
This patch:
1. Changes the disk-related messaged to use th
Oved Ourfali has posted comments on this change.
Change subject: core: Fix disk messages and tasks description
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6078
To unsubscribe,
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/1601/
Build Number: 1601
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 2,178
-
Changes Since
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1668/
Build Number: 1668
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 2,178
-
Chan
Moti Asayag has posted comments on this change.
Change subject: core: changing audit messages to contain UNKNOWN when no such
variable
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6080
T
Igor Lvovsky has posted comments on this change.
Change subject: webadmin: Set connectivity timeout of SetupNetworks in seconds
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Michael Pasternak has uploaded a new change for review.
Change subject: sdk: regenerate python bindings using new codegen tool
..
sdk: regenerate python bindings using new codegen tool
Change-Id: I9d6a57d515997e28a72eac38aada731
Allon Mureinik has posted comments on this change.
Change subject: core: cleanup IrsbrokerCommand.HandleSpmStatusResult
..
Patch Set 1: (1 inline comment)
File
backend/manag
Shahar Havivi has posted comments on this change.
Change subject: core: Fix disk messages and tasks description
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6078
To unsubscribe, visit htt
Allon Mureinik has posted comments on this change.
Change subject: history: removed used column from dwh views.
..
Patch Set 1: No score
--
To view, visit http://gerrit.ovirt.org/6069
To unsubscribe, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: history: removed used column from dwh views.
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Allon Mureinik has posted comments on this change.
Change subject: core: cleanup IrsbrokerCommand.HandleSpmStatusResult
..
Patch Set 1: (1 inline comment)
like the patch - just fix the indentation please.
.
Michael Kublin has posted comments on this change.
Change subject: core:Replace vm id with number of vms in views.
..
Patch Set 3:
I am talking about a formula that u introduced at the view, as I know such kind
of formulas are
Michael Kublin has posted comments on this change.
Change subject: core: toString method for XmlRpcStruct
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6086
To unsubscribe, visit http://ge
Maor Lipchuk has posted comments on this change.
Change subject: core:Replace vm id with number of vms in views.
..
Patch Set 3: (7 inline comments)
The field number_of_vms is fetched instead of vm_id, both of the fields were
Allon Mureinik has posted comments on this change.
Change subject: core: toString method for XmlRpcStruct
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6086
To unsubsc
Michael Kublin has submitted this change and it was merged.
Change subject: core: expose the V3 domain format in dc 3.1
..
core: expose the V3 domain format in dc 3.1
This patch introduces the new V3 format used for the Storage
Michael Kublin has posted comments on this change.
Change subject: core: expose the V3 domain format in dc 3.1
..
Patch Set 17: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4476
To unsubscribe,
Michael Kublin has posted comments on this change.
Change subject: core: Use the hostSpmId during reconstructMaster
..
Patch Set 11: (1 inline comment)
File
backend/manager/
Moti Asayag has posted comments on this change.
Change subject: core: changing audit messages to contain UNKNOWN when no such
variable
..
Patch Set 1:
Wouldn't it be better leave it as blank rather setting it to unknown?
--
T
Moti Asayag has posted comments on this change.
Change subject: core: making all tag and bookmark operations non-monitored
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6079
To unsubscribe
Allon Mureinik has posted comments on this change.
Change subject: core: Use the hostSpmId during reconstructMaster
..
Patch Set 11: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4967
Allon Mureinik has posted comments on this change.
Change subject: core: expose the V3 domain format in dc 3.1
..
Patch Set 17: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4476
To u
Kanagaraj M has uploaded a new change for review.
Change subject: restapi: making gluster enums lower case in request/response
..
restapi: making gluster enums lower case in request/response
All the gluster related enums will be
Eli Mesika has posted comments on this change.
Change subject: history: moved minimal etl version set to pre upgrade.
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5944
To unsubscribe, vis
Yair Zaslavsky has posted comments on this change.
Change subject: core: handle SHAREDFS returned from VDSM (#835949)
..
Patch Set 1:
Itamar - I already opened a bug on VDSM regarding your comment when I worked on
this -
see h
Itamar Heim has posted comments on this change.
Change subject: core: handle SHAREDFS returned from VDSM (#835949)
..
Patch Set 1:
only fedora 17 and ovirt 3.1 beta repo, and they should be patched...
--
To view, visit http://
Itamar Heim has posted comments on this change.
Change subject: core: handle SHAREDFS returned from VDSM (#835949)
..
Patch Set 1: I would prefer that you didn't submit this
I believe this is similar to:
Bug 835920 - [rhevm] Po
Juan Hernandez has posted comments on this change.
Change subject: packaging: Don't try to set VirtualMachineDomainName
..
Patch Set 1:
This is to complement this change:
http://gerrit.ovirt.org/5980
However, I am not 100% su
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Don't try to set VirtualMachineDomainName
..
packaging: Don't try to set VirtualMachineDomainName
This complements the change that removed this opti
Daniel Erez has posted comments on this change.
Change subject: webadmin: Set connectivity timeout of SetupNetworks in seconds
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6081
To unsubsc
Allon Mureinik has posted comments on this change.
Change subject: core: expose the V3 domain format in dc 3.1
..
Patch Set 16: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4476
To u
Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery - change logger to be final field
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery -removed uneeded null value check
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: When adding floating disk, an incorrect event is logged
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ov
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Clean gen directory before GWT compilation
..
Patch Set 1:
> shouldn't we use the maven-antrun-plugin which is already used in
> ear/pom.xm
Moti Asayag has uploaded a new change for review.
Change subject: webadmin: Set connectivity timeout of SetupNetworks in seconds
..
webadmin: Set connectivity timeout of SetupNetworks in seconds
The provided connectivity timeout
Michael Kublin has posted comments on this change.
Change subject: core: Added validation for removal of LUN disk
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6077
To unsubscribe, visit h
Tal Nisan has submitted this change and it was merged.
Change subject: core: Added validation for removal of LUN disk
..
core: Added validation for removal of LUN disk
Since there was no validation for removal of LUN disk, it w
Tal Nisan has posted comments on this change.
Change subject: core: Added validation for removal of LUN disk
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6077
To unsubscribe, vi
Oved Ourfali has uploaded a new change for review.
Change subject: core: changing audit messages to contain UNKNOWN when no such
variable
..
core: changing audit messages to contain UNKNOWN when no such variable
This patch chan
Oved Ourfali has uploaded a new change for review.
Change subject: core: making all tag and bookmark operations non-monitored
..
core: making all tag and bookmark operations non-monitored
This patch changes all the tag and bookm
Oved Ourfali has uploaded a new change for review.
Change subject: core: Fix disk messages and tasks description
..
core: Fix disk messages and tasks description
This patch:
1. Changes the disk-related messaged to use the DiskAl
Tal Nisan has uploaded a new change for review.
Change subject: core: Added validation for removal of LUN disk
..
core: Added validation for removal of LUN disk
Since there was no validation for removal of LUN disk, it was possi
Juan Hernandez has posted comments on this change.
Change subject: packaging: Updated cleanup to show error message to user
(#818230)
..
Patch Set 1: Looks good to me, but someone else must approve
Take into account that almos
Tal Nisan has posted comments on this change.
Change subject: core: When adding floating disk, an incorrect event is logged
..
Patch Set 2: (1 inline comment)
File
backend/m
Allon Mureinik has posted comments on this change.
Change subject: core: Remove disk from snapshots (#828192)
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/6025
To unsubscribe, visit http://gerrit.ovirt.org
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in RemoveImageCommand and anscentors
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/6024
To unsubscribe, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery -removed uneeded null value check
..
Patch Set 2: Looks good to me, but someone else must approve
double checked - I was mistaken. ignore
Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery - BitSet instead of indexOf
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/561
Michael Pasternak has submitted this change and it was merged.
Change subject: add a new tool for auto-generate python entities from schema
..
add a new tool for auto-generate python entities from schema
It is troublesome to ge
Allon Mureinik has posted comments on this change.
Change subject: core: When adding floating disk, an incorrect event is logged
..
Patch Set 2: (1 inline comment)
File
back
Michael Pasternak has posted comments on this change.
Change subject: add a new tool for auto-generate python entities from schema
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/
Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery -removed CanDoAction()
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5631
To
Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery - use of concrete AuditLogType enum value
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery - removal of '_' character from members
names
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://g
Liron Aravot has posted comments on this change.
Change subject: core: Cleanup in RemoveImageCommand and anscentors
..
Patch Set 3: (1 inline comment)
File
backend/manager/m
Tal Nisan has posted comments on this change.
Change subject: core: When adding floating disk, an incorrect event is logged
..
Patch Set 2: (1 inline comment)
File
backend/m
Shahar Havivi has posted comments on this change.
Change subject: engine: fix setup that will work with the new engine-config
password policy
..
Patch Set 1:
I never verify that its work...
Juan please verify this patch.
--
T
Shahar Havivi has uploaded a new change for review.
Change subject: engine: fix setup that will work with the new engine-config
password policy
..
engine: fix setup that will work with the new engine-config password policy
Chan
Allon Mureinik has posted comments on this change.
Change subject: core: When adding floating disk, an incorrect event is logged
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
...
Tal Nisan has posted comments on this change.
Change subject: core: When adding floating disk, an incorrect event is logged
..
Patch Set 2: (1 inline comment)
File
backend/m
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in RemoveImageCommand and anscentors
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/6024
To unsubscribe, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery -removed uneeded null value check
..
Patch Set 2: I would prefer that you didn't submit this
the check should be left inside the function
Allon Mureinik has posted comments on this change.
Change subject: core: When adding floating disk, an incorrect event is logged
..
Patch Set 2: (1 inline comment)
File
back
Liron Aravot has uploaded a new change for review.
Change subject: core: RegisterVdsQuery - change logger to be final field
..
core: RegisterVdsQuery - change logger to be final field
changed private logger field to be final
Ch
Michael Pasternak has posted comments on this change.
Change subject: add a new tool for auto-generate python entities from schema
..
Patch Set 9: (2 inline comments)
well done!
Maor Lipchuk has posted comments on this change.
Change subject: core: Cleanup in RemoveImageCommand and anscentors
..
Patch Set 2: (1 inline comment)
File
backend/manager/m
Maor Lipchuk has posted comments on this change.
Change subject: core: Cleanup in RemoveImageCommand and anscentors
..
Patch Set 2: (1 inline comment)
File
backend/manager/m
Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery - BitSet instead of indexOf
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/561
Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery -removed CanDoAction()
..
Patch Set 8: I would prefer that you didn't submit this
(1 inline comment)
...
Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery - removal of '_' character from members
names
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://g
Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery - use of concrete AuditLogType enum value
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in RemoveImageCommand and anscentors
..
Patch Set 2: (4 inline comments)
File
backend/manage
Michael Pasternak has posted comments on this change.
Change subject: add a new tool for auto-generate python entities from schema
..
Patch Set 9:
> seems not good text format. re-publish again.
> yes, I reuse the ovirtsdk.web
Gal Hammer has posted comments on this change.
Change subject: core: WIP - Add support for Qemu GA (#830954)
..
Patch Set 2: (3 inline comments)
File
backend/manager/modules
ShaoHe Feng has posted comments on this change.
Change subject: add a new tool for auto-generate python entities from schema
..
Patch Set 9:
Michael, Now you can run src/codegen/main.py directly.
--
To view, visit http://gerri
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Move JBoss modules from Makefile to spec
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
..
Michael Kublin has posted comments on this change.
Change subject: core: Change reconstruct flow
..
Patch Set 2:
Applying Yair comments (That I am agree)
--
To view, visit http://gerrit.ovirt.org/6066
To unsubscribe, visit htt
Michael Kublin has posted comments on this change.
Change subject: core: Change reconstruct flow
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/6066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Juan Hernandez has posted comments on this change.
Change subject: packaging: Move JBoss modules from Makefile to spec
..
Patch Set 2: (1 inline comment)
File Makefile
Line 3
Michael Kublin has posted comments on this change.
Change subject: core: Change reconstruct flow
..
Patch Set 1: (5 inline comments)
File
backend/manager/dbscripts/upgrade/0
Michael Kublin has posted comments on this change.
Change subject: core: expose the V3 domain format in dc 3.1
..
Patch Set 15: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4476
To unsubscribe, visit htt
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: release 3.1.0.4-1
..
sdk: release 3.1.0.4-1
Change-Id: Ieb463bfaac773ce6b809e07a120feb2250941844
Signed-off-by: Michael Pasternak
---
M Makefi
Michael Pasternak has posted comments on this change.
Change subject: sdk: release 3.1.0.4-1
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6070
To unsubscribe, visit http://gerri
Michael Pasternak has uploaded a new change for review.
Change subject: sdk: release 3.1.0.4-1
..
sdk: release 3.1.0.4-1
Change-Id: Ieb463bfaac773ce6b809e07a120feb2250941844
Signed-off-by: Michael Pasternak
---
M Makefile
M ovi
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Move JBoss modules from Makefile to spec
..
Patch Set 2: (1 inline comment)
File Makefile
Line 311
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: Don't expand entities
..
restapi: Don't expand entities
Configure RESTEasy so that the built-in unmarshaller for
org.w3c.dom.Document will
Michael Pasternak has posted comments on this change.
Change subject: restapi: Don't expand entities
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/6059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Michael Pasternak has posted comments on this change.
Change subject: restapi: Don't expand entities
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6059
To unsubscribe, visit http://gerrit.
Juan Hernandez has posted comments on this change.
Change subject: restapi: Don't expand entities
..
Patch Set 2:
Rebased, no other change since last verification.
--
To view, visit http://gerrit.ovirt.org/6059
To unsubscribe,
Vojtech Szocs has posted comments on this change.
Change subject: userportal, webadmin: make the whole tabs clickable (#783176)
..
Patch Set 1:
Instead of adding DOM click handler on tabContainer (wrapper div) element,
which m
Maor Lipchuk has posted comments on this change.
Change subject: core: RegisterVdsQuery - use of concrete AuditLogType enum value
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.o
Juan Hernandez has posted comments on this change.
Change subject: packaging: Move JBoss modules from Makefile to spec
..
Patch Set 2: (1 inline comment)
File Makefile
Line 3
Maor Lipchuk has posted comments on this change.
Change subject: core: RegisterVdsQuery - removal of '_' character from members
names
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6041
To
Michael Pasternak has posted comments on this change.
Change subject: sdk: rebase to latest api
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6068
To unsubscribe, visit http://ge
1 - 100 of 202 matches
Mail list logo
