Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Clean gen directory before GWT compilation ......................................................................
Patch Set 1: > shouldn't we use the maven-antrun-plugin which is already used in > ear/pom.xml, for example, for deleting a directory (in the ear/pom.xml case, > it is used to delete the deployment directory)? IMO deleting project files via maven-clean-plugin fits better into overall Maven build lifecycle than using maven-antrun-plugin. maven-antrun-plugin is typically used to perform additional (custom) operations, declared in Ant XML terminology. Since we are deleting files releative to the given Maven project (and not JBOSS_HOME/deployments/... as in ear pom.xml), I think using maven-clean-plugin is better in this case. Anyway, executing 'mvn clean ...' will naturally invoke maven-clean-plugin (as part of Maven clean phase). With maven-antrun-plugin, we would need to: * define which Maven phase it's attached to (e.g. clean) * write a single Ant task with single <delete> Ant operation -- To view, visit http://gerrit.ovirt.org/5847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0295c12c7f9d119c57e5ae3f7d7c7d10e5596d61 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
