Michael Pasternak has posted comments on this change.
Change subject: add a new tool for auto-generate python entities from schema
......................................................................
Patch Set 9:
> seems not good text format. re-publish again.
> yes, I reuse the ovirtsdk.web.connection to download the schema. But there
> are 3 problems.
>
>
> 1. there are two elements in the schema with the same name in _rootClassMap.
> {"summary" : ApiSummary}
> {"summary" : VmSummary}
this is an issue indeed, turns out that in api.xsd two types used with same name
>
> so should we commit a patch for api.xsd to fix it?
> if yes, are the follow name OK?
> {"api_summary" : ApiSummary}
> {"vm_summary" : VmSummary}
>
we can't as it will break backward compatibility.
>
> 2. the _elementToClassMap is still used in other module, such as
> /src/ovirtsdk/utils/parsehelper.py
>
> but I have delete it in the params.py should I add it again?
>
>
rebase your code, i've deleted it few days ago.
>
> 3. when the main.py runs, it will import some modules, and these modules will
> import params.py. then it call __main__ to generate params.py.
> this is not right.
correct.
>
> I can move these import modules code after the code of params.py generation.
sounds good.
--
To view, visit http://gerrit.ovirt.org/4880
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I916f63f1ac68ce2e31456a90c1291997f671af99
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shao...@linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <a...@us.ibm.com>
Gerrit-Reviewer: Lei Li <li...@linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shao...@linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shum...@linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <we...@linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
