Gal Hammer has posted comments on this change.
Change subject: core: WIP - Add support for Qemu GA (#830954)
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Line 64: updateQemyGa(oldVmBase, entity, params.isQemuGaEnabled());
updateQemyGa -> updateQemuGa
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
Line 282: (VmDeviceType.SPICEVMC.getName().equals(device) &&
VmDeviceType.REDIR.getName().equals(type)) ||
Some people here don't like these red dots.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java
Line 21: QEMU("qemu"),
This is not a device type of QEMU. This is a virtio-serial channel which is
dedicated to qemu guest agent. I don't think this name is right as a device
type.
--
To view, visit http://gerrit.ovirt.org/5734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic59c307b49d606ebc06b84cecc4226fc94f29d97
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gal Hammer <gham...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ryan Harper <ry...@us.ibm.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
