Juan Hernandez has posted comments on this change. Change subject: packaging: Move JBoss modules from Makefile to spec ......................................................................
Patch Set 2: (1 inline comment) .................................................... File Makefile Line 311 > I thought the whole point of these modules are to be able to customize a > specific version of jar to shadow jboss implementation. Most of the modules are needed to override the same module in the jboss-as package in Fedora. The exception is the PostgreSQL module which will be needed for any deployment that we do to JBoss AS7, regardless of the operating system. > If that true the safest way to go may be to have maven pull this as any other > jar into the ear/lib. Let me insist that adding JDBC drivers to the deployment units of applications is not a good practice. In addition I am not sure if it will work in JBoss AS7, never tested it, but I guess that the application server will not be able to load the driver in order to configure the data source. If we do that we will probably need to create and manage our own connection pool, which is very frequent (unfortunately), but extremely bad practice in the JEE environment. If in the future we have two applications requiring conflicting versions of the JDBC driver then we should fix them, not ship two versions of the driver. Also, requiring two different versions of the driver (or of anything) will make packaging very difficult (if not impossible) in distributions like Fedora. -- To view, visit http://gerrit.ovirt.org/6060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4d4dd6d29c4db8486764d242d9c89ee8ecc0cba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
