Juan Hernandez has posted comments on this change. Change subject: packaging: Move JBoss modules from Makefile to spec ......................................................................
Patch Set 2: (1 inline comment) .................................................... File Makefile Line 311 Things would probably work if you put the JDBC driver in the ear/lib directory. But this is now how shared libraries, and in particular JDBC drivers should be deployed to an application server, and in particular in JBoss AS7. These shared libraries should be deployed to a place where different applications can use them. In JBoss AS7 this place is a JBoss module. That is what we are doing here. At the moment we have only one application, bet will probably have more than one in the future, and we should try to reuse libraries as much as possible in order to reduce the footprint of the server and to avoid class loading issues. It is true that the link is Fedora specific. That can be improved in a different change, including not only the Makefile but the root or ear POM files as well. -- To view, visit http://gerrit.ovirt.org/6060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4d4dd6d29c4db8486764d242d9c89ee8ecc0cba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
