Michael Kublin has posted comments on this change.
Change subject: engine:VM with remaining disks will not be deleted.(#822051)
..
Patch Set 5: (3 inline comments)
File
back
Eli Mesika has posted comments on this change.
Change subject: backend: Events on HA VM failures
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/dal/src/main
Yair Zaslavsky has posted comments on this change.
Change subject: Config tool: Get password via file or interactive console
..
Patch Set 1:
Basically I understand what you did so far.
I don't like all the stubs of setParser, a
Maor Lipchuk has posted comments on this change.
Change subject: engine:VM with remaining disks will not be deleted.(#822051)
..
Patch Set 5: (4 inline comments)
File
backen
ShaoHe Feng has posted comments on this change.
Change subject: add a new tool for auto-generate python entities from schema
..
Patch Set 7:
there's a conflict.
in main.py,
firstly, I should get the api.xsd by contextmanager.ge
Asaf Shakarchi has submitted this change and it was merged.
Change subject: webadmin: Added missing resources
..
webadmin: Added missing resources
Added missing resource VdcActionType___MoveOrCopyDisk
to LocalizedEnums.(java,pr
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: Added missing resources
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5893
To unsubscribe, visit http
Asaf Shakarchi has submitted this change and it was merged.
Change subject: webadmin: PM options fields are not visible in edit host dialog
(#834388)
..
webadmin: PM options fields are not visible in edit host dialog (#834388)
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: PM options fields are not visible in edit host dialog
(#834388)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.
Michael Kublin has posted comments on this change.
Change subject: core: ImportVmCommand - removing redundant update
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5947
To unsubscribe, visi
Michael Kublin has posted comments on this change.
Change subject: core: some simplification in VdsSelector
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5951
To unsubscribe, visit http://
Moti Asayag has submitted this change and it was merged.
Change subject: core: Replace logged stacktrace with error message
..
core: Replace logged stacktrace with error message
The patch replaces the stacktrace being printed t
Moti Asayag has posted comments on this change.
Change subject: core: Replace logged stacktrace with error message
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5950
To unsubscribe, visit http://gerrit.ovir
Juan Hernandez has posted comments on this change.
Change subject: packaging, tools: Generate engine-config.xml from template
..
Patch Set 10:
Replace JBOSS_SERVICE_NAME with ENGINE_SERVICE_NAME in engine-cleanup.py.
--
To vie
Daniel Erez has posted comments on this change.
Change subject: engine: template update, migration and pinned host (#835138)
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Michael Kublin has posted comments on this change.
Change subject: core: filter the vds by query
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5848
To unsubscribe, visit http://gerrit.ovir
Daniel Erez has posted comments on this change.
Change subject: webadmin: PM options fields are not visible in edit host dialog
(#834388)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/594
Michael Kublin has posted comments on this change.
Change subject: core: Replace logged stacktrace with error message
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5950
To unsubscribe, vis
Moti Asayag has uploaded a new change for review.
Change subject: core: Replace logged stacktrace with error message
..
core: Replace logged stacktrace with error message
The patch replaces the stacktrace being printed to the lo
Juan Hernandez has posted comments on this change.
Change subject: packaging, tools: Generate engine-config.xml from template
..
Patch Set 9:
Alex Lourie discovered that the XML parser chokes on the & used to separate
paramete
Asaf Shakarchi has submitted this change and it was merged.
Change subject: webadmin: no focus on first field when re-installing on a host
(#834121)
..
webadmin: no focus on first field when re-installing on a host (#834121)
h
Juan Hernandez has posted comments on this change.
Change subject: packaging: Check java version before starting
..
Patch Set 1: (1 inline comment)
File packaging/fedora/engi
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: no focus on first field when re-installing on a host
(#834121)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.o
Asaf Shakarchi has uploaded a new change for review.
Change subject: webadmin: PM options fields are not visible in edit host dialog
(#834388)
..
webadmin: PM options fields are not visible in edit host dialog (#834388)
https:/
Daniel Erez has posted comments on this change.
Change subject: webadmin: no focus on first field when re-installing on a host
(#834121)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5912
Yaniv Kaul has posted comments on this change.
Change subject: packaging: Check java version before starting
..
Patch Set 1: (1 inline comment)
File packaging/fedora/engine-s
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/1486/
Build Number: 1486
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 2,089
-
Changes Since La
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Replace spring .jar files with symlinks
..
packaging: Replace spring .jar files with symlinks
We are currently including the required spring framewo
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1566/
Build Number: 1566
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 2,089
-
Changes Since La
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/1517/
Build Number: 1517
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 2,089
-
Changes Since
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1565/
Build Number: 1565
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 2,086
-
Changes Since
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/1485/
Build Number: 1485
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 2,086
-
Changes Since
Daniel Erez has uploaded a new change for review.
Change subject: core: ImportVmCommand - removing redundant update
..
core: ImportVmCommand - removing redundant update
* Removing redundant 'imageToDestinationDomainMap' updating
Ori Liel has uploaded a new change for review.
Change subject: restapi: Map Disk Alias To Disk Name
..
restapi: Map Disk Alias To Disk Name
Backend has both 'name' and 'alias' for disk, for historic reasons.
API will expose only
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_rpms/1314/
Build Number: 1314
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 2,089
-
Changes Sinc
Project: http://jenkins.ovirt.org/job/ovirt_engine/
Build: http://jenkins.ovirt.org/job/ovirt_engine/2089/
Build Number: 2089
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Changes
Yaniv Dary has posted comments on this change.
Change subject: history: moved minimal etl version set ro per upgrade.
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Yaniv Dary has uploaded a new change for review.
Change subject: history: moved minimal etl version set ro per upgrade.
..
history: moved minimal etl version set ro per upgrade.
Change-Id: Ibe221debca3410aa156f68ae0f5b788277980e
Doron Fediuck has posted comments on this change.
Change subject: core: RegisterVdsQuery -removed CanDoAction()
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5631
To u
Project: http://jenkins.ovirt.org/job/ovirt_engine/
Build: http://jenkins.ovirt.org/job/ovirt_engine/2088/
Build Number: 2088
Build Status: Still Failing
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/1516/
Build Number: 1516
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 2,086
-
Changes Sinc
Ofer Schreiber has posted comments on this change.
Change subject: tools: More information in time_diff file
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5784
To unsubscribe, visit http:/
Shahar Havivi has posted comments on this change.
Change subject: Config tool: Get password via file or interactive console
..
Patch Set 1:
Still not finish, need to implement the CompositPassword as well, and more
testing is
Ori Liel has submitted this change and it was merged.
Change subject: restapi: Remove Whitespace
..
restapi: Remove Whitespace
Change-Id: Ibcb4cb2ff68589ddbe8110cf292b8402881fa681
Signed-off-by: Ori Liel
---
M
backend/manager
Ori Liel has posted comments on this change.
Change subject: restapi: Remove Whitespace
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5942
To unsubscribe, visit http://gerrit.ovi
Shahar Havivi has uploaded a new change for review.
Change subject: Config tool: Get password via file or interactive console
..
Config tool: Get password via file or interactive console
Change-Id: Icb0fe737e9d63ea5d066e31baa831
Ori Liel has uploaded a new change for review.
Change subject: restapi: Remove Whitespace
..
restapi: Remove Whitespace
Change-Id: Ibcb4cb2ff68589ddbe8110cf292b8402881fa681
Signed-off-by: Ori Liel
---
M
backend/manager/modules
Doron Fediuck has posted comments on this change.
Change subject: core: filter the vds by query
..
Patch Set 6: (1 inline comment)
Adding to Kublin's remark, some readability improvements.
.
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Support multiple applications
..
Patch Set 1: Looks good to me, approved
looks good to me
--
To view, visit http://gerrit.ovirt.org/5900
To unsubscr
Ori Liel has abandoned this change.
Change subject: restapi: Remove Whitespace
..
Patch Set 1: Abandoned
corrupt
--
To view, visit http://gerrit.ovirt.org/5941
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Mes
Ori Liel has uploaded a new change for review.
Change subject: restapi: Remove Whitespace
..
restapi: Remove Whitespace
Change-Id: I241907c056485e92dad6b48a5c76ca54cd851b3e
Signed-off-by: Ori Liel
---
M
backend/manager/modules
Ofer Schreiber has abandoned this change.
Change subject: Change rhevm.log -> engine.log in logs rotate script
..
Patch Set 1: Abandoned
Already fixed upstream.
--
To view, visit http://gerrit.ovirt.org/783
To unsubscribe, vis
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Moving to use execCmd in all scripts (#731686)
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4943
To unsubscri
Michael Kublin has posted comments on this change.
Change subject: core: filter the vds by query
..
Patch Set 6: Looks good to me, approved
(1 inline comment)
Small remark, if u can please change and u can merge
.
Ori Liel has submitted this change and it was merged.
Change subject: restapi: Add Correlation-Id Tests
..
restapi: Add Correlation-Id Tests
Change-Id: Ie5516c8d52eab8305ffa9dd0d84a9f15e7b87fc3
Signed-off-by: Ori Liel
---
M
b
Ori Liel has posted comments on this change.
Change subject: restapi: Add Correlation-Id Tests
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5823
To unsubscribe, visit http://ger
Ori Liel has submitted this change and it was merged.
Change subject: restapi: Add Floating Disks Tests
..
restapi: Add Floating Disks Tests
Signed-off-by: Ori Liel
Change-Id: I1f41e7b5000d29c3d44ecbee06572aa83ae7bcc0
---
M
b
Ori Liel has posted comments on this change.
Change subject: restapi: Add Floating Disks Tests
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5804
To unsubscribe, visit http://ger
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: SDK should expose api root resource /api #830513
..
sdk: SDK should expose api root resource /api #830513
https://bugzilla.redhat.com/show_bug.
Michael Pasternak has posted comments on this change.
Change subject: sdk: SDK should expose api root resource /api #830513
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5933
To
Michael Pasternak has posted comments on this change.
Change subject: cli: implement syntax error
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5929
To unsubscribe, visit http://
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: implement syntax error
..
cli: implement syntax error
Change-Id: Iff54978c1cba562f87677ef024f3aa394a2223f0
Signed-off-by: Michael Pasternak
--
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: recognise RequestError as command failure
..
cli: recognise RequestError as command failure
Change-Id: I88ab2db360e6eb04f9f562ed46f6cf67288d046
Michael Pasternak has posted comments on this change.
Change subject: cli: recognise RequestError as command failure
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5923
To unsubsc
Michael Pasternak has posted comments on this change.
Change subject: sdk: preform get() request on proxy construction to validate
user credentials #827878
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: preform get() request on proxy construction to validate
user credentials #827878
..
sdk: preform get() request on proxy construction to validat
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: extract error body xxx from detail produced by
application server #827881
..
sdk: extract error body xxx from detail produced by application se
Michael Pasternak has posted comments on this change.
Change subject: sdk: extract error body xxx from detail produced by
application server #827881
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http:/
Michael Pasternak has posted comments on this change.
Change subject: sdk: do not show brackets in error.detail
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5919
To unsubscribe,
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: do not show brackets in error.detail
..
sdk: do not show brackets in error.detail
engine returns can-do-action error messages with brackets
Ch
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: do not sort command options in /help/ commands
..
cli: do not sort command options in /help/ commands
sorting options breaks collections-based
Michael Pasternak has posted comments on this change.
Change subject: cli: do not sort command options in /help/ commands
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5917
To un
Ori Liel has posted comments on this change.
Change subject: sdk: SDK should expose api root resource /api #830513
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5933
T
Ori Liel has posted comments on this change.
Change subject: cli: implement syntax error
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5929
To unsubscribe, visit http:
Ori Liel has posted comments on this change.
Change subject: cli: recognise RequestError as command failure
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5923
To unsub
Ori Liel has posted comments on this change.
Change subject: sdk: preform get() request on proxy construction to validate
user credentials #827878
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, vis
Ori Liel has posted comments on this change.
Change subject: sdk: extract error body xxx from detail produced by
application server #827881
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http
Ori Liel has posted comments on this change.
Change subject: sdk: do not show brackets in error.detail
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5919
To unsubscrib
Juan Hernandez has posted comments on this change.
Change subject: core: Redirect to index when page not found
..
Patch Set 2:
Rebased. Sorry for the delay Laszlo.
--
To view, visit http://gerrit.ovirt.org/5753
To unsubscribe,
Ori Liel has posted comments on this change.
Change subject: cli: do not sort command options in /help/ commands
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5917
To
Michael Kublin has submitted this change and it was merged.
Change subject: core: VmInfoBuilder - null specParams fix
..
core: VmInfoBuilder - null specParams fix
A treatment for null specParams was introduced in I07c38327.
Fol
Michael Kublin has posted comments on this change.
Change subject: core: VmInfoBuilder - null specParams fix
..
Patch Set 2: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/5927
To unsubsc
Michael Kublin has posted comments on this change.
Change subject: core: UnPowerMock AddVmCommandTest
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5922
To unsubscribe, visit http://gerrit
Michael Kublin has submitted this change and it was merged.
Change subject: core: UnPowerMock AddVmCommandTest
..
core: UnPowerMock AddVmCommandTest
Removed PowerMock dependency from AddVmCommandTest and replaced it with
spying
Oved Ourfali has posted comments on this change.
Change subject: backend: Events on HA VM failures
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5938
To unsubscribe, visit http://gerrit.ovirt.org/settings
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: making cpu validations in cluster dialog conditional
..
webadmin: making cpu validations in cluster dialog conditional
CPU field will accept empty value
Oved Ourfali has uploaded a new change for review.
Change subject: backend: Events on HA VM failures
..
backend: Events on HA VM failures
Generate events when a highly available virtual mahine crashes or
fails to restart.
Chang
Juan Hernandez has posted comments on this change.
Change subject: packaging, tools: Generate engine-config.xml from template
..
Patch Set 8:
Rebased and applied the changes suggested by Alex Lourie.
--
To view, visit http://g
Alex Lourie has posted comments on this change.
Change subject: packaging, tools: Generate engine-config.xml from template
..
Patch Set 7: (2 inline comments)
File packaging/
Allon Mureinik has posted comments on this change.
Change subject: core: UnPowerMock AddVmCommandTest
..
Patch Set 3: Verified
... now with the changes intended for patchset 2.
--
To view, visit http://gerrit.ovirt.org/5922
To
Michael Pasternak has uploaded a new change for review.
Change subject: sdk: SDK should expose api root resource /api #830513
..
sdk: SDK should expose api root resource /api #830513
https://bugzilla.redhat.com/show_bug.cgi?id=8
Michael Pasternak has uploaded a new change for review.
Change subject: cli: implement syntax error
..
cli: implement syntax error
Change-Id: Iff54978c1cba562f87677ef024f3aa394a2223f0
Signed-off-by: Michael Pasternak
---
M src/
Allon Mureinik has posted comments on this change.
Change subject: core: UnPowerMock AddVmCommandTest
..
Patch Set 2: Verified
moved updating template discs to an init method called in the constructor, as
per mkublin's review
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Don't install postgres-ds.xml
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5902
To unsubscribe, visit http://
Mike Kolesnik has posted comments on this change.
Change subject: core: filter the vds by query
..
Patch Set 5: (2 inline comments)
How about test for the get by array method?
..
Alex Lourie has posted comments on this change.
Change subject: packaging: Moving to use execCmd in all scripts (#731686)
..
Patch Set 7: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Allon Mureinik has posted comments on this change.
Change subject: core: VmInfoBuilder - null specParams fix
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5927
To unsubscribe, visit http://gerrit.ovirt.org/
Allon Mureinik has uploaded a new change for review.
Change subject: core: VmInfoBuilder - null specParams fix
..
core: VmInfoBuilder - null specParams fix
A treatment for null specParams was introduced in I07c38327.
Following a
Michael Kublin has posted comments on this change.
Change subject: core: Making code readable
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5924
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerri
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Removing unused parameters from methods in QuotaManager.
..
engine: Removing unused parameters from methods in QuotaManager.
addCommandForExist
1 - 100 of 125 matches
Mail list logo
